From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: praghadeeshtks@zohomail.in, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Praghadeesh T K S <praghadeeshthevendria@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Rain River <rain.1986.08.12@gmail.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: ethernet/nvidia: fix possible condition with no effect
Date: Mon, 27 Jun 2022 11:38:12 -0700 [thread overview]
Message-ID: <20220627113812.08ae31f0@kernel.org> (raw)
In-Reply-To: <Yrg+NZHBNcu3KFXn@lunn.ch>
On Sun, 26 Jun 2022 13:08:37 +0200 Andrew Lunn wrote:
> On Sun, Jun 26, 2022 at 10:35:39AM +0000, Praghadeesh T K S wrote:
> > Fix Coccinelle bug, removed condition with no effect.
>
> This is not a coccinelle bug. If it was, you would be patching
> coccinelle, not the kernel.
I'd say the commit message is better than the commit ;)
Praghadeesh, could you fix Coccinelle to avoid matching:
if (/* case 1 */) {
/* BLOCK 1*/
} else (/* case 2 */ {
/* BLOCK 2 */
} else {
/* default == BLOCK 2 */
}
Because 99% of the time that construct is intentional.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Praghadeesh T K S <praghadeeshthevendria@gmail.com>,
Rain River <rain.1986.08.12@gmail.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, praghadeeshtks@zohomail.in,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] net: ethernet/nvidia: fix possible condition with no effect
Date: Mon, 27 Jun 2022 11:38:12 -0700 [thread overview]
Message-ID: <20220627113812.08ae31f0@kernel.org> (raw)
In-Reply-To: <Yrg+NZHBNcu3KFXn@lunn.ch>
On Sun, 26 Jun 2022 13:08:37 +0200 Andrew Lunn wrote:
> On Sun, Jun 26, 2022 at 10:35:39AM +0000, Praghadeesh T K S wrote:
> > Fix Coccinelle bug, removed condition with no effect.
>
> This is not a coccinelle bug. If it was, you would be patching
> coccinelle, not the kernel.
I'd say the commit message is better than the commit ;)
Praghadeesh, could you fix Coccinelle to avoid matching:
if (/* case 1 */) {
/* BLOCK 1*/
} else (/* case 2 */ {
/* BLOCK 2 */
} else {
/* default == BLOCK 2 */
}
Because 99% of the time that construct is intentional.
next prev parent reply other threads:[~2022-06-27 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 10:35 [PATCH] net: ethernet/nvidia: fix possible condition with no effect Praghadeesh T K S
2022-06-26 10:35 ` Praghadeesh T K S
2022-06-26 11:08 ` Andrew Lunn
2022-06-26 11:08 ` Andrew Lunn
2022-06-27 18:38 ` Jakub Kicinski [this message]
2022-06-27 18:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627113812.08ae31f0@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=praghadeeshthevendria@gmail.com \
--cc=praghadeeshtks@zohomail.in \
--cc=rain.1986.08.12@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.