All of lore.kernel.org
 help / color / mirror / Atom feed
* [nacked] mm-kasan-fix-null-pointer-dereference-warning-in-qlink_to_cache.patch removed from -mm tree
@ 2022-06-27 19:06 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-06-27 19:06 UTC (permalink / raw)
  To: mm-commits, vincenzo.frascino, skhan, ryabinin.a.a, glider,
	dvyukov, andreyknvl, gautammenghani201, akpm


The quilt patch titled
     Subject: mm/kasan: fix null pointer dereference warning in qlink_to_cache()
has been removed from the -mm tree.  Its filename was
     mm-kasan-fix-null-pointer-dereference-warning-in-qlink_to_cache.patch

This patch was dropped because it was nacked

------------------------------------------------------
From: Gautam Menghani <gautammenghani201@gmail.com>
Subject: mm/kasan: fix null pointer dereference warning in qlink_to_cache()
Date: Sun, 26 Jun 2022 22:33:55 +0530

virt_to_slab() declared in slab.h can return NULL if the address does not
belong to a slab.  This case is not handled in qlink_to_cache() in
quarantine.c, which can cause a NULL pointer dereference in
"virt_to_slab(qlink)->slab_cache".  This issue was discovered by fanalyzer
(my gcc version: 12.1.1 20220507)

Link: https://lkml.kernel.org/r/20220626170355.198913-1-gautammenghani201@gmail.com
Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/kasan/quarantine.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

--- a/mm/kasan/quarantine.c~mm-kasan-fix-null-pointer-dereference-warning-in-qlink_to_cache
+++ a/mm/kasan/quarantine.c
@@ -128,7 +128,13 @@ static unsigned long quarantine_batch_si
 
 static struct kmem_cache *qlink_to_cache(struct qlist_node *qlink)
 {
-	return virt_to_slab(qlink)->slab_cache;
+	struct slab *folio_slab = virt_to_slab(qlink);
+
+	if (!folio_slab) {
+		pr_warn("The address %p does not belong to a slab", qlink);
+		return NULL;
+	}
+	return folio_slab->slab_cache;
 }
 
 static void *qlink_to_object(struct qlist_node *qlink, struct kmem_cache *cache)
_

Patches currently in -mm which might be from gautammenghani201@gmail.com are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-27 19:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-27 19:06 [nacked] mm-kasan-fix-null-pointer-dereference-warning-in-qlink_to_cache.patch removed from -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.