All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
	Halil Pasic <pasic@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	linux-s390@vger.kernel.org,
	virtualization <virtualization@lists.linux-foundation.org>,
	kvm <kvm@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ben Hutchings <ben@decadent.org.uk>,
	David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH V3] virtio: disable notification hardening by default
Date: Tue, 28 Jun 2022 02:44:40 -0400	[thread overview]
Message-ID: <20220628023832-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACGkMEt=go5qAH+P0to6yyE2dPhyfFmOQP0jfuj=57PmD7Y3zg@mail.gmail.com>

On Tue, Jun 28, 2022 at 02:32:19PM +0800, Jason Wang wrote:
> > Question is are there drivers which kick before they are ready
> > to handle callbacks?
> 
> Let me try to have a look at all the drivers to answer this.

One thing to note is that I consider hardening probe and
hardening remove separate features. I think that at this point
for secured guests it is prudent to outright block device
removal - we have been finding races in removal for years.
Note sure there's a flag for that but it's probably not too hard to add
e.g. to pci core.

-- 
MST


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: linux-s390@vger.kernel.org, kvm <kvm@vger.kernel.org>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	virtualization <virtualization@lists.linux-foundation.org>,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Ben Hutchings <ben@decadent.org.uk>
Subject: Re: [PATCH V3] virtio: disable notification hardening by default
Date: Tue, 28 Jun 2022 02:44:40 -0400	[thread overview]
Message-ID: <20220628023832-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACGkMEt=go5qAH+P0to6yyE2dPhyfFmOQP0jfuj=57PmD7Y3zg@mail.gmail.com>

On Tue, Jun 28, 2022 at 02:32:19PM +0800, Jason Wang wrote:
> > Question is are there drivers which kick before they are ready
> > to handle callbacks?
> 
> Let me try to have a look at all the drivers to answer this.

One thing to note is that I consider hardening probe and
hardening remove separate features. I think that at this point
for secured guests it is prudent to outright block device
removal - we have been finding races in removal for years.
Note sure there's a flag for that but it's probably not too hard to add
e.g. to pci core.

-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2022-06-28  6:44 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22  1:29 [PATCH V3] virtio: disable notification hardening by default Jason Wang
2022-06-22  1:29 ` Jason Wang
2022-06-22  7:02 ` Michael S. Tsirkin
2022-06-22  7:02   ` Michael S. Tsirkin
2022-06-22  7:09   ` Jason Wang
2022-06-22  7:09     ` Jason Wang
2022-06-24  6:31     ` Michael S. Tsirkin
2022-06-24  6:31       ` Michael S. Tsirkin
2022-06-27  2:50       ` Jason Wang
2022-06-27  2:50         ` Jason Wang
2022-06-27  7:33         ` Michael S. Tsirkin
2022-06-27  7:33           ` Michael S. Tsirkin
2022-06-27  8:11           ` Jason Wang
2022-06-27  8:11             ` Jason Wang
2022-06-27  9:52             ` Michael S. Tsirkin
2022-06-27  9:52               ` Michael S. Tsirkin
2022-06-28  3:49               ` Jason Wang
2022-06-28  3:49                 ` Jason Wang
2022-06-28  4:59                 ` Michael S. Tsirkin
2022-06-28  4:59                   ` Michael S. Tsirkin
2022-06-28  6:17                   ` Jason Wang
2022-06-28  6:17                     ` Jason Wang
2022-06-28  6:24                     ` Michael S. Tsirkin
2022-06-28  6:24                       ` Michael S. Tsirkin
2022-06-28  6:32                       ` Jason Wang
2022-06-28  6:32                         ` Jason Wang
2022-06-28  6:44                         ` Michael S. Tsirkin [this message]
2022-06-28  6:44                           ` Michael S. Tsirkin
2022-06-29  4:07                     ` Jason Wang
2022-06-29  4:07                       ` Jason Wang
2022-06-29  6:31                       ` Michael S. Tsirkin
2022-06-29  6:31                         ` Michael S. Tsirkin
2022-06-29  7:02                         ` Jason Wang
2022-06-29  7:02                           ` Jason Wang
2022-06-29  7:15                           ` Michael S. Tsirkin
2022-06-29  7:15                             ` Michael S. Tsirkin
2022-06-29  8:34                             ` Jason Wang
2022-06-29  8:34                               ` Jason Wang
2022-06-29  8:52                               ` Michael S. Tsirkin
2022-06-29  8:52                                 ` Michael S. Tsirkin
2022-06-30  2:01                                 ` Jason Wang
2022-06-30  2:01                                   ` Jason Wang
2022-06-30  8:38                                   ` Michael S. Tsirkin
2022-06-30  8:38                                     ` Michael S. Tsirkin
2022-07-04  4:23                                     ` Jason Wang
2022-07-04  4:23                                       ` Jason Wang
2022-07-04  6:22                                       ` Michael S. Tsirkin
2022-07-04  6:22                                         ` Michael S. Tsirkin
2022-07-04  6:40                                         ` Jason Wang
2022-07-04  6:40                                           ` Jason Wang
2022-07-04  7:00                                           ` Michael S. Tsirkin
2022-07-04  7:00                                             ` Michael S. Tsirkin
2022-06-22  8:32 ` Cornelia Huck
2022-06-22  8:32   ` Cornelia Huck
2022-06-24  8:41 ` Xuan Zhuo
2022-06-24  8:41   ` Xuan Zhuo
2022-06-24  9:05   ` Michael S. Tsirkin
2022-06-24  9:05     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220628023832-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=agordeev@linux.ibm.com \
    --cc=ben@decadent.org.uk \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pasic@linux.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.