From: Jakub Kicinski <kuba@kernel.org>
To: Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: Vadim Fedorenko <vfedorenko@novek.ru>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Vadim Fedorenko <vadfed@fb.com>, Aya Levin <ayal@nvidia.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [RFC PATCH v2 3/3] ptp_ocp: implement DPLL ops
Date: Tue, 28 Jun 2022 20:24:14 -0700 [thread overview]
Message-ID: <20220628202414.02ac8fd1@kernel.org> (raw)
In-Reply-To: <20220628191124.qvto5tyfe63htxxr@bsd-mbp.dhcp.thefacebook.com>
On Tue, 28 Jun 2022 12:11:24 -0700 Jonathan Lemon wrote:
> > > 80-column limit (here and throughout the file)
> >
> > I thought this rule was relaxed up to 100-columns?
>
> Only in exceptional cases, IIRC. checkpatch complains too.
Yup, for networking I still prefer 80 chars.
My field of vision is narrow.
> > > 80 cols, and this should be done before ptp_ocp_complete()
> > > Also, should 'goto out', not return 0 and leak resources.
> >
> > I don't think we have to go with error path. Driver itself can work without
> > DPLL device registered, there is no hard dependency. The DPLL device will
> > not be registered and HW could not be configured/monitored via netlink, but
> > could still be usable.
>
> Not sure I agree with that - the DPLL device is selected in Kconfig, so
> users would expect to have it present. I think it makes more sense to
> fail if it cannot be allocated.
+1
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: Vadim Fedorenko <vfedorenko@novek.ru>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Vadim Fedorenko <vadfed@fb.com>, Aya Levin <ayal@nvidia.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [RFC PATCH v2 3/3] ptp_ocp: implement DPLL ops
Date: Tue, 28 Jun 2022 20:24:14 -0700 [thread overview]
Message-ID: <20220628202414.02ac8fd1@kernel.org> (raw)
In-Reply-To: <20220628191124.qvto5tyfe63htxxr@bsd-mbp.dhcp.thefacebook.com>
On Tue, 28 Jun 2022 12:11:24 -0700 Jonathan Lemon wrote:
> > > 80-column limit (here and throughout the file)
> >
> > I thought this rule was relaxed up to 100-columns?
>
> Only in exceptional cases, IIRC. checkpatch complains too.
Yup, for networking I still prefer 80 chars.
My field of vision is narrow.
> > > 80 cols, and this should be done before ptp_ocp_complete()
> > > Also, should 'goto out', not return 0 and leak resources.
> >
> > I don't think we have to go with error path. Driver itself can work without
> > DPLL device registered, there is no hard dependency. The DPLL device will
> > not be registered and HW could not be configured/monitored via netlink, but
> > could still be usable.
>
> Not sure I agree with that - the DPLL device is selected in Kconfig, so
> users would expect to have it present. I think it makes more sense to
> fail if it cannot be allocated.
+1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-29 3:24 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 19:24 [RFC PATCH v2 0/3] Create common DPLL/clock configuration API Vadim Fedorenko
2022-06-26 19:24 ` Vadim Fedorenko
2022-06-26 19:24 ` [RFC PATCH v2 1/3] dpll: Add DPLL framework base functions Vadim Fedorenko
2022-06-26 19:24 ` Vadim Fedorenko
2022-06-29 8:34 ` Stephen Boyd
2022-06-29 8:34 ` Stephen Boyd
2022-06-29 23:37 ` Vadim Fedorenko
2022-06-29 23:37 ` Vadim Fedorenko
2022-07-11 9:01 ` Kubalewski, Arkadiusz
2022-07-11 9:01 ` Kubalewski, Arkadiusz
2022-07-14 23:23 ` Vadim Fedorenko
2022-07-14 23:23 ` Vadim Fedorenko
2022-07-15 17:31 ` Kubalewski, Arkadiusz
2022-07-15 17:31 ` Kubalewski, Arkadiusz
2022-06-26 19:24 ` [RFC PATCH v2 2/3] dpll: add netlink events Vadim Fedorenko
2022-06-26 19:24 ` Vadim Fedorenko
2022-07-11 9:02 ` Kubalewski, Arkadiusz
2022-07-11 9:02 ` Kubalewski, Arkadiusz
2022-07-14 23:29 ` Vadim Fedorenko
2022-07-14 23:29 ` Vadim Fedorenko
2022-07-15 17:31 ` Kubalewski, Arkadiusz
2022-07-15 17:31 ` Kubalewski, Arkadiusz
2022-08-02 14:02 ` Kubalewski, Arkadiusz
2022-08-02 14:02 ` Kubalewski, Arkadiusz
2022-08-02 15:52 ` Jakub Kicinski
2022-08-02 15:52 ` Jakub Kicinski
2022-08-03 0:05 ` Vadim Fedorenko
2022-08-03 0:05 ` Vadim Fedorenko
2022-08-03 15:21 ` Stephen Hemminger
2022-08-03 15:21 ` Stephen Hemminger
2022-09-29 12:13 ` Jiri Pirko
2022-09-29 12:13 ` Jiri Pirko
2022-09-30 0:48 ` Vadim Fedorenko
2022-09-30 0:48 ` Vadim Fedorenko
2022-06-26 19:24 ` [RFC PATCH v2 3/3] ptp_ocp: implement DPLL ops Vadim Fedorenko
2022-06-26 19:24 ` Vadim Fedorenko
2022-06-27 19:34 ` Jonathan Lemon
2022-06-27 19:34 ` Jonathan Lemon
2022-06-27 22:13 ` Vadim Fedorenko
2022-06-27 22:13 ` Vadim Fedorenko
2022-06-28 19:11 ` Jonathan Lemon
2022-06-28 19:11 ` Jonathan Lemon
2022-06-29 3:24 ` Jakub Kicinski [this message]
2022-06-29 3:24 ` Jakub Kicinski
2022-06-29 23:31 ` Vadim Fedorenko
2022-06-29 23:31 ` Vadim Fedorenko
2022-09-29 11:33 ` Jiri Pirko
2022-09-29 11:33 ` Jiri Pirko
2022-09-30 0:56 ` Vadim Fedorenko
2022-09-30 0:56 ` Vadim Fedorenko
2022-09-01 12:02 ` [RFC PATCH v2 0/3] Create common DPLL/clock configuration API Gal Pressman
2022-09-01 12:02 ` Gal Pressman
2022-09-29 11:40 ` Jiri Pirko
2022-09-29 11:40 ` Jiri Pirko
2022-09-30 0:44 ` Vadim Fedorenko
2022-09-30 0:44 ` Vadim Fedorenko
2022-09-30 8:33 ` Jiri Pirko
2022-09-30 8:33 ` Jiri Pirko
2022-09-30 14:33 ` Jakub Kicinski
2022-09-30 14:33 ` Jakub Kicinski
2022-10-01 5:47 ` Jiri Pirko
2022-10-01 5:47 ` Jiri Pirko
2022-10-01 14:18 ` Jakub Kicinski
2022-10-01 14:18 ` Jakub Kicinski
2022-10-02 14:35 ` Jiri Pirko
2022-10-02 14:35 ` Jiri Pirko
2022-10-03 14:28 ` Jakub Kicinski
2022-10-03 14:28 ` Jakub Kicinski
2022-10-03 17:20 ` Vadim Fedorenko
2022-10-03 17:20 ` Vadim Fedorenko
2022-10-04 6:33 ` Jiri Pirko
2022-10-04 6:33 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628202414.02ac8fd1@kernel.org \
--to=kuba@kernel.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=ayal@nvidia.com \
--cc=jonathan.lemon@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vadfed@fb.com \
--cc=vfedorenko@novek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.