From: Christoph Hellwig <hch@lst.de>
To: Jason Yan <yanaijie@huawei.com>
Cc: tj@kernel.org, jack@suse.cz, hch@lst.de, axboe@kernel.dk,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2 1/2] blk-cgroup: factor out blkcg_iostat_update()
Date: Wed, 29 Jun 2022 07:20:11 +0200 [thread overview]
Message-ID: <20220629052011.GA16113@lst.de> (raw)
In-Reply-To: <20220629015022.2667445-2-yanaijie@huawei.com>
On Wed, Jun 29, 2022 at 09:50:21AM +0800, Jason Yan wrote:
> +static void blkcg_iostat_update(struct blkcg_gq *blkg,
> + struct blkg_iostat *cur, struct blkg_iostat *last)
Incorrect indentation. Continuing prototype lines are indented either
using two tabs or after the opening brace.
The rest looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-06-29 5:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 1:50 [PATCH v2 0/2] blk-cgroup: duplicated code refactor Jason Yan
2022-06-29 1:50 ` [PATCH v2 1/2] blk-cgroup: factor out blkcg_iostat_update() Jason Yan
2022-06-29 5:20 ` Christoph Hellwig [this message]
2022-06-29 1:50 ` [PATCH v2 2/2] blk-cgroup: factor out blkcg_free_all_cpd() Jason Yan
2022-06-29 5:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629052011.GA16113@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.