All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, tlanger@maxlinear.com,
	rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at,
	vigneshr@ti.com
Subject: Re: [PATCH v2 1/8] dt-bindings: mtd: intel: lgm-nand: Fix compatible string
Date: Fri, 1 Jul 2022 13:48:13 -0600	[thread overview]
Message-ID: <20220701194813.GA1399013-robh@kernel.org> (raw)
In-Reply-To: <20220629213508.1989600-2-martin.blumenstingl@googlemail.com>

On Wed, Jun 29, 2022 at 11:35:01PM +0200, Martin Blumenstingl wrote:
> The driver which was added at the same time as the dt-bindings uses the
> compatible string "intel,lgm-ebunand". Use the same compatible string
> also in the dt-bindings.
> 
> Fixes: 2f9cea8eae44f5 ("dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml
> index 30e0c66ab0eb..c45dd87fb5fd 100644
> --- a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml

The fix for the $id was to also rename the file.

> @@ -14,7 +14,7 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: intel,lgm-nand
> +    const: intel,lgm-ebunand
>  
>    reg:
>      maxItems: 6
> @@ -75,7 +75,7 @@ additionalProperties: false
>  examples:
>    - |
>      nand-controller@e0f00000 {
> -      compatible = "intel,lgm-nand";
> +      compatible = "intel,lgm-ebunand";
>        reg = <0xe0f00000 0x100>,
>              <0xe1000000 0x300>,
>              <0xe1400000 0x8000>,
> -- 
> 2.37.0
> 
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, tlanger@maxlinear.com,
	rtanwar@maxlinear.com, miquel.raynal@bootlin.com, richard@nod.at,
	vigneshr@ti.com
Subject: Re: [PATCH v2 1/8] dt-bindings: mtd: intel: lgm-nand: Fix compatible string
Date: Fri, 1 Jul 2022 13:48:13 -0600	[thread overview]
Message-ID: <20220701194813.GA1399013-robh@kernel.org> (raw)
In-Reply-To: <20220629213508.1989600-2-martin.blumenstingl@googlemail.com>

On Wed, Jun 29, 2022 at 11:35:01PM +0200, Martin Blumenstingl wrote:
> The driver which was added at the same time as the dt-bindings uses the
> compatible string "intel,lgm-ebunand". Use the same compatible string
> also in the dt-bindings.
> 
> Fixes: 2f9cea8eae44f5 ("dt-bindings: mtd: Add Nand Flash Controller support for Intel LGM SoC")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
>  Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml
> index 30e0c66ab0eb..c45dd87fb5fd 100644
> --- a/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml
> +++ b/Documentation/devicetree/bindings/mtd/intel,lgm-nand.yaml

The fix for the $id was to also rename the file.

> @@ -14,7 +14,7 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: intel,lgm-nand
> +    const: intel,lgm-ebunand
>  
>    reg:
>      maxItems: 6
> @@ -75,7 +75,7 @@ additionalProperties: false
>  examples:
>    - |
>      nand-controller@e0f00000 {
> -      compatible = "intel,lgm-nand";
> +      compatible = "intel,lgm-ebunand";
>        reg = <0xe0f00000 0x100>,
>              <0xe1000000 0x300>,
>              <0xe1400000 0x8000>,
> -- 
> 2.37.0
> 
> 

  reply	other threads:[~2022-07-01 19:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 21:35 [PATCH v2 0/8] intel-nand-controller: Fixes, cleanups and questions Martin Blumenstingl
2022-06-29 21:35 ` Martin Blumenstingl
2022-06-29 21:35 ` [PATCH v2 1/8] dt-bindings: mtd: intel: lgm-nand: Fix compatible string Martin Blumenstingl
2022-06-29 21:35   ` Martin Blumenstingl
2022-07-01 19:48   ` Rob Herring [this message]
2022-07-01 19:48     ` Rob Herring
2022-06-29 21:35 ` [PATCH v2 2/8] dt-bindings: mtd: intel: lgm-nand: Fix maximum chip select value Martin Blumenstingl
2022-06-29 21:35   ` Martin Blumenstingl
2022-07-01 19:48   ` Rob Herring
2022-07-01 19:48     ` Rob Herring
2022-06-29 21:35 ` [PATCH v2 3/8] mtd: rawnand: intel: Read the chip-select line from the correct OF node Martin Blumenstingl
2022-06-29 21:35   ` Martin Blumenstingl
2022-06-29 21:35 ` [PATCH v2 4/8] mtd: rawnand: intel: Remove undocumented compatible string Martin Blumenstingl
2022-06-29 21:35   ` Martin Blumenstingl
2022-06-29 21:35 ` [PATCH v2 5/8] mtd: rawnand: intel: Don't re-define NAND_DATA_IFACE_CHECK_ONLY Martin Blumenstingl
2022-06-29 21:35   ` Martin Blumenstingl
2022-06-29 21:35 ` [PATCH v2 6/8] mtd: rawnand: intel: Remove unused nand_pa member from ebu_nand_cs Martin Blumenstingl
2022-06-29 21:35   ` Martin Blumenstingl
2022-06-29 21:35 ` [PATCH v2 7/8] mtd: rawnand: intel: Remove unused clk_rate member from struct ebu_nand Martin Blumenstingl
2022-06-29 21:35   ` Martin Blumenstingl
2022-06-29 21:35 ` [PATCH v2 8/8] mtd: rawnand: intel: Use devm_platform_ioremap_resource_byname() Martin Blumenstingl
2022-06-29 21:35   ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220701194813.GA1399013-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=rtanwar@maxlinear.com \
    --cc=tlanger@maxlinear.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.