All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Foster <colin.foster@in-advantage.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Lars Povlsen <lars.povlsen@microchip.com>,
	Steen Hegelund <Steen.Hegelund@microchip.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Wolfram Sang <wsa@kernel.org>,
	Terry Bowman <terry.bowman@amd.com>,
	katie.morris@in-advantage.com
Subject: Re: [PATCH v12 net-next 9/9] mfd: ocelot: add support for the vsc7512 chip via spi
Date: Fri, 1 Jul 2022 14:04:49 -0700	[thread overview]
Message-ID: <20220701210449.GA3973665@euler> (raw)
In-Reply-To: <CAHp75VcfKS9Y+T5LPRk0SFHJCGarJ2wS2gwii=a+1it03S+_Og@mail.gmail.com>

On Fri, Jul 01, 2022 at 10:38:46PM +0200, Andy Shevchenko wrote:
> On Fri, Jul 1, 2022 at 9:26 PM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> >
> > The VSC7512 is a networking chip that contains several peripherals. Many of
> > these peripherals are currently supported by the VSC7513 and VSC7514 chips,
> > but those run on an internal CPU. The VSC7512 lacks this CPU, and must be
> > controlled externally.
> >
> > Utilize the existing drivers by referencing the chip as an MFD. Add support
> > for the two MDIO buses, the internal phys, pinctrl, and serial GPIO.
> 
> ...
> 
> > +       static const u8 dummy_buf[16] = {0};
> 
> On stack for DMA?! Hmm...

I'll respond to the rest of your comments as I go through them. But this
one in particular I'll apologize for. Ew. I'll fix that right up!

WARNING: multiple messages have this Message-ID (diff)
From: Colin Foster <colin.foster@in-advantage.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Lars Povlsen <lars.povlsen@microchip.com>,
	Steen Hegelund <Steen.Hegelund@microchip.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Wolfram Sang <wsa@kernel.org>,
	Terry Bowman <terry.bowman@amd.com>,
	katie.morris@in-advantage.com
Subject: Re: [PATCH v12 net-next 9/9] mfd: ocelot: add support for the vsc7512 chip via spi
Date: Fri, 1 Jul 2022 14:04:49 -0700	[thread overview]
Message-ID: <20220701210449.GA3973665@euler> (raw)
In-Reply-To: <CAHp75VcfKS9Y+T5LPRk0SFHJCGarJ2wS2gwii=a+1it03S+_Og@mail.gmail.com>

On Fri, Jul 01, 2022 at 10:38:46PM +0200, Andy Shevchenko wrote:
> On Fri, Jul 1, 2022 at 9:26 PM Colin Foster
> <colin.foster@in-advantage.com> wrote:
> >
> > The VSC7512 is a networking chip that contains several peripherals. Many of
> > these peripherals are currently supported by the VSC7513 and VSC7514 chips,
> > but those run on an internal CPU. The VSC7512 lacks this CPU, and must be
> > controlled externally.
> >
> > Utilize the existing drivers by referencing the chip as an MFD. Add support
> > for the two MDIO buses, the internal phys, pinctrl, and serial GPIO.
> 
> ...
> 
> > +       static const u8 dummy_buf[16] = {0};
> 
> On stack for DMA?! Hmm...

I'll respond to the rest of your comments as I go through them. But this
one in particular I'll apologize for. Ew. I'll fix that right up!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-01 21:05 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01 19:26 [PATCH v12 net-next 0/9] add support for VSC7512 control over SPI Colin Foster
2022-07-01 19:26 ` Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 1/9] mfd: ocelot: add helper to get regmap from a resource Colin Foster
2022-07-01 19:26   ` Colin Foster
2022-07-01 20:23   ` Andy Shevchenko
2022-07-01 20:23     ` Andy Shevchenko
2022-07-01 20:34     ` Colin Foster
2022-07-01 20:34       ` Colin Foster
2022-07-01 20:41       ` Andy Shevchenko
2022-07-01 20:41         ` Andy Shevchenko
2022-07-01 19:26 ` [PATCH v12 net-next 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration Colin Foster
2022-07-01 19:26   ` Colin Foster
2022-07-01 20:24   ` Andy Shevchenko
2022-07-01 20:24     ` Andy Shevchenko
2022-07-01 20:38     ` Colin Foster
2022-07-01 20:38       ` Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module Colin Foster
2022-07-01 19:26   ` Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration Colin Foster
2022-07-01 19:26   ` Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module Colin Foster
2022-07-01 19:26   ` Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 6/9] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration Colin Foster
2022-07-01 19:26   ` Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 7/9] resource: add define macro for register address resources Colin Foster
2022-07-01 19:26   ` Colin Foster
2022-07-01 19:26 ` [PATCH v12 net-next 8/9] dt-bindings: mfd: ocelot: add bindings for VSC7512 Colin Foster
2022-07-01 19:26   ` Colin Foster
2022-07-05 20:26   ` Rob Herring
2022-07-05 20:26     ` Rob Herring
2022-07-01 19:26 ` [PATCH v12 net-next 9/9] mfd: ocelot: add support for the vsc7512 chip via spi Colin Foster
2022-07-01 19:26   ` Colin Foster
2022-07-01 20:38   ` Andy Shevchenko
2022-07-01 20:38     ` Andy Shevchenko
2022-07-01 21:04     ` Colin Foster [this message]
2022-07-01 21:04       ` Colin Foster
2022-07-02  3:02   ` Jakub Kicinski
2022-07-02  3:02     ` Jakub Kicinski
2022-07-02 16:26     ` Colin Foster
2022-07-02 16:26       ` Colin Foster
2022-07-02 10:04   ` kernel test robot
2022-07-02 10:04     ` kernel test robot
2022-07-05 20:24 ` [PATCH v12 net-next 0/9] add support for VSC7512 control over SPI Rob Herring
2022-07-05 20:24   ` Rob Herring
2022-07-05 20:30   ` Colin Foster
2022-07-05 20:30     ` Colin Foster
2022-07-05 22:04     ` Vladimir Oltean
2022-07-05 22:04       ` Vladimir Oltean
2022-07-05 22:56       ` Vladimir Oltean
2022-07-05 22:56         ` Vladimir Oltean
2022-07-06  4:34         ` Colin Foster
2022-07-06  4:34           ` Colin Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220701210449.GA3973665@euler \
    --to=colin.foster@in-advantage.com \
    --cc=Steen.Hegelund@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=andy.shevchenko@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=katie.morris@in-advantage.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=lars.povlsen@microchip.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=terry.bowman@amd.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.