* [merged mm-hotfixes-stable] sh-convert-nommu-ioreunmap-to-static-inline-functions.patch removed from -mm tree
@ 2022-07-03 22:43 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-07-03 22:43 UTC (permalink / raw)
To: mm-commits, lkp, Jonathan.Cameron, hch, geert+renesas, akpm
The quilt patch titled
Subject: sh: convert nommu io{re,un}map() to static inline functions
has been removed from the -mm tree. Its filename was
sh-convert-nommu-ioreunmap-to-static-inline-functions.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Geert Uytterhoeven <geert+renesas@glider.be>
Subject: sh: convert nommu io{re,un}map() to static inline functions
Date: Mon, 20 Jun 2022 09:01:43 +0200
Recently, nommu iounmap() was converted from a static inline function to a
macro again, basically reverting commit 4580ba4ad2e6b8dd ("sh: Convert
iounmap() macros to inline functions"). With -Werror, this leads to build
failures like:
drivers/iio/adc/xilinx-ams.c: In function `ams_iounmap_ps':
drivers/iio/adc/xilinx-ams.c:1195:14: error: unused variable `ams' [-Werror=unused-variable]
1195 | struct ams *ams = data;
| ^~~
Fix this by replacing the macros for ioremap() and iounmap() by static
inline functions, based on <asm-generic/io.h>.
Link: https://lkml.kernel.org/r/8d1b1766260961799b04035e7bc39a7f59729f72.1655708312.git.geert+renesas@glider.be
Fixes: 13f1fc870dd74713 ("sh: move the ioremap implementation out of line")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/sh/include/asm/io.h | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--- a/arch/sh/include/asm/io.h~sh-convert-nommu-ioreunmap-to-static-inline-functions
+++ a/arch/sh/include/asm/io.h
@@ -271,8 +271,12 @@ static inline void __iomem *ioremap_prot
#endif /* CONFIG_HAVE_IOREMAP_PROT */
#else /* CONFIG_MMU */
-#define iounmap(addr) do { } while (0)
-#define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset))
+static inline void __iomem *ioremap(phys_addr_t offset, size_t size)
+{
+ return (void __iomem *)(unsigned long)offset;
+}
+
+static inline void iounmap(volatile void __iomem *addr) { }
#endif /* CONFIG_MMU */
#define ioremap_uc ioremap
_
Patches currently in -mm which might be from geert+renesas@glider.be are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-07-03 22:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-03 22:43 [merged mm-hotfixes-stable] sh-convert-nommu-ioreunmap-to-static-inline-functions.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.