All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "Eugenio Pérez" <eperezma@redhat.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [RFC PATCH 1/6] tools/virtio: fix build
Date: Mon, 4 Jul 2022 15:07:15 -0400	[thread overview]
Message-ID: <20220704150706-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220704171701.127665-2-sgarzare@redhat.com>

On Mon, Jul 04, 2022 at 07:16:56PM +0200, Stefano Garzarella wrote:
> Fix the build caused by the following changes:
> - phys_addr_t is now defined in tools/include/linux/types.h
> - dev_warn_once() is used in drivers/virtio/virtio_ring.c
> - linux/uio.h included by vringh.h use INT_MAX defined in limits.h
> 
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>

Post this separately?

> ---
>  tools/virtio/linux/kernel.h | 2 +-
>  tools/virtio/linux/vringh.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> index 0b493542e61a..21593bf97755 100644
> --- a/tools/virtio/linux/kernel.h
> +++ b/tools/virtio/linux/kernel.h
> @@ -29,7 +29,6 @@
>  #define READ                    0
>  #define WRITE                   1
>  
> -typedef unsigned long long phys_addr_t;
>  typedef unsigned long long dma_addr_t;
>  typedef size_t __kernel_size_t;
>  typedef unsigned int __wsum;
> @@ -136,6 +135,7 @@ static inline void *krealloc_array(void *p, size_t new_n, size_t new_size, gfp_t
>  #endif
>  #define dev_err(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
>  #define dev_warn(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
> +#define dev_warn_once(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
>  
>  #define min(x, y) ({				\
>  	typeof(x) _min1 = (x);			\
> diff --git a/tools/virtio/linux/vringh.h b/tools/virtio/linux/vringh.h
> index 9348957be56e..e11c6aece734 100644
> --- a/tools/virtio/linux/vringh.h
> +++ b/tools/virtio/linux/vringh.h
> @@ -1 +1,2 @@
> +#include <limits.h>
>  #include "../../../include/linux/vringh.h"
> -- 
> 2.36.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
	"Jason Wang" <jasowang@redhat.com>,
	linux-kernel@vger.kernel.org,
	"Eugenio Pérez" <eperezma@redhat.com>
Subject: Re: [RFC PATCH 1/6] tools/virtio: fix build
Date: Mon, 4 Jul 2022 15:07:15 -0400	[thread overview]
Message-ID: <20220704150706-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220704171701.127665-2-sgarzare@redhat.com>

On Mon, Jul 04, 2022 at 07:16:56PM +0200, Stefano Garzarella wrote:
> Fix the build caused by the following changes:
> - phys_addr_t is now defined in tools/include/linux/types.h
> - dev_warn_once() is used in drivers/virtio/virtio_ring.c
> - linux/uio.h included by vringh.h use INT_MAX defined in limits.h
> 
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>

Post this separately?

> ---
>  tools/virtio/linux/kernel.h | 2 +-
>  tools/virtio/linux/vringh.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/virtio/linux/kernel.h b/tools/virtio/linux/kernel.h
> index 0b493542e61a..21593bf97755 100644
> --- a/tools/virtio/linux/kernel.h
> +++ b/tools/virtio/linux/kernel.h
> @@ -29,7 +29,6 @@
>  #define READ                    0
>  #define WRITE                   1
>  
> -typedef unsigned long long phys_addr_t;
>  typedef unsigned long long dma_addr_t;
>  typedef size_t __kernel_size_t;
>  typedef unsigned int __wsum;
> @@ -136,6 +135,7 @@ static inline void *krealloc_array(void *p, size_t new_n, size_t new_size, gfp_t
>  #endif
>  #define dev_err(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
>  #define dev_warn(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
> +#define dev_warn_once(dev, format, ...) fprintf (stderr, format, ## __VA_ARGS__)
>  
>  #define min(x, y) ({				\
>  	typeof(x) _min1 = (x);			\
> diff --git a/tools/virtio/linux/vringh.h b/tools/virtio/linux/vringh.h
> index 9348957be56e..e11c6aece734 100644
> --- a/tools/virtio/linux/vringh.h
> +++ b/tools/virtio/linux/vringh.h
> @@ -1 +1,2 @@
> +#include <limits.h>
>  #include "../../../include/linux/vringh.h"
> -- 
> 2.36.1


  reply	other threads:[~2022-07-04 19:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 17:16 [RFC PATCH 0/6] virtio_test: add support for vhost-vdpa Stefano Garzarella
2022-07-04 17:16 ` Stefano Garzarella
2022-07-04 17:16 ` [RFC PATCH 1/6] tools/virtio: fix build Stefano Garzarella
2022-07-04 17:16   ` Stefano Garzarella
2022-07-04 19:07   ` Michael S. Tsirkin [this message]
2022-07-04 19:07     ` Michael S. Tsirkin
2022-07-05  7:14     ` Stefano Garzarella
2022-07-05  7:14       ` Stefano Garzarella
2022-07-04 17:16 ` [RFC PATCH 2/6] vhost_test: add $(srctree) on the included path Stefano Garzarella
2022-07-04 17:16   ` Stefano Garzarella
2022-07-04 17:16 ` [RFC PATCH 3/6] virtio_test: call __virtio_unbreak_device Stefano Garzarella
2022-07-04 17:16   ` Stefano Garzarella
2022-07-04 19:06   ` Michael S. Tsirkin
2022-07-04 19:06     ` Michael S. Tsirkin
2022-07-05  7:11     ` Stefano Garzarella
2022-07-05  7:11       ` Stefano Garzarella
2022-07-04 17:16 ` [RFC PATCH 4/6] tools/virtio: move feature negotiation in vdev_info_init() Stefano Garzarella
2022-07-04 17:16   ` Stefano Garzarella
2022-07-04 17:17 ` [RFC PATCH 5/6] virtio_test: support vhost-vdpa device Stefano Garzarella
2022-07-04 17:17   ` Stefano Garzarella
2022-07-04 17:17 ` [RFC PATCH 6/6] vdpasim: add vdpa_sim_test module Stefano Garzarella
2022-07-04 17:17   ` Stefano Garzarella
2022-07-12  8:34 ` [RFC PATCH 0/6] virtio_test: add support for vhost-vdpa Jason Wang
2022-07-12  8:34   ` Jason Wang
2022-07-12  8:45   ` Stefano Garzarella
2022-07-12  8:45     ` Stefano Garzarella
2022-07-12  8:47     ` Jason Wang
2022-07-12  8:47       ` Jason Wang
2022-07-12  9:20       ` Stefano Garzarella
2022-07-12  9:20         ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220704150706-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.