From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Quentin Schulz <foss+buildroot@0leil.net>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2] package/libcamera: strip symbols before signing IPA libs
Date: Mon, 4 Jul 2022 22:09:21 +0200 [thread overview]
Message-ID: <20220704200921.GK2521@scaer> (raw)
In-Reply-To: <CADvTj4p_22ayfvpD=+pKWppGJHD-Q2g48XwFnoKmmB22fw+g+g@mail.gmail.com>
James, All,
On 2022-07-04 11:29 -0600, James Hilliard spake thusly:
> On Fri, May 6, 2022 at 4:47 AM Quentin Schulz <foss+buildroot@0leil.net> wrote:
> > From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
[--SNIP--]
> > Buildroot may strip symbols, so we need to do the same before signing.
> > Since meson install target is also signing the IPA shlibs, let's strip
> > them before this happens.
[--SNIP--]
> > +LIBCAMERA_STRIP_FIND_CMD = \
> > + find $(@D)/build/src/ipa \
> > + $(if $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES)), \
> > + -not \( $(call findfileclauses,$(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) ) \
> > + -type f -name 'ipa_*.so' -print0
> Wouldn't this make it difficult to analyze core dumps since we need unstripped
> binaries for that?
This still obeys the BR2_STRIP_EXCLUDE_FILES, so a user investigating a
coredump would be able to rebuild by adding the IPA libs to the list of
files to exclude from stripping.
It also uses STRIPCMD, which a noop when stripping is disabled (see
below).
So this leaves this package in about the same state as all other
packages, I believe.
Regards,
Yann E. MORIN.
> > +
> > +define LIBCAMERA_BUILD_STRIP_IPA_SO
> > + $(LIBCAMERA_STRIP_FIND_CMD) | xargs --no-run-if-empty -0 $(STRIPCMD)
> > +endef
> > +
> > +LIBCAMERA_POST_BUILD_HOOKS += LIBCAMERA_BUILD_STRIP_IPA_SO
> > +
> > $(eval $(meson-package))
> > --
> > 2.35.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-07-04 20:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 10:46 [Buildroot] [PATCH v2] package/libcamera: strip symbols before signing IPA libs Quentin Schulz
2022-05-31 10:13 ` Quentin Schulz
2022-07-04 15:25 ` Quentin Schulz
2022-07-04 17:29 ` James Hilliard
2022-07-04 19:13 ` Kieran Bingham
2022-07-04 19:45 ` James Hilliard
2022-07-04 21:49 ` Kieran Bingham
2022-07-04 22:18 ` James Hilliard
2022-07-04 20:09 ` Yann E. MORIN [this message]
2022-07-04 20:18 ` James Hilliard
2022-07-04 20:04 ` Yann E. MORIN
2022-07-04 22:16 ` Kieran Bingham
2022-07-04 22:23 ` James Hilliard
2022-07-22 8:32 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704200921.GK2521@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=foss+buildroot@0leil.net \
--cc=james.hilliard1@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=quentin.schulz@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.