Re: [Buildroot] [PATCH v2] package/libcamera: strip symbols before signing IPA libs

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Quentin" == Quentin Schulz <foss+buildroot@0leil.net> writes:

 > From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
 > Open-Source IPA shlibs need to be signed in order to be runnable within
 > the same process, otherwise they are deemed Closed-Source and run in
 > another process and communicate over IPC.

 > The shlib installed on the target should be the same as the one signed
 > by libcamera during package creation otherwise the signature won't match
 > the shlib.

 > Buildroot sanitizes RPATH in a post build process. meson gets rid of
 > rpath while installing so we don't need to do it manually.

 > Buildroot may strip symbols, so we need to do the same before signing.
 > Since meson install target is also signing the IPA shlibs, let's strip
 > them before this happens.

 > Cc: Quentin Schulz <foss+buildroot@0leil.net>
 > Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
 > ---

 > v2:
 >  - use LIBCAMERA_POST_BUILD_HOOKS instead of replacing
 >  LIBCAMERA_INSTALL_TARGET_CMDS,
 >  - add handling of BR2_STRIP_EXCLUDE_FILES to not strip files which
 >  shouldn't,
 >  - added --no-run-if-empty to xargs, in case no IPA is selected,
 >  - removed stderr redirect and pipe to true to not hide useful
 >  information or fail the build if strip does not work,

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot