From: Shawn Guo <shawnguo@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: arnd@arndb.de, michael@walle.cc, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init()
Date: Tue, 5 Jul 2022 08:42:37 +0800 [thread overview]
Message-ID: <20220705004237.GP819983@dragon> (raw)
In-Reply-To: <20220628140249.1073809-1-yangyingliang@huawei.com>
On Tue, Jun 28, 2022 at 10:02:48PM +0800, Yang Yingliang wrote:
> In case of error, of_iomap() returns NULL pointer not ERR_PTR().
> The IS_ERR() test in the return value check should be replaced
> with NULL test and return -ENOMEM as error value.
>
> Fixes: ab4988d6a393 ("soc: fsl: guts: embed fsl_guts_get_svr() in probe()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied both, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, michael@walle.cc, arnd@arndb.de
Subject: Re: [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init()
Date: Tue, 5 Jul 2022 08:42:37 +0800 [thread overview]
Message-ID: <20220705004237.GP819983@dragon> (raw)
In-Reply-To: <20220628140249.1073809-1-yangyingliang@huawei.com>
On Tue, Jun 28, 2022 at 10:02:48PM +0800, Yang Yingliang wrote:
> In case of error, of_iomap() returns NULL pointer not ERR_PTR().
> The IS_ERR() test in the return value check should be replaced
> with NULL test and return -ENOMEM as error value.
>
> Fixes: ab4988d6a393 ("soc: fsl: guts: embed fsl_guts_get_svr() in probe()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied both, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, michael@walle.cc, arnd@arndb.de
Subject: Re: [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init()
Date: Tue, 5 Jul 2022 08:42:37 +0800 [thread overview]
Message-ID: <20220705004237.GP819983@dragon> (raw)
In-Reply-To: <20220628140249.1073809-1-yangyingliang@huawei.com>
On Tue, Jun 28, 2022 at 10:02:48PM +0800, Yang Yingliang wrote:
> In case of error, of_iomap() returns NULL pointer not ERR_PTR().
> The IS_ERR() test in the return value check should be replaced
> with NULL test and return -ENOMEM as error value.
>
> Fixes: ab4988d6a393 ("soc: fsl: guts: embed fsl_guts_get_svr() in probe()")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied both, thanks!
next prev parent reply other threads:[~2022-07-05 0:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 14:02 [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init() Yang Yingliang
2022-06-28 14:02 ` Yang Yingliang
2022-06-28 14:02 ` Yang Yingliang
2022-06-28 14:02 ` [PATCH -next 2/2] soc: fsl: guts: check return value after calling of_iomap() in fsl_guts_get_soc_uid() Yang Yingliang
2022-06-28 14:02 ` Yang Yingliang
2022-06-28 14:02 ` Yang Yingliang
2022-06-28 14:29 ` Michael Walle
2022-06-28 14:29 ` Michael Walle
2022-06-28 14:29 ` Michael Walle
2022-06-28 14:27 ` [PATCH -next 1/2] soc: fsl: guts: fix return value check in fsl_guts_init() Michael Walle
2022-06-28 14:27 ` Michael Walle
2022-06-28 14:27 ` Michael Walle
2022-07-05 0:42 ` Shawn Guo [this message]
2022-07-05 0:42 ` Shawn Guo
2022-07-05 0:42 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705004237.GP819983@dragon \
--to=shawnguo@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michael@walle.cc \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.