From: Jakub Kicinski <kuba@kernel.org>
To: Matthias May <matthias.may@westermo.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>
Subject: Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames
Date: Tue, 5 Jul 2022 18:25:12 -0700 [thread overview]
Message-ID: <20220705182512.309f205e@kernel.org> (raw)
In-Reply-To: <20220705145441.11992-1-matthias.may@westermo.com>
Please make sure to CC folks pointed out by scripts/get_maintainer.pl
On Tue, 5 Jul 2022 16:54:42 +0200 Matthias May wrote:
> Subject: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames
net-next may be more appropriate, since this never worked.
Unless it did, in which case we need a Fixes tag.
> The current code allows to inherit the TOS, TTL, DF from the payload
> when skb->protocol is ETH_P_IP or ETH_P_IPV6.
> However when the payload is VLAN encapsulated (e.g because the tunnel
> is of type GRETAP), then this inheriting does not work, because the
> visible skb->protocol is of type ETH_P_8021Q.
>
> Add a check on ETH_P_8021Q and subsequently check the payload protocol.
Do we need to check for 8021AD as well?
> Signed-off-by: Matthias May <matthias.may@westermo.com>
> ---
> net/ipv4/ip_tunnel.c | 21 +++++++++++++--------
Does ipv6 need the same treatment?
next prev parent reply other threads:[~2022-07-06 1:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 14:54 [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames Matthias May
2022-07-06 1:25 ` Jakub Kicinski [this message]
2022-07-06 7:07 ` Matthias May
2022-07-06 20:17 ` Jakub Kicinski
2022-07-07 11:57 ` Matthias May
2022-07-07 23:53 ` Jakub Kicinski
2022-07-07 13:59 ` Matthias May
2022-07-08 0:01 ` Jakub Kicinski
2022-07-09 20:09 ` Matthias May
2022-07-11 18:29 ` Jakub Kicinski
2022-07-11 22:06 ` Matthias May
2022-07-12 7:17 ` Nicolas Dichtel
2022-07-12 7:51 ` Matthias May
2022-07-12 8:09 ` Nicolas Dichtel
2022-07-20 15:24 ` Matthias May
2022-07-20 16:50 ` Jakub Kicinski
2022-07-21 8:25 ` Matthias May
2022-07-21 8:05 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705182512.309f205e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=matthias.may@westermo.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.