All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Matthias May <matthias.may@westermo.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
	<yoshfuji@linux-ipv6.org>, <dsahern@kernel.org>,
	<edumazet@google.com>, <pabeni@redhat.com>
Subject: Re: [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames
Date: Mon, 11 Jul 2022 11:29:11 -0700	[thread overview]
Message-ID: <20220711112911.6e387608@kernel.org> (raw)
In-Reply-To: <b046ef4e-cb97-2430-ab56-e2b615ac29eb@westermo.com>

On Sat, 9 Jul 2022 22:09:12 +0200 Matthias May wrote:
> >> How should i go forward with this?  
> > 
> > I think your example above shows that "tos 0xa0" does not work but the
> > conversation was about inheritance, does "tos inherit" not work either?  
> 
> Yes inherit does not work either. This is why i started setting it statically.
> However I think I figured out what is going on.
> Setting the TOS statically to 0xa0 does work... when the payload is IPv4 or IPv6,
> which is also when inheriting works. For everything other type of payload, it is always 0x00.
> This is different than with an IPv4 tunnel.
> Should i consider this a bug that needs to be fixed, or is that the intended behaviour?

Yes, most likely a bug if you ask me :S

  reply	other threads:[~2022-07-11 18:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 14:54 [PATCH net] ip_tunnel: allow to inherit from VLAN encapsulated IP frames Matthias May
2022-07-06  1:25 ` Jakub Kicinski
2022-07-06  7:07   ` Matthias May
2022-07-06 20:17     ` Jakub Kicinski
2022-07-07 11:57       ` Matthias May
2022-07-07 23:53         ` Jakub Kicinski
2022-07-07 13:59       ` Matthias May
2022-07-08  0:01         ` Jakub Kicinski
2022-07-09 20:09           ` Matthias May
2022-07-11 18:29             ` Jakub Kicinski [this message]
2022-07-11 22:06               ` Matthias May
2022-07-12  7:17                 ` Nicolas Dichtel
2022-07-12  7:51                   ` Matthias May
2022-07-12  8:09                     ` Nicolas Dichtel
2022-07-20 15:24                       ` Matthias May
2022-07-20 16:50                         ` Jakub Kicinski
2022-07-21  8:25                           ` Matthias May
2022-07-21  8:05                         ` Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220711112911.6e387608@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=matthias.may@westermo.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.