From: Jakub Kicinski <kuba@kernel.org>
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<jhs@mojatatu.com>, <xiyou.wangcong@gmail.com>,
<jiri@resnulli.us>, <davem@davemloft.net>, <edumazet@google.com>,
<pabeni@redhat.com>, <weiyongjun1@huawei.com>,
<yuehaibing@huawei.com>
Subject: Re: [PATCH net-next] net/sched: remove return value of unregister_tcf_proto_ops
Date: Tue, 5 Jul 2022 18:43:26 -0700 [thread overview]
Message-ID: <20220705184326.649a4e04@kernel.org> (raw)
In-Reply-To: <20220704124322.355211-1-shaozhengchao@huawei.com>
On Mon, 4 Jul 2022 20:43:22 +0800 Zhengchao Shao wrote:
> Return value of unregister_tcf_proto_ops is useless, remove it.
s/useless/unused/ ?
Should we add a WARN if the ops getting removed can't be found or there
are callers which depend on handling unregistered ops without a warning?
next prev parent reply other threads:[~2022-07-06 1:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 12:43 [PATCH net-next] net/sched: remove return value of unregister_tcf_proto_ops Zhengchao Shao
2022-07-06 1:43 ` Jakub Kicinski [this message]
2022-07-06 1:52 ` 答复: " shaozhengchao
2022-07-06 19:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705184326.649a4e04@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.