From: Jakub Kicinski <kuba@kernel.org>
To: shaozhengchao <shaozhengchao@huawei.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jhs@mojatatu.com" <jhs@mojatatu.com>,
"xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"weiyongjun (A)" <weiyongjun1@huawei.com>,
yuehaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH net-next] net/sched: remove return value of unregister_tcf_proto_ops
Date: Wed, 6 Jul 2022 12:58:06 -0700 [thread overview]
Message-ID: <20220706125806.4362d1ad@kernel.org> (raw)
In-Reply-To: <a92ed8b2b01e499b986ad7b9b0fe93a8@huawei.com>
On Wed, 6 Jul 2022 01:52:38 +0000 shaozhengchao wrote:
> Thank you for your apply. This patch does just remove the
> return value and change the function type from int to void. It
> doesn't remove the function.
I understand. I'm asking you to replace the word "useless" with
"unused". Additionally I'm asking to consider if instead of returning
an error code the function should print a warning if error has occured.
prev parent reply other threads:[~2022-07-06 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 12:43 [PATCH net-next] net/sched: remove return value of unregister_tcf_proto_ops Zhengchao Shao
2022-07-06 1:43 ` Jakub Kicinski
2022-07-06 1:52 ` 答复: " shaozhengchao
2022-07-06 19:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706125806.4362d1ad@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.