All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: linux-kernel@vger.kernel.org, ilpo.jarvinen@linux.intel.com,
	vz@mleia.com, devicetree@vger.kernel.org,
	Lino Sanfilippo <l.sanfilippo@kunbus.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org, andriy.shevchenko@linux.intel.com,
	p.rosenberger@kunbus.com, krzysztof.kozlowski+dt@linaro.org,
	lukas@wunner.de, jirislaby@kernel.org, robh+dt@kernel.org,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 5/9] dt_bindings: rs485: Correct delay values
Date: Tue, 5 Jul 2022 14:38:27 -0600	[thread overview]
Message-ID: <20220705203827.GA2583869-robh@kernel.org> (raw)
In-Reply-To: <20220703170039.2058202-6-LinoSanfilippo@gmx.de>

On Sun, 03 Jul 2022 19:00:35 +0200, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> 
> Currently the documentation claims that a maximum of 1000 msecs is allowed
> for RTS delays. However nothing actually checks the values read from device
> tree/ACPI and so it is possible to set much higher values.
> 
> There is already a maximum of 100 ms enforced for RTS delays that are set
> via the uart TIOCSRS485 ioctl. To be consistent with that use the same
> limit for DT/ACPI values.
> 
> Although this change is visible to userspace the risk of breaking anything
> when reducing the max delays from 1000 to 100 ms should be very low, since
> 100 ms is already a very high maximum for delays that are usually rather in
> the usecs range.
> 
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> ---
>  Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: linux-kernel@vger.kernel.org, ilpo.jarvinen@linux.intel.com,
	vz@mleia.com, devicetree@vger.kernel.org,
	Lino Sanfilippo <l.sanfilippo@kunbus.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-serial@vger.kernel.org, andriy.shevchenko@linux.intel.com,
	p.rosenberger@kunbus.com, krzysztof.kozlowski+dt@linaro.org,
	lukas@wunner.de, jirislaby@kernel.org, robh+dt@kernel.org,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 5/9] dt_bindings: rs485: Correct delay values
Date: Tue, 5 Jul 2022 14:38:27 -0600	[thread overview]
Message-ID: <20220705203827.GA2583869-robh@kernel.org> (raw)
In-Reply-To: <20220703170039.2058202-6-LinoSanfilippo@gmx.de>

On Sun, 03 Jul 2022 19:00:35 +0200, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> 
> Currently the documentation claims that a maximum of 1000 msecs is allowed
> for RTS delays. However nothing actually checks the values read from device
> tree/ACPI and so it is possible to set much higher values.
> 
> There is already a maximum of 100 ms enforced for RTS delays that are set
> via the uart TIOCSRS485 ioctl. To be consistent with that use the same
> limit for DT/ACPI values.
> 
> Although this change is visible to userspace the risk of breaking anything
> when reducing the max delays from 1000 to 100 ms should be very low, since
> 100 ms is already a very high maximum for delays that are usually rather in
> the usecs range.
> 
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> ---
>  Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-07-05 20:38 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-03 17:00 [PATCH v2 0/9] Fixes and cleanup for RS485 Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 1/9] serial: core: only get RS485 termination GPIO if supported Lino Sanfilippo
2022-07-03 17:00   ` Lino Sanfilippo
2022-07-03 18:27   ` Andy Shevchenko
2022-07-03 18:27     ` Andy Shevchenko
2022-07-04  9:01     ` Lino Sanfilippo
2022-07-04  9:01       ` Lino Sanfilippo
2022-07-04  9:55   ` Ilpo Järvinen
2022-07-04  9:55     ` Ilpo Järvinen
2022-07-04 15:07     ` Lino Sanfilippo
2022-07-04 15:07       ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 2/9] serial: core, 8250: set RS485 termination gpio in serial core Lino Sanfilippo
2022-07-03 17:00   ` Lino Sanfilippo
2022-07-03 18:31   ` Andy Shevchenko
2022-07-03 18:31     ` Andy Shevchenko
2022-07-04  9:25     ` Lino Sanfilippo
2022-07-04  9:25       ` Lino Sanfilippo
2022-07-04  9:51   ` Ilpo Järvinen
2022-07-04  9:51     ` Ilpo Järvinen
2022-07-04 15:13     ` Lino Sanfilippo
2022-07-04 15:13       ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 3/9] serial: core: move sanitizing of RS485 delays into own function Lino Sanfilippo
2022-07-03 17:00   ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 4/9] serial: core: sanitize RS485 delays read from device tree Lino Sanfilippo
2022-07-03 17:00   ` Lino Sanfilippo
2022-07-03 18:34   ` Andy Shevchenko
2022-07-03 18:34     ` Andy Shevchenko
2022-07-04  9:08     ` Lino Sanfilippo
2022-07-04  9:08       ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 5/9] dt_bindings: rs485: Correct delay values Lino Sanfilippo
2022-07-03 17:00   ` Lino Sanfilippo
2022-07-03 18:36   ` Andy Shevchenko
2022-07-03 18:36     ` Andy Shevchenko
2022-07-05 20:38   ` Rob Herring [this message]
2022-07-05 20:38     ` Rob Herring
2022-07-03 17:00 ` [PATCH v2 6/9] serial: 8250_dwlib: remove redundant sanity check for RS485 flags Lino Sanfilippo
2022-07-03 17:00   ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 7/9] serial: ar933x: Fix check for RS485 support Lino Sanfilippo
2022-07-03 17:00   ` Lino Sanfilippo
2022-07-03 18:39   ` Andy Shevchenko
2022-07-03 18:39     ` Andy Shevchenko
2022-07-04  9:21     ` Lino Sanfilippo
2022-07-04  9:21       ` Lino Sanfilippo
2022-07-04  9:53       ` Ilpo Järvinen
2022-07-04  9:53         ` Ilpo Järvinen
2022-07-03 17:00 ` [PATCH v2 8/9] serial: ar933x: Remove redundant assignment in rs485_config Lino Sanfilippo
2022-07-03 17:00   ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 9/9] serial: 8250: lpc18xx: Remove redundant sanity check for RS485 flags Lino Sanfilippo
2022-07-03 17:00   ` Lino Sanfilippo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220705203827.GA2583869-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=LinoSanfilippo@gmx.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=l.sanfilippo@kunbus.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=p.rosenberger@kunbus.com \
    --cc=robh+dt@kernel.org \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.