From: Rob Herring <robh@kernel.org>
To: Wolfram Sang <wsa@kernel.org>,
Alain Volmat <alain.volmat@foss.st.com>,
mark.rutland@arm.com, pierre-yves.mordret@foss.st.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, fabrice.gasnier@foss.st.com,
amelie.delaunay@foss.st.com
Subject: Re: [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line
Date: Wed, 6 Jul 2022 16:46:13 -0600 [thread overview]
Message-ID: <20220706224613.GD572635-robh@kernel.org> (raw)
In-Reply-To: <YryrpbBKsAKcL865@shikoro>
On Wed, Jun 29, 2022 at 09:44:37PM +0200, Wolfram Sang wrote:
> On Tue, Jun 28, 2022 at 07:41:15AM -0600, Rob Herring wrote:
> > On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> > > Update the dt-bindings of the i2c-stm32 drivers to avoid the
> > > needs for a reset property in the device-tree.
> >
> > That is clear from the diff, but why. Some chips don't have a reset?
> > If so, this should be combined with patch 2 as part of changes needed
> > for a new version.
>
> What do you mean? Patches 1+2 should be squashed together? I can do this
> when applying. Or do you mean something else?
Sorry, I meant combined with patch 3. If the new chip added in patch 3
doesn't have a reset, then 1 and 3 should be 1 patch. IOW, all the
changes needed for a new chip in 1 patch.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Wolfram Sang <wsa@kernel.org>,
Alain Volmat <alain.volmat@foss.st.com>,
mark.rutland@arm.com, pierre-yves.mordret@foss.st.com,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, fabrice.gasnier@foss.st.com,
amelie.delaunay@foss.st.com
Subject: Re: [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line
Date: Wed, 6 Jul 2022 16:46:13 -0600 [thread overview]
Message-ID: <20220706224613.GD572635-robh@kernel.org> (raw)
In-Reply-To: <YryrpbBKsAKcL865@shikoro>
On Wed, Jun 29, 2022 at 09:44:37PM +0200, Wolfram Sang wrote:
> On Tue, Jun 28, 2022 at 07:41:15AM -0600, Rob Herring wrote:
> > On Mon, Jun 20, 2022 at 12:54:02PM +0200, Alain Volmat wrote:
> > > Update the dt-bindings of the i2c-stm32 drivers to avoid the
> > > needs for a reset property in the device-tree.
> >
> > That is clear from the diff, but why. Some chips don't have a reset?
> > If so, this should be combined with patch 2 as part of changes needed
> > for a new version.
>
> What do you mean? Patches 1+2 should be squashed together? I can do this
> when applying. Or do you mean something else?
Sorry, I meant combined with patch 3. If the new chip added in patch 3
doesn't have a reset, then 1 and 3 should be 1 patch. IOW, all the
changes needed for a new chip in 1 patch.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-06 23:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 10:54 [PATCH 0/4] i2c: stm32: addition of STM32MP13 support Alain Volmat
2022-06-20 10:54 ` Alain Volmat
2022-06-20 10:54 ` [PATCH 1/4] dt-bindings: i2c: st,stm32-i2c: don't mandate a reset line Alain Volmat
2022-06-20 10:54 ` Alain Volmat
2022-06-28 13:41 ` Rob Herring
2022-06-28 13:41 ` Rob Herring
2022-06-29 19:44 ` Wolfram Sang
2022-06-29 19:44 ` Wolfram Sang
2022-07-06 22:46 ` Rob Herring [this message]
2022-07-06 22:46 ` Rob Herring
2022-07-07 6:38 ` Alain Volmat
2022-07-07 6:38 ` Alain Volmat
2022-06-20 10:54 ` [PATCH 2/4] i2c: stm32: only perform a reset if there is a reset property Alain Volmat
2022-06-20 10:54 ` Alain Volmat
2022-06-21 13:39 ` Pierre Yves MORDRET
2022-06-21 13:39 ` Pierre Yves MORDRET
2022-06-20 10:54 ` [PATCH 3/4] dt-bindings: i2c: st,stm32-i2c: add entry for stm32mp13 Alain Volmat
2022-06-20 10:54 ` Alain Volmat
2022-06-20 10:54 ` [PATCH 4/4] i2c: stm32: add support for the STM32MP13 soc Alain Volmat
2022-06-20 10:54 ` Alain Volmat
2022-06-21 13:40 ` Pierre Yves MORDRET
2022-06-21 13:40 ` Pierre Yves MORDRET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706224613.GD572635-robh@kernel.org \
--to=robh@kernel.org \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@foss.st.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.