From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
"David Airlie" <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
"Chris Wilson" <chris.p.wilson@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: fix a couple IS_ERR() vs NULL tests
Date: Fri, 8 Jul 2022 12:28:07 +0300 [thread overview]
Message-ID: <20220708092807.GK2316@kadam> (raw)
In-Reply-To: <861d92ff-1d30-10f5-e10b-403980af503b@intel.com>
On Fri, Jul 08, 2022 at 10:02:34AM +0100, Matthew Auld wrote:
> On 08/07/2022 09:40, Dan Carpenter wrote:
> > The shmem_pin_map() function doesn't return error pointers, it returns
> > NULL.
> >
> > Fixes: a0d3fdb628b8 ("drm/i915/gt: Split logical ring contexts from execlist submission"
>
> I think this should be:
>
> Fixes: be1cb55a07bf ("drm/i915/gt: Keep a no-frills swappable copy of the
> default context state")
>
Ah, right. I will resend.
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> There looks to be one more in gvt/cmd_parser.c?
>
I fixed that one in a separate patch?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: "Jani Nikula" <jani.nikula@linux.intel.com>,
"Chris Wilson" <chris.p.wilson@intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Ramalingam C" <ramalingam.c@intel.com>,
"Matt Roper" <matthew.d.roper@intel.com>,
"Akeem G Abodunrin" <akeem.g.abodunrin@intel.com>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"Daniele Ceraolo Spurio" <daniele.ceraolospurio@intel.com>,
intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/i915/selftests: fix a couple IS_ERR() vs NULL tests
Date: Fri, 8 Jul 2022 12:28:07 +0300 [thread overview]
Message-ID: <20220708092807.GK2316@kadam> (raw)
In-Reply-To: <861d92ff-1d30-10f5-e10b-403980af503b@intel.com>
On Fri, Jul 08, 2022 at 10:02:34AM +0100, Matthew Auld wrote:
> On 08/07/2022 09:40, Dan Carpenter wrote:
> > The shmem_pin_map() function doesn't return error pointers, it returns
> > NULL.
> >
> > Fixes: a0d3fdb628b8 ("drm/i915/gt: Split logical ring contexts from execlist submission"
>
> I think this should be:
>
> Fixes: be1cb55a07bf ("drm/i915/gt: Keep a no-frills swappable copy of the
> default context state")
>
Ah, right. I will resend.
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> There looks to be one more in gvt/cmd_parser.c?
>
I fixed that one in a separate patch?
regards,
dan carpenter
next prev parent reply other threads:[~2022-07-08 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 8:40 [Intel-gfx] [PATCH] drm/i915/selftests: fix a couple IS_ERR() vs NULL tests Dan Carpenter
2022-07-08 8:40 ` Dan Carpenter
2022-07-08 9:02 ` [Intel-gfx] " Matthew Auld
2022-07-08 9:02 ` Matthew Auld
2022-07-08 9:28 ` Dan Carpenter [this message]
2022-07-08 9:28 ` Dan Carpenter
2022-07-08 9:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-07-08 20:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708092807.GK2316@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=chris.p.wilson@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=michal.winiarski@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.