From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [akpm-mm:mm-unstable 284/293] mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc'
Date: Sun, 10 Jul 2022 08:01:29 +0800 [thread overview]
Message-ID: <202207100715.TBIYQ4fc-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2809 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: "Zach O'Keefe" <zokeefe@google.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
head: 0e9f775fb0b4adf1a4ef50ea156ead09a0fc5194
commit: 9f626ffb1d1c5c26b4a8e0fdffec784a5f773274 [284/293] mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse
:::::: branch date: 21 hours ago
:::::: commit date: 21 hours ago
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220710/202207100715.TBIYQ4fc-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc'
vim +/cc +2409 mm/khugepaged.c
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2386
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2387 int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev,
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2388 unsigned long start, unsigned long end)
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2389 {
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2390 struct collapse_control *cc;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2391 struct mm_struct *mm = vma->vm_mm;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2392 unsigned long hstart, hend, addr;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2393 int thps = 0, last_fail = SCAN_FAIL;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2394 bool mmap_locked = true;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2395
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2396 BUG_ON(vma->vm_start > start);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2397 BUG_ON(vma->vm_end < end);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2398
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2399 cc = kmalloc(sizeof(*cc), GFP_KERNEL);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2400 if (!cc)
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2401 return -ENOMEM;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2402 cc->is_khugepaged = false;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2403 cc->last_target_node = NUMA_NO_NODE;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2404
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2405 *prev = vma;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2406
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2407 /* TODO: Support file/shmem */
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2408 if (!vma->anon_vma || !vma_is_anonymous(vma))
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 @2409 return -EINVAL;
--
0-DAY CI Kernel Test Service
https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [akpm-mm:mm-unstable 284/293] mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc'
Date: Tue, 12 Jul 2022 15:35:35 +0300 [thread overview]
Message-ID: <202207100715.TBIYQ4fc-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2478 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
head: 0e9f775fb0b4adf1a4ef50ea156ead09a0fc5194
commit: 9f626ffb1d1c5c26b4a8e0fdffec784a5f773274 [284/293] mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220710/202207100715.TBIYQ4fc-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc'
vim +/cc +2409 mm/khugepaged.c
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2387 int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev,
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2388 unsigned long start, unsigned long end)
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2389 {
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2390 struct collapse_control *cc;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2391 struct mm_struct *mm = vma->vm_mm;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2392 unsigned long hstart, hend, addr;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2393 int thps = 0, last_fail = SCAN_FAIL;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2394 bool mmap_locked = true;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2395
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2396 BUG_ON(vma->vm_start > start);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2397 BUG_ON(vma->vm_end < end);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2398
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2399 cc = kmalloc(sizeof(*cc), GFP_KERNEL);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2400 if (!cc)
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2401 return -ENOMEM;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2402 cc->is_khugepaged = false;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2403 cc->last_target_node = NUMA_NO_NODE;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2404
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2405 *prev = vma;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2406
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2407 /* TODO: Support file/shmem */
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2408 if (!vma->anon_vma || !vma_is_anonymous(vma))
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 @2409 return -EINVAL;
kfree(cc);?
--
0-DAY CI Kernel Test Service
https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Zach O'Keefe <zokeefe@google.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: [akpm-mm:mm-unstable 284/293] mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc'
Date: Tue, 12 Jul 2022 15:35:35 +0300 [thread overview]
Message-ID: <202207100715.TBIYQ4fc-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
head: 0e9f775fb0b4adf1a4ef50ea156ead09a0fc5194
commit: 9f626ffb1d1c5c26b4a8e0fdffec784a5f773274 [284/293] mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220710/202207100715.TBIYQ4fc-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc'
vim +/cc +2409 mm/khugepaged.c
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2387 int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev,
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2388 unsigned long start, unsigned long end)
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2389 {
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2390 struct collapse_control *cc;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2391 struct mm_struct *mm = vma->vm_mm;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2392 unsigned long hstart, hend, addr;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2393 int thps = 0, last_fail = SCAN_FAIL;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2394 bool mmap_locked = true;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2395
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2396 BUG_ON(vma->vm_start > start);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2397 BUG_ON(vma->vm_end < end);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2398
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2399 cc = kmalloc(sizeof(*cc), GFP_KERNEL);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2400 if (!cc)
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2401 return -ENOMEM;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2402 cc->is_khugepaged = false;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2403 cc->last_target_node = NUMA_NO_NODE;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2404
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2405 *prev = vma;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2406
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2407 /* TODO: Support file/shmem */
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2408 if (!vma->anon_vma || !vma_is_anonymous(vma))
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 @2409 return -EINVAL;
kfree(cc);?
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next reply other threads:[~2022-07-10 0:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 0:01 kernel test robot [this message]
2022-07-12 12:35 ` [akpm-mm:mm-unstable 284/293] mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc' Dan Carpenter
2022-07-12 12:35 ` Dan Carpenter
2022-07-12 13:46 ` Zach O'Keefe
2022-07-12 13:46 ` Zach O'Keefe
2022-07-12 17:02 ` Yang Shi
2022-07-12 17:02 ` Yang Shi
2022-07-13 14:24 ` Zach O'Keefe
2022-07-13 14:24 ` Zach O'Keefe
2022-07-13 19:04 ` Yang Shi
2022-07-13 19:04 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207100715.TBIYQ4fc-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.