All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Hajo Noerenberg" <hajo-linux-bugzilla@noerenberg.de>,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: mvebu: Dispose INTx irqs prior to removing INTx domain
Date: Mon, 11 Jul 2022 13:44:18 +0200	[thread overview]
Message-ID: <20220711134418.69f20344@thinkpad> (raw)
In-Reply-To: <20220709161858.15031-1-pali@kernel.org>

On Sat,  9 Jul 2022 18:18:58 +0200
Pali Rohár <pali@kernel.org> wrote:

> Documentation for irq_domain_remove() says that all mapping within the
> domain must be disposed prior to domain remove.
> 
> Currently INTx irqs are not disposed in pci-mvebu.c device unbind callback
> which cause that kernel crashes after unloading driver and trying to read
> /sys/kernel/debug/irq/irqs/<num> or /proc/interrupts.
> 
> Fixes: ec075262648f ("PCI: mvebu: Implement support for legacy INTx interrupts")
> Reported-by: Hajo Noerenberg <hajo-linux-bugzilla@noerenberg.de>
> Signed-off-by: Pali Rohár <pali@kernel.org>

Reviewed-by: Marek Behún <kabel@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: "Marek Behún" <kabel@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Hajo Noerenberg" <hajo-linux-bugzilla@noerenberg.de>,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: mvebu: Dispose INTx irqs prior to removing INTx domain
Date: Mon, 11 Jul 2022 13:44:18 +0200	[thread overview]
Message-ID: <20220711134418.69f20344@thinkpad> (raw)
In-Reply-To: <20220709161858.15031-1-pali@kernel.org>

On Sat,  9 Jul 2022 18:18:58 +0200
Pali Rohár <pali@kernel.org> wrote:

> Documentation for irq_domain_remove() says that all mapping within the
> domain must be disposed prior to domain remove.
> 
> Currently INTx irqs are not disposed in pci-mvebu.c device unbind callback
> which cause that kernel crashes after unloading driver and trying to read
> /sys/kernel/debug/irq/irqs/<num> or /proc/interrupts.
> 
> Fixes: ec075262648f ("PCI: mvebu: Implement support for legacy INTx interrupts")
> Reported-by: Hajo Noerenberg <hajo-linux-bugzilla@noerenberg.de>
> Signed-off-by: Pali Rohár <pali@kernel.org>

Reviewed-by: Marek Behún <kabel@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-07-11 11:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-09 16:18 [PATCH] PCI: mvebu: Dispose INTx irqs prior to removing INTx domain Pali Rohár
2022-07-09 16:18 ` Pali Rohár
2022-07-10  0:14 ` Pali Rohár
2022-07-10  0:14   ` Pali Rohár
2022-08-09  1:26   ` Jianjun Wang
2022-08-09  1:26     ` Jianjun Wang
2022-07-11 11:44 ` Marek Behún [this message]
2022-07-11 11:44   ` Marek Behún
2022-08-08 18:44 ` Pali Rohár
2022-08-08 18:44   ` Pali Rohár
2022-08-09  2:00   ` Bjorn Helgaas
2022-08-09  2:00     ` Bjorn Helgaas
2022-08-09 13:39     ` Pali Rohár
2022-08-09 13:39       ` Pali Rohár
2022-08-25 13:43       ` Lorenzo Pieralisi
2022-08-25 13:43         ` Lorenzo Pieralisi
2022-08-29  9:54 ` Lorenzo Pieralisi
2022-08-29  9:54   ` Lorenzo Pieralisi
  -- strict thread matches above, loose matches on Subject: below --
2024-06-19 14:28 Marek Behún
2024-06-20  6:28 ` Manivannan Sadhasivam
2024-06-20 13:16 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220711134418.69f20344@thinkpad \
    --to=kabel@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=hajo-linux-bugzilla@noerenberg.de \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=pali@kernel.org \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.