From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one
Date: Mon, 11 Jul 2022 16:30:15 +0200 [thread overview]
Message-ID: <20220711143015.GA22291@lst.de> (raw)
In-Reply-To: <20220711102747.359525-1-agruenba@redhat.com>
On Mon, Jul 11, 2022 at 12:27:47PM +0200, Andreas Gruenbacher wrote:
> Can you add the below follow-up cleanup?
> - gfs2_lm(sdp, "gfs2_ail1_start_one (generic_writepages) "
> - "returned: %d\n", ret);
> + gfs2_lm(sdp, "gfs2_ail1_start_one returned %d\n", ret);
The cleanup looks fine to me, yes.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bob Peterson <rpeterso@redhat.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
Johannes Thumshirn <jth@kernel.org>,
cluster-devel@redhat.com, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one
Date: Mon, 11 Jul 2022 16:30:15 +0200 [thread overview]
Message-ID: <20220711143015.GA22291@lst.de> (raw)
In-Reply-To: <20220711102747.359525-1-agruenba@redhat.com>
On Mon, Jul 11, 2022 at 12:27:47PM +0200, Andreas Gruenbacher wrote:
> Can you add the below follow-up cleanup?
> - gfs2_lm(sdp, "gfs2_ail1_start_one (generic_writepages) "
> - "returned: %d\n", ret);
> + gfs2_lm(sdp, "gfs2_ail1_start_one returned %d\n", ret);
The cleanup looks fine to me, yes.
next prev parent reply other threads:[~2022-07-11 14:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 4:14 [Cluster-devel] remove iomap_writepage Christoph Hellwig
2022-07-11 4:14 ` Christoph Hellwig
2022-07-11 4:14 ` [Cluster-devel] [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one Christoph Hellwig
2022-07-11 4:14 ` Christoph Hellwig
2022-07-11 10:27 ` [Cluster-devel] " Andreas Gruenbacher
2022-07-11 10:27 ` Andreas Gruenbacher
2022-07-11 14:30 ` Christoph Hellwig [this message]
2022-07-11 14:30 ` Christoph Hellwig
2022-07-11 4:14 ` [Cluster-devel] [PATCH 2/4] gfs2: remove ->writepage Christoph Hellwig
2022-07-11 4:14 ` Christoph Hellwig
2022-07-11 23:22 ` [Cluster-devel] " Andreas Grünbacher
2022-07-11 23:22 ` Andreas Grünbacher
2022-07-12 4:57 ` [Cluster-devel] " Christoph Hellwig
2022-07-12 4:57 ` Christoph Hellwig
2022-07-11 4:14 ` [Cluster-devel] [PATCH 3/4] zonefs: " Christoph Hellwig
2022-07-11 4:14 ` Christoph Hellwig
2022-07-11 4:47 ` [Cluster-devel] " Damien Le Moal
2022-07-11 4:47 ` Damien Le Moal
2022-07-11 9:12 ` [Cluster-devel] " Johannes Thumshirn
2022-07-11 9:12 ` Johannes Thumshirn
2022-07-11 4:14 ` [Cluster-devel] [PATCH 4/4] iomap: remove iomap_writepage Christoph Hellwig
2022-07-11 4:14 ` Christoph Hellwig
2022-07-11 4:48 ` [Cluster-devel] " Damien Le Moal
2022-07-11 4:48 ` Damien Le Moal
-- strict thread matches above, loose matches on Subject: below --
2022-07-19 4:13 [Cluster-devel] remove iomap_writepage v2 Christoph Hellwig
2022-07-19 4:13 ` [Cluster-devel] [PATCH 1/4] gfs2: stop using generic_writepages in gfs2_ail1_start_one Christoph Hellwig
2023-01-18 21:22 ` Andreas Gruenbacher
2023-01-19 6:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711143015.GA22291@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.