All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: kernel test robot <lkp@intel.com>,
	kbuild-all@lists.01.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU
Date: Thu, 14 Jul 2022 20:57:00 +0200	[thread overview]
Message-ID: <20220714185700.6137-1-pali@kernel.org> (raw)

Custom ARM version of pci_remap_iospace() is implemented only for MMU
kernel builds. So do not define pci_remap_iospace() without CONFIG_MMU.

See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp@intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp@intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp@intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp@intel.com/

Fixes: bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Pali Rohár <pali@kernel.org>

---

PING!!!! Is somebody interested in fixing these compile errors? As nobody
answered to my emails where I proposed this fix more than half year ago and
asked for opinion...

https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2@pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4@pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram@pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq@pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof@pali/

If nobody is interested then please STOP sending me these Intel "0-DAY CI
Kernel Test Service" emails. Thanks!
---
 arch/arm/include/asm/io.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
index eba7cbc93b86..47cf79229b7c 100644
--- a/arch/arm/include/asm/io.h
+++ b/arch/arm/include/asm/io.h
@@ -180,10 +180,12 @@ void pci_ioremap_set_mem_type(int mem_type);
 static inline void pci_ioremap_set_mem_type(int mem_type) {}
 #endif
 
+#ifdef CONFIG_MMU
 struct resource;
 
 #define pci_remap_iospace pci_remap_iospace
 int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr);
+#endif
 
 /*
  * PCI configuration space mapping function.
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Pali Rohár <pali@kernel.org>
To: kbuild-all@lists.01.org
Subject: [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU
Date: Thu, 14 Jul 2022 20:57:00 +0200	[thread overview]
Message-ID: <20220714185700.6137-1-pali@kernel.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1894 bytes --]

Custom ARM version of pci_remap_iospace() is implemented only for MMU
kernel builds. So do not define pci_remap_iospace() without CONFIG_MMU.

See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp(a)intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp(a)intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp(a)intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp(a)intel.com/

Fixes: bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Pali Rohár <pali@kernel.org>

---

PING!!!! Is somebody interested in fixing these compile errors? As nobody
answered to my emails where I proposed this fix more than half year ago and
asked for opinion...

https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2(a)pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4(a)pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram(a)pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq(a)pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof(a)pali/

If nobody is interested then please STOP sending me these Intel "0-DAY CI
Kernel Test Service" emails. Thanks!
---
 arch/arm/include/asm/io.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
index eba7cbc93b86..47cf79229b7c 100644
--- a/arch/arm/include/asm/io.h
+++ b/arch/arm/include/asm/io.h
@@ -180,10 +180,12 @@ void pci_ioremap_set_mem_type(int mem_type);
 static inline void pci_ioremap_set_mem_type(int mem_type) {}
 #endif
 
+#ifdef CONFIG_MMU
 struct resource;
 
 #define pci_remap_iospace pci_remap_iospace
 int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr);
+#endif
 
 /*
  * PCI configuration space mapping function.
-- 
2.20.1

WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali@kernel.org>
To: kernel test robot <lkp@intel.com>,
	kbuild-all@lists.01.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU
Date: Thu, 14 Jul 2022 20:57:00 +0200	[thread overview]
Message-ID: <20220714185700.6137-1-pali@kernel.org> (raw)

Custom ARM version of pci_remap_iospace() is implemented only for MMU
kernel builds. So do not define pci_remap_iospace() without CONFIG_MMU.

See compilation failures:
https://lore.kernel.org/r/202112040150.wvyJZIZO-lkp@intel.com/
https://lore.kernel.org/r/202112261802.u9iXqdWh-lkp@intel.com/
https://lore.kernel.org/r/202201131529.A2s7rKQc-lkp@intel.com/
https://lore.kernel.org/r/202203090147.24cUL0De-lkp@intel.com/

Fixes: bc02973a06a6 ("arm: ioremap: Implement standard PCI function pci_remap_iospace()")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Pali Rohár <pali@kernel.org>

---

PING!!!! Is somebody interested in fixing these compile errors? As nobody
answered to my emails where I proposed this fix more than half year ago and
asked for opinion...

https://lore.kernel.org/r/20211204022131.bmhla4gkph7s7hy2@pali/
https://lore.kernel.org/r/20211205123209.lyx76daqdwzqwex4@pali/
https://lore.kernel.org/r/20211226215135.blcnafbuwhrq5ram@pali/
https://lore.kernel.org/r/20220113134938.3tx7iiukphvazvsq@pali/
https://lore.kernel.org/r/20220308184851.jmw2xvrapy5wzwof@pali/

If nobody is interested then please STOP sending me these Intel "0-DAY CI
Kernel Test Service" emails. Thanks!
---
 arch/arm/include/asm/io.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h
index eba7cbc93b86..47cf79229b7c 100644
--- a/arch/arm/include/asm/io.h
+++ b/arch/arm/include/asm/io.h
@@ -180,10 +180,12 @@ void pci_ioremap_set_mem_type(int mem_type);
 static inline void pci_ioremap_set_mem_type(int mem_type) {}
 #endif
 
+#ifdef CONFIG_MMU
 struct resource;
 
 #define pci_remap_iospace pci_remap_iospace
 int pci_remap_iospace(const struct resource *res, phys_addr_t phys_addr);
+#endif
 
 /*
  * PCI configuration space mapping function.
-- 
2.20.1


             reply	other threads:[~2022-07-14 18:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14 18:57 Pali Rohár [this message]
2022-07-14 18:57 ` [PATCH] arm: ioremap: Fix compilation of code which use pci_remap_iospace() without CONFIG_MMU Pali Rohár
2022-07-14 18:57 ` Pali Rohár
2022-07-14 19:48 ` Russell King (Oracle)
2022-07-14 19:48   ` Russell King (Oracle)
2022-07-14 19:48   ` Russell King
2022-07-15  8:02   ` Pali Rohár
2022-07-15  8:02     ` Pali Rohár
2022-07-15  8:02     ` Pali Rohár
2022-07-15 16:57     ` Russell King (Oracle)
2022-07-15 16:57       ` Russell King (Oracle)
2022-07-15 16:57       ` Russell King
2022-07-14 20:04 ` Bjorn Helgaas
2022-07-14 20:04   ` Bjorn Helgaas
2022-07-14 20:04   ` Bjorn Helgaas
2022-07-15  8:04   ` Pali Rohár
2022-07-15  8:04     ` Pali Rohár
2022-07-15  8:04     ` Pali Rohár
2022-07-15 16:39     ` Bjorn Helgaas
2022-07-15 16:39       ` Bjorn Helgaas
2022-07-15 16:39       ` Bjorn Helgaas
2022-07-14 20:19 ` Arnd Bergmann
2022-07-14 20:19   ` Arnd Bergmann
2022-07-14 20:19   ` Arnd Bergmann
2022-07-15  8:01   ` Pali Rohár
2022-07-15  8:01     ` Pali Rohár
2022-07-15  8:01     ` Pali Rohár
2022-07-15 16:48   ` Bjorn Helgaas
2022-07-15 16:48     ` Bjorn Helgaas
2022-07-15 16:48     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220714185700.6137-1-pali@kernel.org \
    --to=pali@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lkp@intel.com \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.