From: Rob Herring <robh@kernel.org>
To: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bin.zhang@mediatek.com,
benliang.zhao@mediatek.com, linux-mediatek@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH V4] dt-bindings: mediatek: Add axi clock in mt8173 dts example
Date: Mon, 18 Jul 2022 14:10:19 -0600 [thread overview]
Message-ID: <20220718201019.GA3461716-robh@kernel.org> (raw)
In-Reply-To: <20220712111106.31089-1-xiangsheng.hou@mediatek.com>
On Tue, Jul 12, 2022 at 07:11:07PM +0800, Xiangsheng Hou wrote:
> For mt8173, it is needed to add the axi clock for dma mode.
Needs to be sent to Mark Brown and linux-spi list. Use
get_maintainers.pl.
>
> Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> ---
> Changes from v3:
> - fix number of column characters
>
> Changes from v2:
> - remove assigned clocks and parents in dt-binding
>
> Changes from v1:
> - none
> ---
> .../devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
> index 41e60fe4b09f..d3d7ed4b497b 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
> @@ -82,8 +82,9 @@ examples:
> compatible = "mediatek,mt8173-nor";
> reg = <0 0x1100d000 0 0xe0>;
> interrupts = <1>;
> - clocks = <&pericfg CLK_PERI_SPI>, <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
> - clock-names = "spi", "sf";
> + clocks = <&pericfg CLK_PERI_SPI>, <&topckgen CLK_TOP_SPINFI_IFR_SEL>,
> + <&pericfg CLK_PERI_NFI>;
> + clock-names = "spi", "sf", "axi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> --
> 2.25.1
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, bin.zhang@mediatek.com,
benliang.zhao@mediatek.com, linux-mediatek@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH V4] dt-bindings: mediatek: Add axi clock in mt8173 dts example
Date: Mon, 18 Jul 2022 14:10:19 -0600 [thread overview]
Message-ID: <20220718201019.GA3461716-robh@kernel.org> (raw)
In-Reply-To: <20220712111106.31089-1-xiangsheng.hou@mediatek.com>
On Tue, Jul 12, 2022 at 07:11:07PM +0800, Xiangsheng Hou wrote:
> For mt8173, it is needed to add the axi clock for dma mode.
Needs to be sent to Mark Brown and linux-spi list. Use
get_maintainers.pl.
>
> Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> ---
> Changes from v3:
> - fix number of column characters
>
> Changes from v2:
> - remove assigned clocks and parents in dt-binding
>
> Changes from v1:
> - none
> ---
> .../devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
> index 41e60fe4b09f..d3d7ed4b497b 100644
> --- a/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
> +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-mtk-nor.yaml
> @@ -82,8 +82,9 @@ examples:
> compatible = "mediatek,mt8173-nor";
> reg = <0 0x1100d000 0 0xe0>;
> interrupts = <1>;
> - clocks = <&pericfg CLK_PERI_SPI>, <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
> - clock-names = "spi", "sf";
> + clocks = <&pericfg CLK_PERI_SPI>, <&topckgen CLK_TOP_SPINFI_IFR_SEL>,
> + <&pericfg CLK_PERI_NFI>;
> + clock-names = "spi", "sf", "axi";
> #address-cells = <1>;
> #size-cells = <0>;
>
> --
> 2.25.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-18 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 11:11 [PATCH V4] dt-bindings: mediatek: Add axi clock in mt8173 dts example Xiangsheng Hou
2022-07-12 11:11 ` Xiangsheng Hou
2022-07-18 20:10 ` Rob Herring [this message]
2022-07-18 20:10 ` Rob Herring
2022-07-18 20:10 ` Rob Herring
2022-07-18 20:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718201019.GA3461716-robh@kernel.org \
--to=robh@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benliang.zhao@mediatek.com \
--cc=bin.zhang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=xiangsheng.hou@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.