All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>,
	"Richard Zhu" <hongxing.zhu@nxp.com>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Rob Herring" <robh@kernel.org>, Wilczyński <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux-Next Mailing List" <linux-next@vger.kernel.org>
Subject: Re: build failure of next-20220718 due to 'imx6_pcie_host_exit' defined but not used
Date: Tue, 19 Jul 2022 16:47:31 -0500	[thread overview]
Message-ID: <20220719214731.GA1582549@bhelgaas> (raw)
In-Reply-To: <CAK8P3a0qcd6pZ=9fGapGexBMifp68jVezQou0QuK9As9vCyfyg@mail.gmail.com>

On Tue, Jul 19, 2022 at 11:16:40PM +0200, Arnd Bergmann wrote:
> On Tue, Jul 19, 2022 at 11:04 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > commit 0e4daeaa52ca ("PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS()")
> > Author: Bjorn Helgaas <bhelgaas@google.com>
> > Date:   Tue Jul 19 15:50:18 2022 -0500
> >
> >     PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS()
> >
> >     Replace SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() with NOIRQ_SYSTEM_SLEEP_PM_OPS(),
> >     which has the advantage that the compiler always sees the PM callbacks as
> >     referenced, so they don't need to be wrapped with "#ifdef CONFIG_PM_SLEEP"
> >     or tagged with "__maybe_unused" to avoid "defined but not used" warnings.
> >
> >     See 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones").
> >
> >     Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Thanks!  And sorry about being crabby earlier.  If this allows us to
get rid of those #ifdefs and __maybe_unused, it's a great improvement!

Bjorn

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Sudip Mukherjee (Codethink)" <sudipm.mukherjee@gmail.com>,
	"Richard Zhu" <hongxing.zhu@nxp.com>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Rob Herring" <robh@kernel.org>, Wilczyński <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Linux-Next Mailing List" <linux-next@vger.kernel.org>
Subject: Re: build failure of next-20220718 due to 'imx6_pcie_host_exit' defined but not used
Date: Tue, 19 Jul 2022 16:47:31 -0500	[thread overview]
Message-ID: <20220719214731.GA1582549@bhelgaas> (raw)
In-Reply-To: <CAK8P3a0qcd6pZ=9fGapGexBMifp68jVezQou0QuK9As9vCyfyg@mail.gmail.com>

On Tue, Jul 19, 2022 at 11:16:40PM +0200, Arnd Bergmann wrote:
> On Tue, Jul 19, 2022 at 11:04 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > commit 0e4daeaa52ca ("PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS()")
> > Author: Bjorn Helgaas <bhelgaas@google.com>
> > Date:   Tue Jul 19 15:50:18 2022 -0500
> >
> >     PCI: imx6: Convert to NOIRQ_SYSTEM_SLEEP_PM_OPS()
> >
> >     Replace SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() with NOIRQ_SYSTEM_SLEEP_PM_OPS(),
> >     which has the advantage that the compiler always sees the PM callbacks as
> >     referenced, so they don't need to be wrapped with "#ifdef CONFIG_PM_SLEEP"
> >     or tagged with "__maybe_unused" to avoid "defined but not used" warnings.
> >
> >     See 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones").
> >
> >     Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Thanks!  And sorry about being crabby earlier.  If this allows us to
get rid of those #ifdefs and __maybe_unused, it's a great improvement!

Bjorn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-19 21:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 11:58 build failure of next-20220718 due to 'imx6_pcie_host_exit' defined but not used Sudip Mukherjee (Codethink)
2022-07-18 11:58 ` Sudip Mukherjee (Codethink)
2022-07-18 12:42 ` Arnd Bergmann
2022-07-18 12:42   ` Arnd Bergmann
2022-07-18 16:14   ` Bjorn Helgaas
2022-07-18 16:14     ` Bjorn Helgaas
2022-07-19  7:52     ` Arnd Bergmann
2022-07-19  7:52       ` Arnd Bergmann
2022-07-19 21:04 ` Bjorn Helgaas
2022-07-19 21:04   ` Bjorn Helgaas
2022-07-19 21:16   ` Arnd Bergmann
2022-07-19 21:16     ` Arnd Bergmann
2022-07-19 21:47     ` Bjorn Helgaas [this message]
2022-07-19 21:47       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220719214731.GA1582549@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=festevam@gmail.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=kw@linux.com \
    --cc=l.stach@pengutronix.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.