From: Bjorn Helgaas <helgaas@kernel.org>
To: Jim Quinlan <jim2101024@gmail.com>
Cc: linux-pci@vger.kernel.org,
"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Cyril Brulebois" <kibi@debian.org>,
bcm-kernel-feedback-list@broadcom.com,
james.quinlan@broadcom.com,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/6] PCI: brcmstb: Add "refusal mode" to preclude PCIe-induced CPU aborts
Date: Wed, 20 Jul 2022 17:08:40 -0500 [thread overview]
Message-ID: <20220720220840.GA1663326@bhelgaas> (raw)
In-Reply-To: <20220716222454.29914-4-jim2101024@gmail.com>
On Sat, Jul 16, 2022 at 06:24:50PM -0400, Jim Quinlan wrote:
> Our PCIe RC HW has an atypical behavior: if it does not have PCIe link
> established between itself and downstream, any subsequent config space
> access causes a CPU abort. This commit sets a "refusal mode" if the PCIe
> link-up fails, and this has our pci_ops map_bus function returning a NULL
> address, which in turn precludes the access from happening.
> @@ -687,6 +688,19 @@ static void __iomem *brcm_pcie_map_conf(struct pci_bus *bus, unsigned int devfn,
Oh, and I forgot to mention that brcmstb is one of the few drivers
that doesn't name these functions ".*_map_bus()". It's helpful when
they all match a simple grep pattern. Maybe a patch at the end could
fix this.
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Jim Quinlan <jim2101024@gmail.com>
Cc: linux-pci@vger.kernel.org,
"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Cyril Brulebois" <kibi@debian.org>,
bcm-kernel-feedback-list@broadcom.com,
james.quinlan@broadcom.com,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/6] PCI: brcmstb: Add "refusal mode" to preclude PCIe-induced CPU aborts
Date: Wed, 20 Jul 2022 17:08:40 -0500 [thread overview]
Message-ID: <20220720220840.GA1663326@bhelgaas> (raw)
In-Reply-To: <20220716222454.29914-4-jim2101024@gmail.com>
On Sat, Jul 16, 2022 at 06:24:50PM -0400, Jim Quinlan wrote:
> Our PCIe RC HW has an atypical behavior: if it does not have PCIe link
> established between itself and downstream, any subsequent config space
> access causes a CPU abort. This commit sets a "refusal mode" if the PCIe
> link-up fails, and this has our pci_ops map_bus function returning a NULL
> address, which in turn precludes the access from happening.
> @@ -687,6 +688,19 @@ static void __iomem *brcm_pcie_map_conf(struct pci_bus *bus, unsigned int devfn,
Oh, and I forgot to mention that brcmstb is one of the few drivers
that doesn't name these functions ".*_map_bus()". It's helpful when
they all match a simple grep pattern. Maybe a patch at the end could
fix this.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-20 22:08 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 22:24 [PATCH v2 0/6] PCI: brcmstb: Re-submit reverted patchset Jim Quinlan
2022-07-16 22:24 ` Jim Quinlan
2022-07-16 22:24 ` [PATCH v2 1/6] PCI: brcmstb: Remove unnecessary forward declarations Jim Quinlan
2022-07-16 22:24 ` Jim Quinlan
2022-07-16 22:24 ` [PATCH v2 2/6] PCI: brcmstb: Split brcm_pcie_setup() into two funcs Jim Quinlan
2022-07-16 22:24 ` Jim Quinlan
2022-07-18 13:11 ` Pali Rohár
2022-07-18 13:11 ` Pali Rohár
2022-07-18 13:37 ` Jim Quinlan
2022-07-18 13:37 ` Jim Quinlan
2022-07-18 17:05 ` Bjorn Helgaas
2022-07-18 17:05 ` Bjorn Helgaas
2022-07-18 18:01 ` Pali Rohár
2022-07-18 18:01 ` Pali Rohár
2022-07-18 18:14 ` Bjorn Helgaas
2022-07-18 18:14 ` Bjorn Helgaas
2022-07-18 18:56 ` Jim Quinlan
2022-07-18 18:56 ` Jim Quinlan
2022-07-18 19:23 ` Bjorn Helgaas
2022-07-18 19:23 ` Bjorn Helgaas
2022-07-18 22:40 ` Bjorn Helgaas
2022-07-18 22:40 ` Bjorn Helgaas
2022-07-19 13:08 ` Jim Quinlan
2022-07-19 13:08 ` Jim Quinlan
2022-07-19 20:03 ` Bjorn Helgaas
2022-07-19 20:03 ` Bjorn Helgaas
2022-07-20 14:53 ` Jim Quinlan
2022-07-20 14:53 ` Jim Quinlan
2022-07-20 16:18 ` Rob Herring
2022-07-20 16:18 ` Rob Herring
2022-07-20 21:34 ` Florian Fainelli
2022-07-20 21:34 ` Florian Fainelli
2022-07-21 14:27 ` Rob Herring
2022-07-21 14:27 ` Rob Herring
2022-07-18 22:40 ` Bjorn Helgaas
2022-07-18 22:40 ` Bjorn Helgaas
2022-07-20 20:37 ` Bjorn Helgaas
2022-07-20 20:37 ` Bjorn Helgaas
2022-07-21 14:56 ` Jim Quinlan
2022-07-21 14:56 ` Jim Quinlan
2022-07-21 16:10 ` Bjorn Helgaas
2022-07-21 16:10 ` Bjorn Helgaas
2022-07-16 22:24 ` [PATCH v2 3/6] PCI: brcmstb: Add "refusal mode" to preclude PCIe-induced CPU aborts Jim Quinlan
2022-07-16 22:24 ` Jim Quinlan
2022-07-20 22:05 ` Bjorn Helgaas
2022-07-20 22:05 ` Bjorn Helgaas
2022-07-21 14:53 ` Jim Quinlan
2022-07-21 14:53 ` Jim Quinlan
2022-07-21 15:46 ` Bjorn Helgaas
2022-07-21 15:46 ` Bjorn Helgaas
2022-07-20 22:08 ` Bjorn Helgaas [this message]
2022-07-20 22:08 ` Bjorn Helgaas
2022-07-16 22:24 ` [PATCH v2 4/6] PCI: brcmstb: Add mechanism to turn on subdev regulators Jim Quinlan
2022-07-16 22:24 ` Jim Quinlan
2022-07-16 22:24 ` [PATCH v2 5/6] PCI: brcmstb: Add control of subdevice voltage regulators Jim Quinlan
2022-07-16 22:24 ` Jim Quinlan
2022-07-17 12:39 ` kernel test robot
2022-07-16 22:24 ` [PATCH v2 6/6] PCI: brcmstb: Do not turn off WOL regulators on suspend Jim Quinlan
2022-07-16 22:24 ` Jim Quinlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720220840.GA1663326@bhelgaas \
--to=helgaas@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=jim2101024@gmail.com \
--cc=kibi@debian.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lpieralisi@kernel.org \
--cc=nsaenz@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.