Re: [PATCH v1 03/14] regulator: dt-bindings: Add interrupts support to TPS65219 PMIC bindings

From: Rob Herring <robh@kernel.org>
To: Jerome Neanne <jneanne@baylibre.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, nm@ti.com,
	kristo@kernel.org, khilman@baylibre.com, narmstrong@baylibre.com,
	msp@baylibre.com, j-keerthy@ti.c, lee.jones@linaro.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 03/14] regulator: dt-bindings: Add interrupts support to TPS65219 PMIC bindings
Date: Wed, 20 Jul 2022 17:37:25 -0600	[thread overview]
Message-ID: <20220720233725.GA4187584-robh@kernel.org> (raw)
In-Reply-To: <20220719091742.3221-4-jneanne@baylibre.com>

On Tue, Jul 19, 2022 at 11:17:31AM +0200, Jerome Neanne wrote:
> Add interrupt properties in PMIC TPS65219 bindings

Why is this a separate patch? Please make your binding complete. Where 
do these interrupts go to?

> 
> Signed-off-by: Jerome Neanne <jneanne@baylibre.com>
> ---
>  .../bindings/regulator/ti,tps65219.yaml       | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
> index 2c655432b889..6a60e62a313c 100644
> --- a/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
> @@ -25,6 +25,17 @@ properties:
>      description: Optional property that indicates that this device is
>        controlling system power.
>  
> +  interrupts:
> +    description: Short-circuit, over-current, under-voltage for regulators, PB interrupts.
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    description: Specifies the PIN numbers and Flags, as defined in
> +      include/dt-bindings/interrupt-controller/irq.h
> +    const: 1
> +
>  patternProperties:
>    "^buck[1-3]-supply$":
>      description: Input supply phandle of one regulator.
> @@ -71,12 +82,16 @@ patternProperties:
>  required:
>    - compatible
>    - reg
> +  - interrupts
> +  - interrupt-controller
> +  - '#interrupt-cells'
>    - regulators
>  
>  additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>      i2c {
>          #address-cells = <1>;
>          #size-cells = <0>;
> @@ -92,6 +107,13 @@ examples:
>              ldo3-supply = <&vcc_3v3_sys>;
>              ldo4-supply = <&vcc_3v3_sys>;
>  
> +            pinctrl-0 = <&pmic_irq_pins_default>;
> +
> +            interrupt-parent = <&gic500>;
> +            interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
> +            interrupt-controller;
> +            #interrupt-cells = <1>;
> +
>              regulators {
>                  buck1_reg: buck1 {
>                      regulator-name = "VDD_CORE";
> -- 
> 2.17.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel