From: Christoph Hellwig <hch@lst.de>
To: Robert Beckett <bob.beckett@collabora.com>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Thomas Hellstrom <thomas.hellstrom@intel.com>,
Matthew Auld <matthew.auld@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
kernel@collabora.com, Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: stop using swiotlb
Date: Fri, 22 Jul 2022 11:57:24 +0200 [thread overview]
Message-ID: <20220722095724.GA14113@lst.de> (raw)
In-Reply-To: <20220721174307.1085741-1-bob.beckett@collabora.com>
On Thu, Jul 21, 2022 at 06:43:07PM +0100, Robert Beckett wrote:
> + max_segment = dma_max_mapping_size(i915->drm.dev);
> + max_segment = max_t(size_t, max_segment, PAGE_SIZE) >> PAGE_SHIFT;
dma_max_mapping_size is always larger than PAGE_SIZE, so I don't think
the max is needed.
Otherwise this loks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Robert Beckett <bob.beckett@collabora.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
kernel@collabora.com, Christoph Hellwig <hch@lst.de>,
Thomas Hellstrom <thomas.hellstrom@intel.com>,
Matthew Auld <matthew.auld@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/i915: stop using swiotlb
Date: Fri, 22 Jul 2022 11:57:24 +0200 [thread overview]
Message-ID: <20220722095724.GA14113@lst.de> (raw)
In-Reply-To: <20220721174307.1085741-1-bob.beckett@collabora.com>
On Thu, Jul 21, 2022 at 06:43:07PM +0100, Robert Beckett wrote:
> + max_segment = dma_max_mapping_size(i915->drm.dev);
> + max_segment = max_t(size_t, max_segment, PAGE_SIZE) >> PAGE_SHIFT;
dma_max_mapping_size is always larger than PAGE_SIZE, so I don't think
the max is needed.
Otherwise this loks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-07-22 9:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 17:43 [Intel-gfx] [PATCH] drm/i915: stop using swiotlb Robert Beckett
2022-07-21 17:43 ` Robert Beckett
2022-07-21 17:43 ` Robert Beckett
2022-07-21 18:11 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2022-07-21 18:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-22 3:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-22 9:13 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2022-07-22 9:13 ` Tvrtko Ursulin
2022-07-22 9:13 ` Tvrtko Ursulin
2022-07-22 10:00 ` [Intel-gfx] " Christoph Hellwig
2022-07-22 10:00 ` Christoph Hellwig
2022-07-22 9:45 ` [Intel-gfx] " Tvrtko Ursulin
2022-07-22 9:45 ` Tvrtko Ursulin
2022-07-22 9:45 ` Tvrtko Ursulin
2022-07-22 9:58 ` [Intel-gfx] " Christoph Hellwig
2022-07-22 9:58 ` Christoph Hellwig
2022-07-22 10:13 ` [Intel-gfx] " Tvrtko Ursulin
2022-07-22 10:13 ` Tvrtko Ursulin
2022-07-22 10:13 ` Tvrtko Ursulin
2022-07-22 9:57 ` Christoph Hellwig [this message]
2022-07-22 9:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722095724.GA14113@lst.de \
--to=hch@lst.de \
--cc=airlied@linux.ie \
--cc=bob.beckett@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.