All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Lingshan <lingshan.zhu@intel.com>
To: jasowang@redhat.com, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, parav@nvidia.com,
	xieyongji@bytedance.com, gautam.dawar@amd.com,
	Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH V4 4/6] vDPA: !FEATURES_OK should not block querying device config space
Date: Fri, 22 Jul 2022 19:53:07 +0800	[thread overview]
Message-ID: <20220722115309.82746-5-lingshan.zhu@intel.com> (raw)
In-Reply-To: <20220722115309.82746-1-lingshan.zhu@intel.com>

Users may want to query the config space of a vDPA device,
to choose a appropriate one for a certain guest. This means the
users need to read the config space before FEATURES_OK, and
the existence of config space contents does not depend on
FEATURES_OK.

The spec says:
The device MUST allow reading of any device-specific configuration
field before FEATURES_OK is set by the driver. This includes
fields which are conditional on feature bits, as long as those
feature bits are offered by the device.

Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
---
 drivers/vdpa/vdpa.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index 9b0e39b2f022..d76b22b2f7ae 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -851,17 +851,9 @@ vdpa_dev_config_fill(struct vdpa_device *vdev, struct sk_buff *msg, u32 portid,
 {
 	u32 device_id;
 	void *hdr;
-	u8 status;
 	int err;
 
 	down_read(&vdev->cf_lock);
-	status = vdev->config->get_status(vdev);
-	if (!(status & VIRTIO_CONFIG_S_FEATURES_OK)) {
-		NL_SET_ERR_MSG_MOD(extack, "Features negotiation not completed");
-		err = -EAGAIN;
-		goto out;
-	}
-
 	hdr = genlmsg_put(msg, portid, seq, &vdpa_nl_family, flags,
 			  VDPA_CMD_DEV_CONFIG_GET);
 	if (!hdr) {
-- 
2.31.1


  parent reply	other threads:[~2022-07-22 12:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-22 11:53 [PATCH V4 0/6] ifcvf/vDPA: support query device config space through netlink Zhu Lingshan
2022-07-22 11:53 ` [PATCH V4 1/6] vDPA/ifcvf: get_config_size should return a value no greater than dev implementation Zhu Lingshan
2022-07-22 11:53 ` [PATCH V4 2/6] vDPA/ifcvf: support userspace to query features and MQ of a management device Zhu Lingshan
2022-07-22 11:53 ` [PATCH V4 3/6] vDPA: allow userspace to query features of a vDPA device Zhu Lingshan
2022-07-22 13:12   ` Parav Pandit via Virtualization
2022-07-22 13:12     ` Parav Pandit
2022-07-23 11:23     ` Zhu, Lingshan
2022-07-24 15:21       ` Parav Pandit via Virtualization
2022-07-24 15:21         ` Parav Pandit
2022-07-26 11:02         ` Zhu, Lingshan
2022-07-26 11:06           ` Parav Pandit via Virtualization
2022-07-26 11:06             ` Parav Pandit
2022-07-26 11:15             ` Zhu Lingshan
2022-07-27  6:02             ` Zhu, Lingshan
2022-08-09 19:27               ` Parav Pandit via Virtualization
2022-08-09 19:27                 ` Parav Pandit
2022-08-09 19:24   ` Michael S. Tsirkin
2022-08-09 19:24     ` Michael S. Tsirkin
2022-08-09 19:28     ` Parav Pandit via Virtualization
2022-08-09 19:28       ` Parav Pandit
2022-08-10  2:51     ` Zhu, Lingshan
2022-07-22 11:53 ` Zhu Lingshan [this message]
2022-07-22 11:53 ` [PATCH V4 5/6] vDPA: answer num of queue pairs = 1 to userspace when VIRTIO_NET_F_MQ == 0 Zhu Lingshan
2022-07-22 13:14   ` Parav Pandit via Virtualization
2022-07-22 13:14     ` Parav Pandit
2022-07-23 11:24     ` Zhu, Lingshan
2022-08-09 19:36     ` Michael S. Tsirkin
2022-08-09 19:36       ` Michael S. Tsirkin
2022-08-09 19:48       ` Parav Pandit via Virtualization
2022-08-09 19:48         ` Parav Pandit
2022-08-10  0:54       ` Si-Wei Liu
2022-08-10  0:54         ` Si-Wei Liu
2022-08-10  1:09         ` Jason Wang
2022-08-10  1:09           ` Jason Wang
2022-08-11  0:58           ` Si-Wei Liu
2022-08-11  0:58             ` Si-Wei Liu
2022-08-10  2:40       ` Zhu, Lingshan
2022-07-22 11:53 ` [PATCH V4 6/6] vDPA: fix 'cast to restricted le16' warnings in vdpa.c Zhu Lingshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220722115309.82746-5-lingshan.zhu@intel.com \
    --to=lingshan.zhu@intel.com \
    --cc=gautam.dawar@amd.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.