From: Zhu Lingshan <lingshan.zhu@intel.com>
To: jasowang@redhat.com, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, parav@nvidia.com,
xieyongji@bytedance.com, gautam.dawar@amd.com,
Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH V4 5/6] vDPA: answer num of queue pairs = 1 to userspace when VIRTIO_NET_F_MQ == 0
Date: Fri, 22 Jul 2022 19:53:08 +0800 [thread overview]
Message-ID: <20220722115309.82746-6-lingshan.zhu@intel.com> (raw)
In-Reply-To: <20220722115309.82746-1-lingshan.zhu@intel.com>
If VIRTIO_NET_F_MQ == 0, the virtio device should have one queue pair,
so when userspace querying queue pair numbers, it should return mq=1
than zero.
Function vdpa_dev_net_config_fill() fills the attributions of the
vDPA devices, so that it should call vdpa_dev_net_mq_config_fill()
so the parameter in vdpa_dev_net_mq_config_fill()
should be feature_device than feature_driver for the
vDPA devices themselves
Before this change, when MQ = 0, iproute2 output:
$vdpa dev config show vdpa0
vdpa0: mac 00:e8:ca:11:be:05 link up link_announce false
max_vq_pairs 0 mtu 1500
After applying this commit, when MQ = 0, iproute2 output:
$vdpa dev config show vdpa0
vdpa0: mac 00:e8:ca:11:be:05 link up link_announce false
max_vq_pairs 1 mtu 1500
Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
---
drivers/vdpa/vdpa.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index d76b22b2f7ae..846dd37f3549 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -806,9 +806,10 @@ static int vdpa_dev_net_mq_config_fill(struct vdpa_device *vdev,
u16 val_u16;
if ((features & BIT_ULL(VIRTIO_NET_F_MQ)) == 0)
- return 0;
+ val_u16 = 1;
+ else
+ val_u16 = __virtio16_to_cpu(true, config->max_virtqueue_pairs);
- val_u16 = le16_to_cpu(config->max_virtqueue_pairs);
return nla_put_u16(msg, VDPA_ATTR_DEV_NET_CFG_MAX_VQP, val_u16);
}
@@ -842,7 +843,7 @@ static int vdpa_dev_net_config_fill(struct vdpa_device *vdev, struct sk_buff *ms
VDPA_ATTR_PAD))
return -EMSGSIZE;
- return vdpa_dev_net_mq_config_fill(vdev, msg, features_driver, &config);
+ return vdpa_dev_net_mq_config_fill(vdev, msg, features_device, &config);
}
static int
--
2.31.1
next prev parent reply other threads:[~2022-07-22 12:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 11:53 [PATCH V4 0/6] ifcvf/vDPA: support query device config space through netlink Zhu Lingshan
2022-07-22 11:53 ` [PATCH V4 1/6] vDPA/ifcvf: get_config_size should return a value no greater than dev implementation Zhu Lingshan
2022-07-22 11:53 ` [PATCH V4 2/6] vDPA/ifcvf: support userspace to query features and MQ of a management device Zhu Lingshan
2022-07-22 11:53 ` [PATCH V4 3/6] vDPA: allow userspace to query features of a vDPA device Zhu Lingshan
2022-07-22 13:12 ` Parav Pandit via Virtualization
2022-07-22 13:12 ` Parav Pandit
2022-07-23 11:23 ` Zhu, Lingshan
2022-07-24 15:21 ` Parav Pandit via Virtualization
2022-07-24 15:21 ` Parav Pandit
2022-07-26 11:02 ` Zhu, Lingshan
2022-07-26 11:06 ` Parav Pandit via Virtualization
2022-07-26 11:06 ` Parav Pandit
2022-07-26 11:15 ` Zhu Lingshan
2022-07-27 6:02 ` Zhu, Lingshan
2022-08-09 19:27 ` Parav Pandit via Virtualization
2022-08-09 19:27 ` Parav Pandit
2022-08-09 19:24 ` Michael S. Tsirkin
2022-08-09 19:24 ` Michael S. Tsirkin
2022-08-09 19:28 ` Parav Pandit via Virtualization
2022-08-09 19:28 ` Parav Pandit
2022-08-10 2:51 ` Zhu, Lingshan
2022-07-22 11:53 ` [PATCH V4 4/6] vDPA: !FEATURES_OK should not block querying device config space Zhu Lingshan
2022-07-22 11:53 ` Zhu Lingshan [this message]
2022-07-22 13:14 ` [PATCH V4 5/6] vDPA: answer num of queue pairs = 1 to userspace when VIRTIO_NET_F_MQ == 0 Parav Pandit via Virtualization
2022-07-22 13:14 ` Parav Pandit
2022-07-23 11:24 ` Zhu, Lingshan
2022-08-09 19:36 ` Michael S. Tsirkin
2022-08-09 19:36 ` Michael S. Tsirkin
2022-08-09 19:48 ` Parav Pandit via Virtualization
2022-08-09 19:48 ` Parav Pandit
2022-08-10 0:54 ` Si-Wei Liu
2022-08-10 0:54 ` Si-Wei Liu
2022-08-10 1:09 ` Jason Wang
2022-08-10 1:09 ` Jason Wang
2022-08-11 0:58 ` Si-Wei Liu
2022-08-11 0:58 ` Si-Wei Liu
2022-08-10 2:40 ` Zhu, Lingshan
2022-07-22 11:53 ` [PATCH V4 6/6] vDPA: fix 'cast to restricted le16' warnings in vdpa.c Zhu Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220722115309.82746-6-lingshan.zhu@intel.com \
--to=lingshan.zhu@intel.com \
--cc=gautam.dawar@amd.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.