[Buildroot] [PATCH V2] Version 2.3.4 of libtalloc needs to define PYTHONHASHSEED, as a check has been added to the configure script, and build will fail if it is not defined.

[Buildroot] [PATCH V2] Version 2.3.4 of libtalloc needs to define PYTHONHASHSEED, as a check has been added to the configure script, and build will fail if it is not defined.

[David GOUARIN]

From: David GOUARIN <david.gouarin@thalesgroup.com>

This is originately a workaround by samba developpers meant to avoid rebuilding talloc
with each call to make. Defining PYTHONHASHSEED would not be required in the context
of builroot, if not for the check in the configure script.

This change required an upgrade to pkg_waf.mk.

Signed-off-by: David GOUARIN <david.gouarin@thalesgroup.com>

---
Changes v1 -> v2:
  - edit commit message (suggested by Yann E. MORIN)
Signed-off-by: David GOUARIN <david.gouarin@thalesgroup.com>
---
 package/libtalloc/libtalloc.hash | 2 +-
 package/libtalloc/libtalloc.mk   | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/package/libtalloc/libtalloc.hash b/package/libtalloc/libtalloc.hash
index cbfd11e63b..0bc8edb695 100644
--- a/package/libtalloc/libtalloc.hash
+++ b/package/libtalloc/libtalloc.hash
@@ -1,3 +1,3 @@
 # Locally calculated
-sha256  6be95b2368bd0af1c4cd7a88146eb6ceea18e46c3ffc9330bf6262b40d1d8aaa  talloc-2.3.3.tar.gz
+sha256  179f9ebe265e67e4ab2c26cad2b7de4b6a77c6c212f966903382869f06be6505  talloc-2.3.4.tar.gz
 sha256  f8340c449dd64a55c6605b02fcad2aec6f473612ac6026739a22995380a8043c  talloc.h
diff --git a/package/libtalloc/libtalloc.mk b/package/libtalloc/libtalloc.mk
index 8cba699ea1..d12f4fcfff 100644
--- a/package/libtalloc/libtalloc.mk
+++ b/package/libtalloc/libtalloc.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBTALLOC_VERSION = 2.3.3
+LIBTALLOC_VERSION = 2.3.4
 LIBTALLOC_SOURCE = talloc-$(LIBTALLOC_VERSION).tar.gz
 LIBTALLOC_SITE = https://www.samba.org/ftp/talloc
 LIBTALLOC_LICENSE = LGPL-3.0+
@@ -40,6 +40,9 @@ else
 LIBTALLOC_CONF_OPTS += --disable-python
 endif
 
+#LIBTALLOC_CONF_ENV += PYTHONHASHSEED=1
+#LIBTALLOC_MAKE_ENV += PYTHONHASHSEED=1
+
 LIBTALLOC_WAF = ./buildtools/bin/waf
 
 # like samba4, libtalloc uses the waf build system which requires a
-- 
2.17.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH V2] Version 2.3.4 of libtalloc needs to define PYTHONHASHSEED, as a check has been added to the configure script, and build will fail if it is not defined.

[Romain Naour]

Hello David,

Le 24/07/2022 à 15:18, David GOUARIN a écrit :
> From: David GOUARIN <david.gouarin@thalesgroup.com>

The commit title is a bit long, usually we want something like:

package/libtallc: bump version to 2.3.4

> 
> This is originately a workaround by samba developpers meant to avoid rebuilding talloc
> with each call to make. Defining PYTHONHASHSEED would not be required in the context
> of builroot, if not for the check in the configure script.
> 
> This change required an upgrade to pkg_waf.mk.

The waf infra has been updated now. Maybe this technical detail would go bellow
"---" line.

> 
> Signed-off-by: David GOUARIN <david.gouarin@thalesgroup.com>
> 
> ---
> Changes v1 -> v2:
>   - edit commit message (suggested by Yann E. MORIN)
> Signed-off-by: David GOUARIN <david.gouarin@thalesgroup.com>
> ---
>  package/libtalloc/libtalloc.hash | 2 +-
>  package/libtalloc/libtalloc.mk   | 5 ++++-
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libtalloc/libtalloc.hash b/package/libtalloc/libtalloc.hash
> index cbfd11e63b..0bc8edb695 100644
> --- a/package/libtalloc/libtalloc.hash
> +++ b/package/libtalloc/libtalloc.hash
> @@ -1,3 +1,3 @@
>  # Locally calculated
> -sha256  6be95b2368bd0af1c4cd7a88146eb6ceea18e46c3ffc9330bf6262b40d1d8aaa  talloc-2.3.3.tar.gz
> +sha256  179f9ebe265e67e4ab2c26cad2b7de4b6a77c6c212f966903382869f06be6505  talloc-2.3.4.tar.gz
>  sha256  f8340c449dd64a55c6605b02fcad2aec6f473612ac6026739a22995380a8043c  talloc.h
> diff --git a/package/libtalloc/libtalloc.mk b/package/libtalloc/libtalloc.mk
> index 8cba699ea1..d12f4fcfff 100644
> --- a/package/libtalloc/libtalloc.mk
> +++ b/package/libtalloc/libtalloc.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -LIBTALLOC_VERSION = 2.3.3
> +LIBTALLOC_VERSION = 2.3.4
>  LIBTALLOC_SOURCE = talloc-$(LIBTALLOC_VERSION).tar.gz
>  LIBTALLOC_SITE = https://www.samba.org/ftp/talloc
>  LIBTALLOC_LICENSE = LGPL-3.0+
> @@ -40,6 +40,9 @@ else
>  LIBTALLOC_CONF_OPTS += --disable-python
>  endif
>  
> +#LIBTALLOC_CONF_ENV += PYTHONHASHSEED=1
> +#LIBTALLOC_MAKE_ENV += PYTHONHASHSEED=1

humm, theses lines are actually commented.

Best regards,
Romain


> +
>  LIBTALLOC_WAF = ./buildtools/bin/waf
>  
>  # like samba4, libtalloc uses the waf build system which requires a

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot