From: Segher Boessenkool <segher@kernel.crashing.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/purgatory: Omit use of bin2c
Date: Sun, 24 Jul 2022 20:41:01 -0500 [thread overview]
Message-ID: <20220725014100.GQ25951@gate.crashing.org> (raw)
In-Reply-To: <20220625224037.836581-1-masahiroy@kernel.org>
On Sun, Jun 26, 2022 at 07:40:37AM +0900, Masahiro Yamada wrote:
> The .incbin assembler directive is much faster than bin2c + $(CC).
And perhaps more importantly it is simpler and less clumsy.
> --- /dev/null
> +++ b/arch/powerpc/purgatory/kexec-purgatory.S
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> + .section .rodata, "a"
> +
> + .align 8
> +kexec_purgatory:
> + .globl kexec_purgatory
> + .incbin "arch/powerpc/purgatory/purgatory.ro"
> +.Lkexec_purgatroy_end:
Typo here (s/ro/or/)
> +
> + .align 8
> +kexec_purgatory_size:
> + .globl kexec_purgatory_size
> + .quad .Lkexec_purgatroy_end - kexec_purgatory
And here again ofc.
Looks good to me otherwise, nice cleanup :-)
Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/purgatory: Omit use of bin2c
Date: Sun, 24 Jul 2022 20:41:01 -0500 [thread overview]
Message-ID: <20220725014100.GQ25951@gate.crashing.org> (raw)
In-Reply-To: <20220625224037.836581-1-masahiroy@kernel.org>
On Sun, Jun 26, 2022 at 07:40:37AM +0900, Masahiro Yamada wrote:
> The .incbin assembler directive is much faster than bin2c + $(CC).
And perhaps more importantly it is simpler and less clumsy.
> --- /dev/null
> +++ b/arch/powerpc/purgatory/kexec-purgatory.S
> @@ -0,0 +1,14 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> + .section .rodata, "a"
> +
> + .align 8
> +kexec_purgatory:
> + .globl kexec_purgatory
> + .incbin "arch/powerpc/purgatory/purgatory.ro"
> +.Lkexec_purgatroy_end:
Typo here (s/ro/or/)
> +
> + .align 8
> +kexec_purgatory_size:
> + .globl kexec_purgatory_size
> + .quad .Lkexec_purgatroy_end - kexec_purgatory
And here again ofc.
Looks good to me otherwise, nice cleanup :-)
Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org>
Segher
next prev parent reply other threads:[~2022-07-25 1:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 22:40 [PATCH] powerpc/purgatory: Omit use of bin2c Masahiro Yamada
2022-07-24 15:12 ` Masahiro Yamada
2022-07-25 1:41 ` Segher Boessenkool [this message]
2022-07-25 1:41 ` Segher Boessenkool
2022-07-25 1:58 ` Masahiro Yamada
2022-07-25 1:58 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725014100.GQ25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.