All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, aisheng.dong@nxp.com, festevam@gmail.com,
	ping.bai@nxp.com, kernel@pengutronix.de, linux-imx@nxp.com,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 0/9] dt-bindings: pinctrl: imx: use minItems
Date: Mon, 25 Jul 2022 14:07:40 -0600	[thread overview]
Message-ID: <20220725200740.GA2610621-robh@kernel.org> (raw)
In-Reply-To: <20220723094335.3577048-1-peng.fan@oss.nxp.com>

On Sat, Jul 23, 2022 at 05:43:26PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> There are many warnings when do dtbs_check: fsl,pins are too long,
> so add minItems to address that.

A single cell is not valid though, right?

This particular property is problematic because each entry depending 
on the platform has different number of cells (5, 6, etc.). A single 
cell (minItems: 1) is not valid though, right?

There's a fix in dtschema min branch which should fix the warnings. 
Unfortunately, it just strips any bounds checking.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, aisheng.dong@nxp.com, festevam@gmail.com,
	ping.bai@nxp.com, kernel@pengutronix.de, linux-imx@nxp.com,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 0/9] dt-bindings: pinctrl: imx: use minItems
Date: Mon, 25 Jul 2022 14:07:40 -0600	[thread overview]
Message-ID: <20220725200740.GA2610621-robh@kernel.org> (raw)
In-Reply-To: <20220723094335.3577048-1-peng.fan@oss.nxp.com>

On Sat, Jul 23, 2022 at 05:43:26PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> There are many warnings when do dtbs_check: fsl,pins are too long,
> so add minItems to address that.

A single cell is not valid though, right?

This particular property is problematic because each entry depending 
on the platform has different number of cells (5, 6, etc.). A single 
cell (minItems: 1) is not valid though, right?

There's a fix in dtschema min branch which should fix the warnings. 
Unfortunately, it just strips any bounds checking.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-07-25 20:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-23  9:43 [PATCH 0/9] dt-bindings: pinctrl: imx: use minItems Peng Fan (OSS)
2022-07-23  9:43 ` Peng Fan (OSS)
2022-07-23  9:43 ` [PATCH 1/9] dt-bindings: pinctrl: imx8mm: use minItems for fsl,pins Peng Fan (OSS)
2022-07-23  9:43   ` Peng Fan (OSS)
2022-07-23  9:43 ` [PATCH 2/9] dt-bindings: pinctrl: imx8mn: " Peng Fan (OSS)
2022-07-23  9:43   ` Peng Fan (OSS)
2022-07-23  9:43 ` [PATCH 3/9] dt-bindings: pinctrl: imx8mq: " Peng Fan (OSS)
2022-07-23  9:43   ` Peng Fan (OSS)
2022-07-23  9:43 ` [PATCH 4/9] dt-bindings: pinctrl: imx8mp: " Peng Fan (OSS)
2022-07-23  9:43   ` Peng Fan (OSS)
2022-07-23  9:43 ` [PATCH 5/9] dt-bindings: pinctrl: imx8ulp: " Peng Fan (OSS)
2022-07-23  9:43   ` Peng Fan (OSS)
2022-07-23  9:43 ` [PATCH 6/9] dt-bindings: pinctrl: imx93: " Peng Fan (OSS)
2022-07-23  9:43   ` Peng Fan (OSS)
2022-07-23  9:43 ` [PATCH 7/9] dt-bindings: pinctrl: imx: scu: " Peng Fan (OSS)
2022-07-23  9:43   ` Peng Fan (OSS)
2022-07-23  9:43 ` [PATCH 8/9] dt-bindings: pinctrl: imx: scu: correct example Peng Fan (OSS)
2022-07-23  9:43   ` Peng Fan (OSS)
2022-07-25 23:22   ` Rob Herring
2022-07-25 23:22     ` Rob Herring
2022-07-23  9:43 ` [PATCH 9/9] dt-bindings: pinctrl: imx7d: use minItems for fsl,pins Peng Fan (OSS)
2022-07-23  9:43   ` Peng Fan (OSS)
2022-07-25 20:07 ` Rob Herring [this message]
2022-07-25 20:07   ` [PATCH 0/9] dt-bindings: pinctrl: imx: use minItems Rob Herring
2022-07-26  9:03   ` Peng Fan
2022-07-26  9:03     ` Peng Fan
2022-07-26  9:11   ` Peng Fan
2022-07-26  9:11     ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220725200740.GA2610621-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=ping.bai@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.