From: Rob Herring <robh@kernel.org>
To: Raphael-Xu <13691752556@139.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
shenghao-ding@ti.com, kevin-lu@ti.com, broonie@kernel.org,
raphael-xu@ti.com
Subject: Re: [PATCH v7] ASoc: dt-bindings: tas2780: remove tas2780 and will merge it to tas27xx
Date: Mon, 25 Jul 2022 16:49:19 -0600 [thread overview]
Message-ID: <20220725224919.GA2887013-robh@kernel.org> (raw)
In-Reply-To: <20220722105345.175-1-13691752556@139.com>
On Fri, Jul 22, 2022 at 06:53:45PM +0800, Raphael-Xu wrote:
> remove tas2780
Your commit message needs to answer 'why'? Write complete sentences.
Though as this was just added, you should do 'git revert' and send that
patch.
And this is not v7.
> Signed-off-by: Raphael-Xu <13691752556@139.com>
> ---
> .../devicetree/bindings/sound/tas2780.yaml | 75 -------------------
> 1 file changed, 75 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/tas2780.yaml
However, Mark took the original patch with the same issues, so:
Acked-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Raphael-Xu <13691752556@139.com>
Cc: alsa-devel@alsa-project.org, raphael-xu@ti.com,
shenghao-ding@ti.com, broonie@kernel.org,
devicetree@vger.kernel.org, kevin-lu@ti.com
Subject: Re: [PATCH v7] ASoc: dt-bindings: tas2780: remove tas2780 and will merge it to tas27xx
Date: Mon, 25 Jul 2022 16:49:19 -0600 [thread overview]
Message-ID: <20220725224919.GA2887013-robh@kernel.org> (raw)
In-Reply-To: <20220722105345.175-1-13691752556@139.com>
On Fri, Jul 22, 2022 at 06:53:45PM +0800, Raphael-Xu wrote:
> remove tas2780
Your commit message needs to answer 'why'? Write complete sentences.
Though as this was just added, you should do 'git revert' and send that
patch.
And this is not v7.
> Signed-off-by: Raphael-Xu <13691752556@139.com>
> ---
> .../devicetree/bindings/sound/tas2780.yaml | 75 -------------------
> 1 file changed, 75 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/tas2780.yaml
However, Mark took the original patch with the same issues, so:
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-07-25 22:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 10:53 [PATCH v7] ASoc: dt-bindings: tas2780: remove tas2780 and will merge it to tas27xx Raphael-Xu
2022-07-22 10:53 ` Raphael-Xu
2022-07-25 22:49 ` Rob Herring [this message]
2022-07-25 22:49 ` Rob Herring
2022-07-25 23:04 ` Mark Brown
2022-07-25 23:04 ` Mark Brown
2022-07-26 15:14 ` Mark Brown
2022-07-26 15:14 ` Mark Brown
2022-07-26 16:13 ` Mark Brown
2022-07-26 16:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725224919.GA2887013-robh@kernel.org \
--to=robh@kernel.org \
--cc=13691752556@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=raphael-xu@ti.com \
--cc=shenghao-ding@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.