From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Marek Belisko <marek@goldelico.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maxime Ripard <mripard@kernel.org>,
Pratyush Yadav <p.yadav@ti.com>,
devicetree@vger.kernel.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
linux-spi@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
Thierry Reding <thierry.reding@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Daniel Vetter <daniel@ffwll.ch>, Mark Brown <broonie@kernel.org>,
dri-devel@lists.freedesktop.org,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH v2 1/1] spi/panel: dt-bindings: drop CPHA and CPOL from common properties
Date: Mon, 25 Jul 2022 17:14:05 -0600 [thread overview]
Message-ID: <20220725231405.GA2931469-robh@kernel.org> (raw)
In-Reply-To: <20220722191539.90641-2-krzysztof.kozlowski@linaro.org>
On Fri, 22 Jul 2022 21:15:39 +0200, Krzysztof Kozlowski wrote:
> The spi-cpha and spi-cpol properties are device specific and should be
> accepted only if device really needs them. Drop them from common
> spi-peripheral-props.yaml schema, mention in few panel drivers which use
> them and include instead in the SPI controller bindings. The controller
> bindings will provide CPHA/CPOL type validation and one place for
> description. Each device schema must list the properties if they are
> applicable.
>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/display/panel/lgphilips,lb035q02.yaml | 3 +++
> .../bindings/display/panel/samsung,ld9040.yaml | 3 +++
> .../bindings/display/panel/sitronix,st7789v.yaml | 3 +++
> .../devicetree/bindings/display/panel/tpo,td.yaml | 3 +++
> .../devicetree/bindings/spi/spi-controller.yaml | 11 +++++++++++
> .../devicetree/bindings/spi/spi-peripheral-props.yaml | 10 ----------
> 6 files changed, 23 insertions(+), 10 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
Unless Mark doesn't want to pick this up.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
David Airlie <airlied@linux.ie>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
dri-devel@lists.freedesktop.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Marek Belisko <marek@goldelico.com>,
Sam Ravnborg <sam@ravnborg.org>, Pratyush Yadav <p.yadav@ti.com>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 1/1] spi/panel: dt-bindings: drop CPHA and CPOL from common properties
Date: Mon, 25 Jul 2022 17:14:05 -0600 [thread overview]
Message-ID: <20220725231405.GA2931469-robh@kernel.org> (raw)
In-Reply-To: <20220722191539.90641-2-krzysztof.kozlowski@linaro.org>
On Fri, 22 Jul 2022 21:15:39 +0200, Krzysztof Kozlowski wrote:
> The spi-cpha and spi-cpol properties are device specific and should be
> accepted only if device really needs them. Drop them from common
> spi-peripheral-props.yaml schema, mention in few panel drivers which use
> them and include instead in the SPI controller bindings. The controller
> bindings will provide CPHA/CPOL type validation and one place for
> description. Each device schema must list the properties if they are
> applicable.
>
> Suggested-by: Jonathan Cameron <jic23@kernel.org>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/display/panel/lgphilips,lb035q02.yaml | 3 +++
> .../bindings/display/panel/samsung,ld9040.yaml | 3 +++
> .../bindings/display/panel/sitronix,st7789v.yaml | 3 +++
> .../devicetree/bindings/display/panel/tpo,td.yaml | 3 +++
> .../devicetree/bindings/spi/spi-controller.yaml | 11 +++++++++++
> .../devicetree/bindings/spi/spi-peripheral-props.yaml | 10 ----------
> 6 files changed, 23 insertions(+), 10 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
Unless Mark doesn't want to pick this up.
next prev parent reply other threads:[~2022-07-25 23:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 19:15 [PATCH v2 0/1] dt-bindings: spi/display/panel: drop SPI CPHA and CPOL Krzysztof Kozlowski
2022-07-22 19:15 ` [PATCH v2 1/1] spi/panel: dt-bindings: drop CPHA and CPOL from common properties Krzysztof Kozlowski
2022-07-22 19:15 ` Krzysztof Kozlowski
2022-07-22 19:45 ` Sam Ravnborg
2022-07-22 19:45 ` Sam Ravnborg
2022-07-23 18:10 ` Krzysztof Kozlowski
2022-07-23 18:10 ` Krzysztof Kozlowski
2022-07-25 23:14 ` Rob Herring [this message]
2022-07-25 23:14 ` Rob Herring
2022-07-31 10:59 ` Jonathan Cameron
2022-07-31 10:59 ` Jonathan Cameron
2022-07-26 12:20 ` [PATCH v2 0/1] dt-bindings: spi/display/panel: drop SPI CPHA and CPOL Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725231405.GA2931469-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=mripard@kernel.org \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.