[Buildroot] [PATCH 1/1] system: generate and set C.UTF-8 locale by default

[Buildroot] [PATCH 1/1] system: generate and set C.UTF-8 locale by default

[James Hilliard]

Now that glibc/localedef supports the C.UTF-8 locale we should default
to it as software like systemd generally expects it to be the locale
used.

This should in general reduce the amount of locale related
compatibility issues and is what many distros have been using for
their default locale for quite a few years so it should be a well
tested configuration.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 system/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/system/Config.in b/system/Config.in
index 888c24ce81..7cc529d31e 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -440,7 +440,7 @@ config BR2_ENABLE_LOCALE_PURGE
 
 config BR2_ENABLE_LOCALE_WHITELIST
 	string "Locales to keep"
-	default "C en_US"
+	default "C.UTF-8"
 	depends on BR2_ENABLE_LOCALE_PURGE
 	help
 	  Whitespace seperated list of locales to allow on target.
@@ -455,7 +455,7 @@ config BR2_ENABLE_LOCALE_WHITELIST
 
 config BR2_GENERATE_LOCALE
 	string "Generate locale data"
-	default ""
+	default "C.UTF-8"
 	depends on \
 		(BR2_TOOLCHAIN_BUILDROOT_UCLIBC && BR2_ENABLE_LOCALE) || \
 		BR2_TOOLCHAIN_USES_GLIBC
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] system: generate and set C.UTF-8 locale by default

[Arnout Vandecappelle]

On 17/05/2022 21:24, James Hilliard wrote:
> Now that glibc/localedef supports the C.UTF-8 locale we should default
> to it as software like systemd generally expects it to be the locale
> used.
> 
> This should in general reduce the amount of locale related
> compatibility issues and is what many distros have been using for
> their default locale for quite a few years so it should be a well
> tested configuration.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>   system/Config.in | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/system/Config.in b/system/Config.in
> index 888c24ce81..7cc529d31e 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -440,7 +440,7 @@ config BR2_ENABLE_LOCALE_PURGE
>   
>   config BR2_ENABLE_LOCALE_WHITELIST
>   	string "Locales to keep"
> -	default "C en_US"
> +	default "C.UTF-8"
>   	depends on BR2_ENABLE_LOCALE_PURGE
>   	help
>   	  Whitespace seperated list of locales to allow on target.
> @@ -455,7 +455,7 @@ config BR2_ENABLE_LOCALE_WHITELIST
>   
>   config BR2_GENERATE_LOCALE
>   	string "Generate locale data"
> -	default ""
> +	default "C.UTF-8"
>   	depends on \
>   		(BR2_TOOLCHAIN_BUILDROOT_UCLIBC && BR2_ENABLE_LOCALE) || \

  Is this locale also supported by uClibc?

  Regards,
  Arnout

>   		BR2_TOOLCHAIN_USES_GLIBC
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] system: generate and set C.UTF-8 locale by default

[James Hilliard]

On Wed, May 18, 2022 at 12:27 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
>
> On 17/05/2022 21:24, James Hilliard wrote:
> > Now that glibc/localedef supports the C.UTF-8 locale we should default
> > to it as software like systemd generally expects it to be the locale
> > used.
> >
> > This should in general reduce the amount of locale related
> > compatibility issues and is what many distros have been using for
> > their default locale for quite a few years so it should be a well
> > tested configuration.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> >   system/Config.in | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/system/Config.in b/system/Config.in
> > index 888c24ce81..7cc529d31e 100644
> > --- a/system/Config.in
> > +++ b/system/Config.in
> > @@ -440,7 +440,7 @@ config BR2_ENABLE_LOCALE_PURGE
> >
> >   config BR2_ENABLE_LOCALE_WHITELIST
> >       string "Locales to keep"
> > -     default "C en_US"
> > +     default "C.UTF-8"
> >       depends on BR2_ENABLE_LOCALE_PURGE
> >       help
> >         Whitespace seperated list of locales to allow on target.
> > @@ -455,7 +455,7 @@ config BR2_ENABLE_LOCALE_WHITELIST
> >
> >   config BR2_GENERATE_LOCALE
> >       string "Generate locale data"
> > -     default ""
> > +     default "C.UTF-8"
> >       depends on \
> >               (BR2_TOOLCHAIN_BUILDROOT_UCLIBC && BR2_ENABLE_LOCALE) || \
>
>   Is this locale also supported by uClibc?

Looks like there's issues there, I had assumed it was using
host-localedef but I guess
that's not the case, although wondering if it's possible as uclibc
locale support seems
pretty bad.

Also wondering if the musl locale handling is ok for BR2_ENABLE_LOCALE_WHITELIST
as I thought musl just used a built-in C.UTF-8 locale.

>
>   Regards,
>   Arnout
>
> >               BR2_TOOLCHAIN_USES_GLIBC
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] system: generate and set C.UTF-8 locale by default

[Thomas Petazzoni via buildroot]

Hello James,

On Tue, 17 May 2022 13:24:39 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Now that glibc/localedef supports the C.UTF-8 locale we should default
> to it as software like systemd generally expects it to be the locale
> used.
> 
> This should in general reduce the amount of locale related
> compatibility issues and is what many distros have been using for
> their default locale for quite a few years so it should be a well
> tested configuration.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  system/Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Based on the feedback you have received, it appears that this patch
needs to be revisited to make sure it makes sense and works not just
for glibc, but also for uclibc and musl. Could you have a look at this?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot