* [Buildroot] [PATCH 1/1] package/pulseaudio: alsa needs UCM
@ 2022-07-26 20:16 Fabrice Fontaine
2022-07-26 21:47 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2022-07-26 20:16 UTC (permalink / raw)
To: buildroot; +Cc: Bernd Kuhls, Fabrice Fontaine
alsa needs UCM since bump to version 16.1 in commit
6f3131296484767f037d3535ab69f328e94351db to avoid the following build
failure:
In file included from ../src/modules/alsa/alsa-mixer.h:51,
from ../src/modules/alsa/alsa-ucm.c:51:
../src/modules/alsa/alsa-ucm.h:26:10: fatal error: alsa/use-case.h: No such file or directory
26 | #include <alsa/use-case.h>
| ^~~~~~~~~~~~~~~~~
Fixes:
- http://autobuild.buildroot.org/results/c651c03bc493ac721ad6517ace550237488ef8a8
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/pulseaudio/pulseaudio.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/pulseaudio/pulseaudio.mk b/package/pulseaudio/pulseaudio.mk
index b423057ab6..567540c225 100644
--- a/package/pulseaudio/pulseaudio.mk
+++ b/package/pulseaudio/pulseaudio.mk
@@ -105,8 +105,8 @@ else
PULSEAUDIO_CONF_OPTS += -Dwebrtc-aec=disabled
endif
-# pulseaudio alsa backend needs pcm/mixer apis
-ifeq ($(BR2_PACKAGE_ALSA_LIB_PCM)$(BR2_PACKAGE_ALSA_LIB_MIXER),yy)
+# pulseaudio alsa backend needs pcm/mixer/ucm apis
+ifeq ($(BR2_PACKAGE_ALSA_LIB_PCM)$(BR2_PACKAGE_ALSA_LIB_MIXER)$(BR2_PACKAGE_ALSA_LIB_UCM),yyy)
PULSEAUDIO_DEPENDENCIES += alsa-lib
PULSEAUDIO_CONF_OPTS += -Dalsa=enabled
else
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/pulseaudio: alsa needs UCM
2022-07-26 20:16 [Buildroot] [PATCH 1/1] package/pulseaudio: alsa needs UCM Fabrice Fontaine
@ 2022-07-26 21:47 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-07-26 21:47 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Bernd Kuhls, buildroot
On Tue, 26 Jul 2022 22:16:47 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> alsa needs UCM since bump to version 16.1 in commit
> 6f3131296484767f037d3535ab69f328e94351db to avoid the following build
> failure:
>
> In file included from ../src/modules/alsa/alsa-mixer.h:51,
> from ../src/modules/alsa/alsa-ucm.c:51:
> ../src/modules/alsa/alsa-ucm.h:26:10: fatal error: alsa/use-case.h: No such file or directory
> 26 | #include <alsa/use-case.h>
> | ^~~~~~~~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/c651c03bc493ac721ad6517ace550237488ef8a8
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/pulseaudio/pulseaudio.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks. We also applied a follow-up patch changing a
bit how this is handled: see commit
97cd3680a4cc4bc0c71bccccb1459eda4b880159.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-26 21:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-26 20:16 [Buildroot] [PATCH 1/1] package/pulseaudio: alsa needs UCM Fabrice Fontaine
2022-07-26 21:47 ` Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.