From: Christoph Hellwig <hch@lst.de>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH blktests 1/6] common/rc: avoid module load in _have_driver()
Date: Thu, 28 Jul 2022 16:45:48 +0200 [thread overview]
Message-ID: <20220728144548.GB18285@lst.de> (raw)
In-Reply-To: <20220727085251.1474340-2-shinichiro.kawasaki@wdc.com>
On Wed, Jul 27, 2022 at 05:52:46PM +0900, Shin'ichiro Kawasaki wrote:
> The helper function _have_driver() checks availability of the specified
> driver, or module, regardless whether it is loadable or not. When the
> driver is loadable, it loads the module for checking, but does not
> unload it. This makes following test cases fail.
>
> Such failure happens when nvmeof-mp test group is executed after nvme
> test group with tcp transport. _have_driver() for tcp transport loads
> nvmet and nvmet-tcp modules. nvmeof-mp test group tries to unload the
> nvmet module but it fails because of dependency to the nvmet-tcp module.
>
> To avoid the failure, do not load module in _have_driver() using -n
> dry run option of the modprobe command. While at it, fix a minor problem
> of modname '-' replacement. Currently, only the first '-' in modname is
> replaced with '_'. Replace all '-'s.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-07-28 14:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 8:52 [PATCH blktests 0/6] fix module check issues Shin'ichiro Kawasaki
2022-07-27 8:52 ` [PATCH blktests 1/6] common/rc: avoid module load in _have_driver() Shin'ichiro Kawasaki
2022-07-28 14:45 ` Christoph Hellwig [this message]
2022-07-27 8:52 ` [PATCH blktests 2/6] nbd/rc: load nbd module explicitly Shin'ichiro Kawasaki
2022-07-28 14:46 ` Christoph Hellwig
2022-07-29 0:12 ` Shinichiro Kawasaki
2022-07-27 8:52 ` [PATCH blktests 3/6] common/rc: ensure modules are loadable in _have_modules() Shin'ichiro Kawasaki
2022-07-27 8:52 ` [PATCH blktests 4/6] common,tests: replace _have_driver() with _have_drivers() Shin'ichiro Kawasaki
2022-07-27 8:52 ` [PATCH blktests 5/6] block/001: use _have_drivers() in place of _have_modules() Shin'ichiro Kawasaki
2022-07-27 8:52 ` [PATCH blktests 6/6] srp/rc: allow test with built-in sd_mod and sg drivers Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728144548.GB18285@lst.de \
--to=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.