From: Christoph Hellwig <hch@lst.de>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH blktests 2/6] nbd/rc: load nbd module explicitly
Date: Thu, 28 Jul 2022 16:46:25 +0200 [thread overview]
Message-ID: <20220728144625.GC18285@lst.de> (raw)
In-Reply-To: <20220727085251.1474340-3-shinichiro.kawasaki@wdc.com>
On Wed, Jul 27, 2022 at 05:52:47PM +0900, Shin'ichiro Kawasaki wrote:
> After the commit "common/rc: avoid module load in _have_driver()",
> _have_driver() no longer loads specified module. However, nbd test cases
> and _have_nbd_netlink() function assume that the module is loaded by
> calling _have_driver(). This causes test case failures and unexpected
> skips. To fix them, load and unload modules explicitly in functions
> _start_nbd_server*(), _stop_nbd_server*() and _have_nbd_netlink().
Did you test this with built-in nbd?
next prev parent reply other threads:[~2022-07-28 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 8:52 [PATCH blktests 0/6] fix module check issues Shin'ichiro Kawasaki
2022-07-27 8:52 ` [PATCH blktests 1/6] common/rc: avoid module load in _have_driver() Shin'ichiro Kawasaki
2022-07-28 14:45 ` Christoph Hellwig
2022-07-27 8:52 ` [PATCH blktests 2/6] nbd/rc: load nbd module explicitly Shin'ichiro Kawasaki
2022-07-28 14:46 ` Christoph Hellwig [this message]
2022-07-29 0:12 ` Shinichiro Kawasaki
2022-07-27 8:52 ` [PATCH blktests 3/6] common/rc: ensure modules are loadable in _have_modules() Shin'ichiro Kawasaki
2022-07-27 8:52 ` [PATCH blktests 4/6] common,tests: replace _have_driver() with _have_drivers() Shin'ichiro Kawasaki
2022-07-27 8:52 ` [PATCH blktests 5/6] block/001: use _have_drivers() in place of _have_modules() Shin'ichiro Kawasaki
2022-07-27 8:52 ` [PATCH blktests 6/6] srp/rc: allow test with built-in sd_mod and sg drivers Shin'ichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728144625.GC18285@lst.de \
--to=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.