* [merged mm-stable] mm-mmapc-fix-missing-call-to-vm_unacct_memory-in-mmap_region.patch removed from -mm tree
@ 2022-07-30 1:08 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2022-07-30 1:08 UTC (permalink / raw)
To: mm-commits, linmiaohe, akpm
The quilt patch titled
Subject: mm/mmap.c: fix missing call to vm_unacct_memory in mmap_region
has been removed from the -mm tree. Its filename was
mm-mmapc-fix-missing-call-to-vm_unacct_memory-in-mmap_region.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Miaohe Lin <linmiaohe@huawei.com>
Subject: mm/mmap.c: fix missing call to vm_unacct_memory in mmap_region
Date: Sat, 18 Jun 2022 16:20:27 +0800
Since the beginning, charged is set to 0 to avoid calling vm_unacct_memory
twice because vm_unacct_memory will be called by above unmap_region. But
since commit 4f74d2c8e827 ("vm: remove 'nr_accounted' calculations from
the unmap_vmas() interfaces"), unmap_region doesn't call vm_unacct_memory
anymore. So charged shouldn't be set to 0 now otherwise the calling to
paired vm_unacct_memory will be missed and leads to imbalanced account.
Link: https://lkml.kernel.org/r/20220618082027.43391-1-linmiaohe@huawei.com
Fixes: 4f74d2c8e827 ("vm: remove 'nr_accounted' calculations from the unmap_vmas() interfaces")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/mmap.c | 1 -
1 file changed, 1 deletion(-)
--- a/mm/mmap.c~mm-mmapc-fix-missing-call-to-vm_unacct_memory-in-mmap_region
+++ a/mm/mmap.c
@@ -1847,7 +1847,6 @@ unmap_and_free_vma:
/* Undo any partial mapping done by a device driver. */
unmap_region(mm, vma, prev, vma->vm_start, vma->vm_end);
- charged = 0;
if (vm_flags & VM_SHARED)
mapping_unmap_writable(file->f_mapping);
free_vma:
_
Patches currently in -mm which might be from linmiaohe@huawei.com are
mm-hugetlb-avoid-corrupting-page-mapping-in-hugetlb_mcopy_atomic_pte.patch
mm-page_alloc-minor-clean-up-for-memmap_init_compound.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-07-30 1:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-30 1:08 [merged mm-stable] mm-mmapc-fix-missing-call-to-vm_unacct_memory-in-mmap_region.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.