All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Elvis Wang <Elvis.Wang@mediatek.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	CK Hu <ck.hu@mediatek.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH 1/2] dt-bindings: mailbox: add definition for mt8188
Date: Wed, 3 Aug 2022 16:25:53 -0600	[thread overview]
Message-ID: <20220803222553.GA2727128-robh@kernel.org> (raw)
In-Reply-To: <20220729084319.6880-2-Elvis.Wang@mediatek.com>

On Fri, Jul 29, 2022 at 04:43:18PM +0800, Elvis Wang wrote:
> Add dt-binding header for mt8188.
> 
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> ---
>  Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> index c2aeba63bd47..50f97f6feeef 100644
> --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> @@ -41,9 +41,9 @@ Optional properties for a client mutex node:
>    defined in 'dt-bindings/gce/<chip>-gce.h'.
>  
>  Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h',
> -'dt-bindings/gce/mt8183-gce.h', 'dt-bindings/gce/mt8186-gce.h'
> -'dt-bindings/gce/mt8192-gce.h', 'dt-bindings/gce/mt8195-gce.h' or
> -'dt-bindings/gce/mt6779-gce.h'.
> +'dt-bindings/gce/mt8183-gce.h', 'dt-bindings/gce/mt8186-gce.h',
> +'dt-bindings/gce/mt8188-gce.h', 'dt-bindings/gce/mt8192-gce.h',
> +'dt-bindings/gce/mt8195-gce.h' or 'dt-bindings/gce/mt6779-gce.h'.
>  Such as sub-system ids, thread priority, event ids.

What about a new compatible string?

Really, this needs to be converted to schema...

Rob


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Elvis Wang <Elvis.Wang@mediatek.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	CK Hu <ck.hu@mediatek.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH 1/2] dt-bindings: mailbox: add definition for mt8188
Date: Wed, 3 Aug 2022 16:25:53 -0600	[thread overview]
Message-ID: <20220803222553.GA2727128-robh@kernel.org> (raw)
In-Reply-To: <20220729084319.6880-2-Elvis.Wang@mediatek.com>

On Fri, Jul 29, 2022 at 04:43:18PM +0800, Elvis Wang wrote:
> Add dt-binding header for mt8188.
> 
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> ---
>  Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> index c2aeba63bd47..50f97f6feeef 100644
> --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> @@ -41,9 +41,9 @@ Optional properties for a client mutex node:
>    defined in 'dt-bindings/gce/<chip>-gce.h'.
>  
>  Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h',
> -'dt-bindings/gce/mt8183-gce.h', 'dt-bindings/gce/mt8186-gce.h'
> -'dt-bindings/gce/mt8192-gce.h', 'dt-bindings/gce/mt8195-gce.h' or
> -'dt-bindings/gce/mt6779-gce.h'.
> +'dt-bindings/gce/mt8183-gce.h', 'dt-bindings/gce/mt8186-gce.h',
> +'dt-bindings/gce/mt8188-gce.h', 'dt-bindings/gce/mt8192-gce.h',
> +'dt-bindings/gce/mt8195-gce.h' or 'dt-bindings/gce/mt6779-gce.h'.
>  Such as sub-system ids, thread priority, event ids.

What about a new compatible string?

Really, this needs to be converted to schema...

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-08-03 22:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29  8:43 [PATCH 0/2] Add gce support for mt8188 Elvis Wang
2022-07-29  8:43 ` Elvis Wang
2022-07-29  8:43 ` [PATCH 1/2] dt-bindings: mailbox: add definition " Elvis Wang
2022-07-29  8:43   ` Elvis Wang
2022-08-02  8:06   ` Krzysztof Kozlowski
2022-08-02  8:06     ` Krzysztof Kozlowski
2022-08-03 22:25   ` Rob Herring [this message]
2022-08-03 22:25     ` Rob Herring
2022-09-09  5:40     ` elvis.wang
2022-09-09  5:40       ` elvis.wang
2022-07-29  8:43 ` [PATCH 2/2] dt-bindings: gce: add gce header file " Elvis Wang
2022-07-29  8:43   ` Elvis Wang
2022-08-02  3:17   ` Rex-BC Chen
2022-08-02  3:17     ` Rex-BC Chen
2022-09-09  4:04     ` elvis.wang
2022-09-09  4:04       ` elvis.wang
2022-08-02  8:08   ` Krzysztof Kozlowski
2022-08-02  8:08     ` Krzysztof Kozlowski
2022-09-09  6:46     ` elvis.wang
2022-09-09  6:46       ` elvis.wang
2022-09-09  7:27       ` Krzysztof Kozlowski
2022-09-09  7:27         ` Krzysztof Kozlowski
2022-09-28  2:20         ` elvis.wang
2022-09-28  2:20           ` elvis.wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220803222553.GA2727128-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Elvis.Wang@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=ck.hu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.