* [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible
@ 2022-08-04 14:55 ` Tomer Maimon
0 siblings, 0 replies; 7+ messages in thread
From: Tomer Maimon @ 2022-08-04 14:55 UTC (permalink / raw)
To: avifishman70, tali.perry1, joel, venture, yuenn, benjaminfair,
jic23, minyard, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, openbmc, Tomer Maimon, openipmi-developer,
linux-kernel
Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
string.
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
index cbc10a68ddef..4fda76e63396 100644
--- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
+++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
@@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
Required properties:
- compatible : should be one of
"nuvoton,npcm750-kcs-bmc"
- "nuvoton,npcm845-kcs-bmc"
+ "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
- interrupts : interrupt generated by the controller
- kcs_chan : The KCS channel number in the controller
--
2.33.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible
@ 2022-08-04 14:55 ` Tomer Maimon
0 siblings, 0 replies; 7+ messages in thread
From: Tomer Maimon @ 2022-08-04 14:55 UTC (permalink / raw)
To: avifishman70, tali.perry1, joel, venture, yuenn, benjaminfair,
jic23, minyard, robh+dt, krzysztof.kozlowski+dt
Cc: openbmc, openipmi-developer, linux-kernel, devicetree,
Tomer Maimon
Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
string.
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
index cbc10a68ddef..4fda76e63396 100644
--- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
+++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
@@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
Required properties:
- compatible : should be one of
"nuvoton,npcm750-kcs-bmc"
- "nuvoton,npcm845-kcs-bmc"
+ "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
- interrupts : interrupt generated by the controller
- kcs_chan : The KCS channel number in the controller
--
2.33.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible
2022-08-04 14:55 ` Tomer Maimon
@ 2022-08-04 15:01 ` Paul Menzel
-1 siblings, 0 replies; 7+ messages in thread
From: Paul Menzel @ 2022-08-04 15:01 UTC (permalink / raw)
To: Tomer Maimon
Cc: devicetree, benjaminfair, minyard, avifishman70, venture, openbmc,
linux-kernel, tali.perry1, robh+dt, joel, krzysztof.kozlowski+dt,
openipmi-developer, jic23
Dear Tomer,
Am 04.08.22 um 16:55 schrieb Tomer Maimon:
> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
> string.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> index cbc10a68ddef..4fda76e63396 100644
> --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
> Required properties:
> - compatible : should be one of
> "nuvoton,npcm750-kcs-bmc"
> - "nuvoton,npcm845-kcs-bmc"
> + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
Isn’t the added string exactly the same as the one below the compatible
line?
> - interrupts : interrupt generated by the controller
> - kcs_chan : The KCS channel number in the controller
Kind regards,
Paul
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible
@ 2022-08-04 15:01 ` Paul Menzel
0 siblings, 0 replies; 7+ messages in thread
From: Paul Menzel @ 2022-08-04 15:01 UTC (permalink / raw)
To: Tomer Maimon
Cc: avifishman70, tali.perry1, joel, venture, yuenn, benjaminfair,
jic23, minyard, robh+dt, krzysztof.kozlowski+dt, devicetree,
openbmc, openipmi-developer, linux-kernel
Dear Tomer,
Am 04.08.22 um 16:55 schrieb Tomer Maimon:
> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
> string.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> index cbc10a68ddef..4fda76e63396 100644
> --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
> Required properties:
> - compatible : should be one of
> "nuvoton,npcm750-kcs-bmc"
> - "nuvoton,npcm845-kcs-bmc"
> + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
Isn’t the added string exactly the same as the one below the compatible
line?
> - interrupts : interrupt generated by the controller
> - kcs_chan : The KCS channel number in the controller
Kind regards,
Paul
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible
2022-08-04 15:01 ` Paul Menzel
@ 2022-08-04 15:40 ` Tomer Maimon
-1 siblings, 0 replies; 7+ messages in thread
From: Tomer Maimon @ 2022-08-04 15:40 UTC (permalink / raw)
To: Paul Menzel
Cc: devicetree, Benjamin Fair, minyard, Avi Fishman, Patrick Venture,
OpenBMC Maillist, Linux Kernel Mailing List, Tali Perry,
Rob Herring, Joel Stanley, Krzysztof Kozlowski,
openipmi-developer, Jonathan Cameron
Hi Paul,
On Thu, 4 Aug 2022 at 18:01, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Tomer,
>
>
> Am 04.08.22 um 16:55 schrieb Tomer Maimon:
> > Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
> > string.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> > ---
> > Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> > index cbc10a68ddef..4fda76e63396 100644
> > --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> > +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> > @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
> > Required properties:
> > - compatible : should be one of
> > "nuvoton,npcm750-kcs-bmc"
> > - "nuvoton,npcm845-kcs-bmc"
> > + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
>
> Isn’t the added string exactly the same as the one below the compatible
> line?
it is not the same, it describes a fallback to NPCM7XX KCS Since
NPCM8XX KCS and NPCM7XX KCS modules are similar.
>
> > - interrupts : interrupt generated by the controller
> > - kcs_chan : The KCS channel number in the controller
>
>
> Kind regards,
>
> Paul
Best regards,
Tomer
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible
@ 2022-08-04 15:40 ` Tomer Maimon
0 siblings, 0 replies; 7+ messages in thread
From: Tomer Maimon @ 2022-08-04 15:40 UTC (permalink / raw)
To: Paul Menzel
Cc: Avi Fishman, Tali Perry, Joel Stanley, Patrick Venture,
Nancy Yuen, Benjamin Fair, Jonathan Cameron, minyard, Rob Herring,
Krzysztof Kozlowski, devicetree, OpenBMC Maillist,
openipmi-developer, Linux Kernel Mailing List
Hi Paul,
On Thu, 4 Aug 2022 at 18:01, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Tomer,
>
>
> Am 04.08.22 um 16:55 schrieb Tomer Maimon:
> > Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
> > string.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> > ---
> > Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> > index cbc10a68ddef..4fda76e63396 100644
> > --- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> > +++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
> > @@ -7,7 +7,7 @@ used to perform in-band IPMI communication with their host.
> > Required properties:
> > - compatible : should be one of
> > "nuvoton,npcm750-kcs-bmc"
> > - "nuvoton,npcm845-kcs-bmc"
> > + "nuvoton,npcm845-kcs-bmc", "nuvoton,npcm750-kcs-bmc"
>
> Isn’t the added string exactly the same as the one below the compatible
> line?
it is not the same, it describes a fallback to NPCM7XX KCS Since
NPCM8XX KCS and NPCM7XX KCS modules are similar.
>
> > - interrupts : interrupt generated by the controller
> > - kcs_chan : The KCS channel number in the controller
>
>
> Kind regards,
>
> Paul
Best regards,
Tomer
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible
2022-08-04 14:55 ` Tomer Maimon
(?)
(?)
@ 2022-08-04 15:14 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-04 15:14 UTC (permalink / raw)
To: Tomer Maimon, avifishman70, tali.perry1, joel, venture, yuenn,
benjaminfair, jic23, minyard, robh+dt, krzysztof.kozlowski+dt
Cc: openbmc, openipmi-developer, linux-kernel, devicetree
On 04/08/2022 16:55, Tomer Maimon wrote:
> Add to npcm845 KCS compatible string a fallback to npcm750 KCS compatible
> string.
It's easily visible in the code what you are doing, so instead you must
explain why you are doing it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-08-04 15:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-04 14:55 [PATCH v1] dt-binding: ipmi: add fallback to npcm845 compatible Tomer Maimon
2022-08-04 14:55 ` Tomer Maimon
2022-08-04 15:01 ` Paul Menzel
2022-08-04 15:01 ` Paul Menzel
2022-08-04 15:40 ` Tomer Maimon
2022-08-04 15:40 ` Tomer Maimon
2022-08-04 15:14 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.