* [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M
@ 2022-08-02 11:02 Francesco Dolcini
2022-08-22 8:40 ` Linus Walleij
0 siblings, 1 reply; 9+ messages in thread
From: Francesco Dolcini @ 2022-08-02 11:02 UTC (permalink / raw)
To: Peng Fan, linux-gpio
Cc: Francesco Dolcini, Dong Aisheng, Fabio Estevam, Shawn Guo,
Jacky Bai, Pengutronix Kernel Team, Linus Walleij
Change PINCTRL_IMX8M* dependency from just ARCH_MXC to SOC_IMX8M,
likewise is done for other PINCTRL_IMX* kconfig. This avoid polluting
the config when SOC_IMX8M is not enabled.
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
A similar change would be needed for drivers/clk/imx/Kconfig,
in addition to that the other pinctrl are selected by the SOC
(config SOC_IMX7D -> select PINCTRL_IMX7D), while this is not true for
IMX8M and these options.
Not sure what should we do exactly, therefore the RFC tag, I stumbled on this while
slimming down the imx_v6_v7_defconfig for my own needs, and after disabling SOC_IMX8M
all these options were still enabled.
---
drivers/pinctrl/freescale/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index d96b1130efd3..365fcff8e470 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP
config PINCTRL_IMX8MM
tristate "IMX8MM pinctrl driver"
- depends on ARCH_MXC
+ depends on SOC_IMX8M
select PINCTRL_IMX
help
Say Y here to enable the imx8mm pinctrl driver
config PINCTRL_IMX8MN
tristate "IMX8MN pinctrl driver"
- depends on ARCH_MXC
+ depends on SOC_IMX8M
select PINCTRL_IMX
help
Say Y here to enable the imx8mn pinctrl driver
config PINCTRL_IMX8MP
tristate "IMX8MP pinctrl driver"
- depends on ARCH_MXC
+ depends on SOC_IMX8M
select PINCTRL_IMX
help
Say Y here to enable the imx8mp pinctrl driver
config PINCTRL_IMX8MQ
tristate "IMX8MQ pinctrl driver"
- depends on ARCH_MXC
+ depends on SOC_IMX8M
select PINCTRL_IMX
help
Say Y here to enable the imx8mq pinctrl driver
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M
@ 2022-08-06 12:36 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-08-06 12:36 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 13269 bytes --]
::::::
:::::: Manual check reason: "only Kconfig file updated"
::::::
BCC: lkp(a)intel.com
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20220802110232.130758-1-francesco.dolcini@toradex.com>
References: <20220802110232.130758-1-francesco.dolcini@toradex.com>
TO: Francesco Dolcini <francesco.dolcini@toradex.com>
Hi Francesco,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linus/master v5.19 next-20220805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: alpha-randconfig-r033-20220805 (https://download.01.org/0day-ci/archive/20220806/202208062030.11RYGgce-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/8cf69707b586a5aaa92ba9757f2d98383b220a43
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
git checkout 8cf69707b586a5aaa92ba9757f2d98383b220a43
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/pinctrl/freescale/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pmx_set':
drivers/pinctrl/freescale/pinctrl-imx.c:260:16: error: implicit declaration of function 'pinmux_generic_get_function'; did you mean 'pinmux_generic_free_functions'? [-Werror=implicit-function-declaration]
260 | func = pinmux_generic_get_function(pctldev, selector);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
>> drivers/pinctrl/freescale/pinctrl-imx.c:260:14: warning: assignment to 'struct function_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
260 | func = pinmux_generic_get_function(pctldev, selector);
| ^
In file included from include/linux/device.h:15,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/of_device.h:5,
from drivers/pinctrl/freescale/pinctrl-imx.c:16:
drivers/pinctrl/freescale/pinctrl-imx.c:267:21: error: invalid use of undefined type 'struct function_desc'
267 | func->name, grp->name);
| ^~
include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk'
129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/pinctrl/freescale/pinctrl-imx.c:266:9: note: in expansion of macro 'dev_dbg'
266 | dev_dbg(ipctl->dev, "enable function %s group %s\n",
| ^~~~~~~
drivers/pinctrl/freescale/pinctrl-imx.c: At top level:
drivers/pinctrl/freescale/pinctrl-imx.c:287:32: error: 'pinmux_generic_get_function_count' undeclared here (not in a function); did you mean 'pinmux_generic_free_functions'?
287 | .get_functions_count = pinmux_generic_get_function_count,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
drivers/pinctrl/freescale/pinctrl-imx.c:288:30: error: 'pinmux_generic_get_function_name' undeclared here (not in a function); did you mean 'pinmux_generic_free_functions'?
288 | .get_function_name = pinmux_generic_get_function_name,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
drivers/pinctrl/freescale/pinctrl-imx.c:289:32: error: 'pinmux_generic_get_function_groups' undeclared here (not in a function); did you mean 'pinmux_generic_free_functions'?
289 | .get_function_groups = pinmux_generic_get_function_groups,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinconf_parse_generic_config':
drivers/pinctrl/freescale/pinctrl-imx.c:341:15: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Werror=implicit-function-declaration]
341 | ret = pinconf_generic_parse_dt_config(np, pctl, &configs,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinconf_generic_dump_config
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_parse_functions':
drivers/pinctrl/freescale/pinctrl-imx.c:656:14: warning: assignment to 'struct function_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
656 | func = pinmux_generic_get_function(pctl, index);
| ^
drivers/pinctrl/freescale/pinctrl-imx.c:661:13: error: invalid use of undefined type 'struct function_desc'
661 | func->name = np->name;
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c:662:13: error: invalid use of undefined type 'struct function_desc'
662 | func->num_group_names = of_get_child_count(np);
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c:663:17: error: invalid use of undefined type 'struct function_desc'
663 | if (func->num_group_names == 0) {
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c:668:52: error: invalid use of undefined type 'struct function_desc'
668 | group_names = devm_kcalloc(ipctl->dev, func->num_group_names,
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c:675:13: error: invalid use of undefined type 'struct function_desc'
675 | func->group_names = group_names;
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_probe_dt':
drivers/pinctrl/freescale/pinctrl-imx.c:752:59: error: invalid application of 'sizeof' to incomplete type 'struct function_desc'
752 | function = devm_kzalloc(&pdev->dev, sizeof(*function),
| ^
drivers/pinctrl/freescale/pinctrl-imx.c:758:40: error: 'struct pinctrl_dev' has no member named 'pin_function_tree'
758 | radix_tree_insert(&pctl->pin_function_tree, i, function);
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c:761:13: error: 'struct pinctrl_dev' has no member named 'num_functions'
761 | pctl->num_functions = nfuncs;
| ^~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for PINCTRL_IMX
Depends on [n]: PINCTRL [=y] && OF [=n]
Selected by [y]:
- PINCTRL_IMX8MP [=y] && PINCTRL [=y] && SOC_IMX8M [=y]
Selected by [m]:
- PINCTRL_IMX8MM [=m] && PINCTRL [=y] && SOC_IMX8M [=y]
- PINCTRL_IMX8MN [=m] && PINCTRL [=y] && SOC_IMX8M [=y]
vim +260 drivers/pinctrl/freescale/pinctrl-imx.c
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 240
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 241 static int imx_pmx_set(struct pinctrl_dev *pctldev, unsigned selector,
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 242 unsigned group)
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 243 {
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 244 struct imx_pinctrl *ipctl = pinctrl_dev_get_drvdata(pctldev);
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 245 const struct imx_pinctrl_soc_info *info = ipctl->info;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 246 struct function_desc *func;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 247 struct group_desc *grp;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 248 struct imx_pin *pin;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 249 unsigned int npins;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 250 int i, err;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 251
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 252 /*
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 253 * Configure the mux mode for each pin in the group for a specific
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 254 * function.
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 255 */
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 256 grp = pinctrl_generic_get_group(pctldev, group);
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 257 if (!grp)
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 258 return -EINVAL;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 259
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 @260 func = pinmux_generic_get_function(pctldev, selector);
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 261 if (!func)
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 262 return -EINVAL;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 263
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 264 npins = grp->num_pins;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 265
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 266 dev_dbg(ipctl->dev, "enable function %s group %s\n",
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 267 func->name, grp->name);
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 268
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 269 for (i = 0; i < npins; i++) {
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 270 /*
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 271 * For IMX_USE_SCU case, we postpone the mux setting
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 272 * until config is set as we can set them together
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 273 * in one IPC call
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 274 */
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 275 pin = &((struct imx_pin *)(grp->data))[i];
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 276 if (!(info->flags & IMX_USE_SCU)) {
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 277 err = imx_pmx_set_one_pin_mmio(ipctl, pin);
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 278 if (err)
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 279 return err;
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 280 }
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 281 }
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 282
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 283 return 0;
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 284 }
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 285
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M
@ 2022-08-06 15:41 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-08-06 15:41 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 20412 bytes --]
::::::
:::::: Manual check reason: "only Kconfig file updated"
::::::
BCC: lkp(a)intel.com
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20220802110232.130758-1-francesco.dolcini@toradex.com>
References: <20220802110232.130758-1-francesco.dolcini@toradex.com>
TO: Francesco Dolcini <francesco.dolcini@toradex.com>
Hi Francesco,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on linusw-pinctrl/devel]
[also build test ERROR on linus/master v5.19 next-20220805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: alpha-randconfig-r033-20220805 (https://download.01.org/0day-ci/archive/20220806/202208062321.ZN1m0l56-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/8cf69707b586a5aaa92ba9757f2d98383b220a43
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
git checkout 8cf69707b586a5aaa92ba9757f2d98383b220a43
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pmx_set':
>> drivers/pinctrl/freescale/pinctrl-imx.c:260:16: error: implicit declaration of function 'pinmux_generic_get_function'; did you mean 'pinmux_generic_free_functions'? [-Werror=implicit-function-declaration]
260 | func = pinmux_generic_get_function(pctldev, selector);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
drivers/pinctrl/freescale/pinctrl-imx.c:260:14: warning: assignment to 'struct function_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
260 | func = pinmux_generic_get_function(pctldev, selector);
| ^
In file included from include/linux/device.h:15,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/of_device.h:5,
from drivers/pinctrl/freescale/pinctrl-imx.c:16:
>> drivers/pinctrl/freescale/pinctrl-imx.c:267:21: error: invalid use of undefined type 'struct function_desc'
267 | func->name, grp->name);
| ^~
include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk'
129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/pinctrl/freescale/pinctrl-imx.c:266:9: note: in expansion of macro 'dev_dbg'
266 | dev_dbg(ipctl->dev, "enable function %s group %s\n",
| ^~~~~~~
drivers/pinctrl/freescale/pinctrl-imx.c: At top level:
>> drivers/pinctrl/freescale/pinctrl-imx.c:287:32: error: 'pinmux_generic_get_function_count' undeclared here (not in a function); did you mean 'pinmux_generic_free_functions'?
287 | .get_functions_count = pinmux_generic_get_function_count,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
>> drivers/pinctrl/freescale/pinctrl-imx.c:288:30: error: 'pinmux_generic_get_function_name' undeclared here (not in a function); did you mean 'pinmux_generic_free_functions'?
288 | .get_function_name = pinmux_generic_get_function_name,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
>> drivers/pinctrl/freescale/pinctrl-imx.c:289:32: error: 'pinmux_generic_get_function_groups' undeclared here (not in a function); did you mean 'pinmux_generic_free_functions'?
289 | .get_function_groups = pinmux_generic_get_function_groups,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinmux_generic_free_functions
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinconf_parse_generic_config':
>> drivers/pinctrl/freescale/pinctrl-imx.c:341:15: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Werror=implicit-function-declaration]
341 | ret = pinconf_generic_parse_dt_config(np, pctl, &configs,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinconf_generic_dump_config
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_parse_functions':
drivers/pinctrl/freescale/pinctrl-imx.c:656:14: warning: assignment to 'struct function_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
656 | func = pinmux_generic_get_function(pctl, index);
| ^
drivers/pinctrl/freescale/pinctrl-imx.c:661:13: error: invalid use of undefined type 'struct function_desc'
661 | func->name = np->name;
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c:662:13: error: invalid use of undefined type 'struct function_desc'
662 | func->num_group_names = of_get_child_count(np);
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c:663:17: error: invalid use of undefined type 'struct function_desc'
663 | if (func->num_group_names == 0) {
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c:668:52: error: invalid use of undefined type 'struct function_desc'
668 | group_names = devm_kcalloc(ipctl->dev, func->num_group_names,
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c:675:13: error: invalid use of undefined type 'struct function_desc'
675 | func->group_names = group_names;
| ^~
drivers/pinctrl/freescale/pinctrl-imx.c: In function 'imx_pinctrl_probe_dt':
>> drivers/pinctrl/freescale/pinctrl-imx.c:752:59: error: invalid application of 'sizeof' to incomplete type 'struct function_desc'
752 | function = devm_kzalloc(&pdev->dev, sizeof(*function),
| ^
>> drivers/pinctrl/freescale/pinctrl-imx.c:758:40: error: 'struct pinctrl_dev' has no member named 'pin_function_tree'
758 | radix_tree_insert(&pctl->pin_function_tree, i, function);
| ^~
>> drivers/pinctrl/freescale/pinctrl-imx.c:761:13: error: 'struct pinctrl_dev' has no member named 'num_functions'
761 | pctl->num_functions = nfuncs;
| ^~
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for PINCTRL_IMX
Depends on [n]: PINCTRL [=y] && OF [=n]
Selected by [y]:
- PINCTRL_IMX8MP [=y] && PINCTRL [=y] && SOC_IMX8M [=y]
Selected by [m]:
- PINCTRL_IMX8MM [=m] && PINCTRL [=y] && SOC_IMX8M [=y]
- PINCTRL_IMX8MN [=m] && PINCTRL [=y] && SOC_IMX8M [=y]
vim +260 drivers/pinctrl/freescale/pinctrl-imx.c
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 240
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 241 static int imx_pmx_set(struct pinctrl_dev *pctldev, unsigned selector,
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 242 unsigned group)
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 243 {
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 244 struct imx_pinctrl *ipctl = pinctrl_dev_get_drvdata(pctldev);
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 245 const struct imx_pinctrl_soc_info *info = ipctl->info;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 246 struct function_desc *func;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 247 struct group_desc *grp;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 248 struct imx_pin *pin;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 249 unsigned int npins;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 250 int i, err;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 251
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 252 /*
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 253 * Configure the mux mode for each pin in the group for a specific
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 254 * function.
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 255 */
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 256 grp = pinctrl_generic_get_group(pctldev, group);
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 257 if (!grp)
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 258 return -EINVAL;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 259
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 @260 func = pinmux_generic_get_function(pctldev, selector);
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 261 if (!func)
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 262 return -EINVAL;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 263
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 264 npins = grp->num_pins;
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 265
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 266 dev_dbg(ipctl->dev, "enable function %s group %s\n",
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 @267 func->name, grp->name);
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 268
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 269 for (i = 0; i < npins; i++) {
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 270 /*
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 271 * For IMX_USE_SCU case, we postpone the mux setting
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 272 * until config is set as we can set them together
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 273 * in one IPC call
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 274 */
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 275 pin = &((struct imx_pin *)(grp->data))[i];
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 276 if (!(info->flags & IMX_USE_SCU)) {
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 277 err = imx_pmx_set_one_pin_mmio(ipctl, pin);
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 278 if (err)
b96eea718bf697 drivers/pinctrl/freescale/pinctrl-imx.c A.s. Dong 2018-10-30 279 return err;
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 280 }
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 281 }
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 282
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 283 return 0;
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 284 }
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 285
3be6f65102a859 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-07-25 286 struct pinmux_ops imx_pmx_ops = {
3fd6d6ad73af90 drivers/pinctrl/freescale/pinctrl-imx.c Gary Bisson 2017-01-02 @287 .get_functions_count = pinmux_generic_get_function_count,
3fd6d6ad73af90 drivers/pinctrl/freescale/pinctrl-imx.c Gary Bisson 2017-01-02 @288 .get_function_name = pinmux_generic_get_function_name,
3fd6d6ad73af90 drivers/pinctrl/freescale/pinctrl-imx.c Gary Bisson 2017-01-02 @289 .get_function_groups = pinmux_generic_get_function_groups,
03e9f0cac5da6a drivers/pinctrl/pinctrl-imx.c Linus Walleij 2014-09-03 290 .set_mux = imx_pmx_set,
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 291 };
ae75ff81453840 drivers/pinctrl/pinctrl-imx.c Dong Aisheng 2012-04-27 292
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 293 /* decode generic config into raw register values */
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 294 static u32 imx_pinconf_decode_generic_config(struct imx_pinctrl *ipctl,
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 295 unsigned long *configs,
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 296 unsigned int num_configs)
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 297 {
f5843492ecefcf drivers/pinctrl/freescale/pinctrl-imx.c Stefan Agner 2018-01-06 298 const struct imx_pinctrl_soc_info *info = ipctl->info;
d6093367bc743b drivers/pinctrl/freescale/pinctrl-imx.c Stefan Agner 2018-01-06 299 const struct imx_cfg_params_decode *decode;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 300 enum pin_config_param param;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 301 u32 raw_config = 0;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 302 u32 param_val;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 303 int i, j;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 304
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 305 WARN_ON(num_configs > info->num_decodes);
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 306
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 307 for (i = 0; i < num_configs; i++) {
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 308 param = pinconf_to_config_param(configs[i]);
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 309 param_val = pinconf_to_config_argument(configs[i]);
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 310 decode = info->decodes;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 311 for (j = 0; j < info->num_decodes; j++) {
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 312 if (param == decode->param) {
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 313 if (decode->invert)
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 314 param_val = !param_val;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 315 raw_config |= (param_val << decode->shift)
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 316 & decode->mask;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 317 break;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 318 }
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 319 decode++;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 320 }
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 321 }
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 322
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 323 if (info->fixup)
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 324 info->fixup(configs, num_configs, &raw_config);
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 325
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 326 return raw_config;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 327 }
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 328
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 329 static u32 imx_pinconf_parse_generic_config(struct device_node *np,
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 330 struct imx_pinctrl *ipctl)
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 331 {
f5843492ecefcf drivers/pinctrl/freescale/pinctrl-imx.c Stefan Agner 2018-01-06 332 const struct imx_pinctrl_soc_info *info = ipctl->info;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 333 struct pinctrl_dev *pctl = ipctl->pctl;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 334 unsigned int num_configs;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 335 unsigned long *configs;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 336 int ret;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 337
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 338 if (!info->generic_pinconf)
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 339 return 0;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 340
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 @341 ret = pinconf_generic_parse_dt_config(np, pctl, &configs,
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 342 &num_configs);
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 343 if (ret)
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 344 return 0;
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 345
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 346 return imx_pinconf_decode_generic_config(ipctl, configs, num_configs);
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 347 }
a5cadbbb081cb8 drivers/pinctrl/freescale/pinctrl-imx.c Dong Aisheng 2017-05-19 348
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M
@ 2022-08-07 3:19 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-08-07 3:19 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2535 bytes --]
::::::
:::::: Manual check reason: "only Kconfig file updated"
::::::
BCC: lkp(a)intel.com
CC: Paul Gazzillo <paul@pgazz.com>
CC: Necip Fazil Yildiran <fazilyildiran@gmail.com>
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20220802110232.130758-1-francesco.dolcini@toradex.com>
References: <20220802110232.130758-1-francesco.dolcini@toradex.com>
TO: Francesco Dolcini <francesco.dolcini@toradex.com>
Hi Francesco,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linus/master v5.19 next-20220805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: x86_64-kismet-CONFIG_PINCTRL_IMX-CONFIG_PINCTRL_IMX8MM-0-0 (https://download.01.org/0day-ci/archive/20220807/202208071149.xmYuwmxq-lkp(a)intel.com/config)
reproduce:
# https://github.com/intel-lab-lkp/linux/commit/8cf69707b586a5aaa92ba9757f2d98383b220a43
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
git checkout 8cf69707b586a5aaa92ba9757f2d98383b220a43
# 1. reproduce by kismet
# install kmax per https://github.com/paulgazz/kmax/blob/master/README.md
kismet --linux-ksrc=linux --selectees CONFIG_PINCTRL_IMX --selectors CONFIG_PINCTRL_IMX8MM -a=x86_64
# 2. reproduce by make
# save the config file to linux source tree
cd linux
make ARCH=x86_64 olddefconfig
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
kismet warnings: (new ones prefixed by >>)
>> kismet: WARNING: unmet direct dependencies detected for PINCTRL_IMX when selected by PINCTRL_IMX8MM
WARNING: unmet direct dependencies detected for PINCTRL_IMX
Depends on [n]: PINCTRL [=y] && OF [=n]
Selected by [y]:
- PINCTRL_IMX8MM [=y] && PINCTRL [=y] && SOC_IMX8M [=y]
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M
@ 2022-08-07 5:32 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-08-07 5:32 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2535 bytes --]
::::::
:::::: Manual check reason: "only Kconfig file updated"
::::::
BCC: lkp(a)intel.com
CC: Paul Gazzillo <paul@pgazz.com>
CC: Necip Fazil Yildiran <fazilyildiran@gmail.com>
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20220802110232.130758-1-francesco.dolcini@toradex.com>
References: <20220802110232.130758-1-francesco.dolcini@toradex.com>
TO: Francesco Dolcini <francesco.dolcini@toradex.com>
Hi Francesco,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linus/master v5.19 next-20220805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: x86_64-kismet-CONFIG_PINCTRL_IMX-CONFIG_PINCTRL_IMX8MN-0-0 (https://download.01.org/0day-ci/archive/20220807/202208071321.H31MW5N9-lkp(a)intel.com/config)
reproduce:
# https://github.com/intel-lab-lkp/linux/commit/8cf69707b586a5aaa92ba9757f2d98383b220a43
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
git checkout 8cf69707b586a5aaa92ba9757f2d98383b220a43
# 1. reproduce by kismet
# install kmax per https://github.com/paulgazz/kmax/blob/master/README.md
kismet --linux-ksrc=linux --selectees CONFIG_PINCTRL_IMX --selectors CONFIG_PINCTRL_IMX8MN -a=x86_64
# 2. reproduce by make
# save the config file to linux source tree
cd linux
make ARCH=x86_64 olddefconfig
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
kismet warnings: (new ones prefixed by >>)
>> kismet: WARNING: unmet direct dependencies detected for PINCTRL_IMX when selected by PINCTRL_IMX8MN
WARNING: unmet direct dependencies detected for PINCTRL_IMX
Depends on [n]: PINCTRL [=y] && OF [=n]
Selected by [y]:
- PINCTRL_IMX8MN [=y] && PINCTRL [=y] && SOC_IMX8M [=y]
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M
@ 2022-08-07 7:58 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-08-07 7:58 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2535 bytes --]
::::::
:::::: Manual check reason: "only Kconfig file updated"
::::::
BCC: lkp(a)intel.com
CC: Paul Gazzillo <paul@pgazz.com>
CC: Necip Fazil Yildiran <fazilyildiran@gmail.com>
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20220802110232.130758-1-francesco.dolcini@toradex.com>
References: <20220802110232.130758-1-francesco.dolcini@toradex.com>
TO: Francesco Dolcini <francesco.dolcini@toradex.com>
Hi Francesco,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linus/master v5.19 next-20220805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: x86_64-kismet-CONFIG_PINCTRL_IMX-CONFIG_PINCTRL_IMX8MP-0-0 (https://download.01.org/0day-ci/archive/20220807/202208071509.57e6zWDc-lkp(a)intel.com/config)
reproduce:
# https://github.com/intel-lab-lkp/linux/commit/8cf69707b586a5aaa92ba9757f2d98383b220a43
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
git checkout 8cf69707b586a5aaa92ba9757f2d98383b220a43
# 1. reproduce by kismet
# install kmax per https://github.com/paulgazz/kmax/blob/master/README.md
kismet --linux-ksrc=linux --selectees CONFIG_PINCTRL_IMX --selectors CONFIG_PINCTRL_IMX8MP -a=x86_64
# 2. reproduce by make
# save the config file to linux source tree
cd linux
make ARCH=x86_64 olddefconfig
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
kismet warnings: (new ones prefixed by >>)
>> kismet: WARNING: unmet direct dependencies detected for PINCTRL_IMX when selected by PINCTRL_IMX8MP
WARNING: unmet direct dependencies detected for PINCTRL_IMX
Depends on [n]: PINCTRL [=y] && OF [=n]
Selected by [y]:
- PINCTRL_IMX8MP [=y] && PINCTRL [=y] && SOC_IMX8M [=y]
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M
@ 2022-08-07 10:22 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-08-07 10:22 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2535 bytes --]
::::::
:::::: Manual check reason: "only Kconfig file updated"
::::::
BCC: lkp(a)intel.com
CC: Paul Gazzillo <paul@pgazz.com>
CC: Necip Fazil Yildiran <fazilyildiran@gmail.com>
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20220802110232.130758-1-francesco.dolcini@toradex.com>
References: <20220802110232.130758-1-francesco.dolcini@toradex.com>
TO: Francesco Dolcini <francesco.dolcini@toradex.com>
Hi Francesco,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linus/master v5.19 next-20220805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: x86_64-kismet-CONFIG_PINCTRL_IMX-CONFIG_PINCTRL_IMX8MQ-0-0 (https://download.01.org/0day-ci/archive/20220807/202208071837.QpIY7Qgd-lkp(a)intel.com/config)
reproduce:
# https://github.com/intel-lab-lkp/linux/commit/8cf69707b586a5aaa92ba9757f2d98383b220a43
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Francesco-Dolcini/pinctrl-imx8m-kconfig-Depends-on-SOC_IMX8M/20220802-190320
git checkout 8cf69707b586a5aaa92ba9757f2d98383b220a43
# 1. reproduce by kismet
# install kmax per https://github.com/paulgazz/kmax/blob/master/README.md
kismet --linux-ksrc=linux --selectees CONFIG_PINCTRL_IMX --selectors CONFIG_PINCTRL_IMX8MQ -a=x86_64
# 2. reproduce by make
# save the config file to linux source tree
cd linux
make ARCH=x86_64 olddefconfig
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
kismet warnings: (new ones prefixed by >>)
>> kismet: WARNING: unmet direct dependencies detected for PINCTRL_IMX when selected by PINCTRL_IMX8MQ
WARNING: unmet direct dependencies detected for PINCTRL_IMX
Depends on [n]: PINCTRL [=y] && OF [=n]
Selected by [y]:
- PINCTRL_IMX8MQ [=y] && PINCTRL [=y] && SOC_IMX8M [=y]
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M
2022-08-02 11:02 Francesco Dolcini
@ 2022-08-22 8:40 ` Linus Walleij
2022-08-23 0:13 ` Peng Fan
0 siblings, 1 reply; 9+ messages in thread
From: Linus Walleij @ 2022-08-22 8:40 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Peng Fan, linux-gpio, Dong Aisheng, Fabio Estevam, Shawn Guo,
Jacky Bai, Pengutronix Kernel Team
On Tue, Aug 2, 2022 at 1:02 PM Francesco Dolcini
<francesco.dolcini@toradex.com> wrote:
> Change PINCTRL_IMX8M* dependency from just ARCH_MXC to SOC_IMX8M,
> likewise is done for other PINCTRL_IMX* kconfig. This avoid polluting
> the config when SOC_IMX8M is not enabled.
>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> A similar change would be needed for drivers/clk/imx/Kconfig,
> in addition to that the other pinctrl are selected by the SOC
> (config SOC_IMX7D -> select PINCTRL_IMX7D), while this is not true for
> IMX8M and these options.
>
> Not sure what should we do exactly, therefore the RFC tag, I stumbled on this while
> slimming down the imx_v6_v7_defconfig for my own needs, and after disabling SOC_IMX8M
> all these options were still enabled.
No comments for 20 days from the maintainers so resend it as non-RFC, if the
maintainers have no comments I guess we apply it and see what happens?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M
2022-08-22 8:40 ` Linus Walleij
@ 2022-08-23 0:13 ` Peng Fan
0 siblings, 0 replies; 9+ messages in thread
From: Peng Fan @ 2022-08-23 0:13 UTC (permalink / raw)
To: Linus Walleij, Francesco Dolcini
Cc: linux-gpio@vger.kernel.org, Aisheng Dong, Fabio Estevam,
Shawn Guo, Jacky Bai, Pengutronix Kernel Team
> Subject: Re: [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on
> SOC_IMX8M
>
> On Tue, Aug 2, 2022 at 1:02 PM Francesco Dolcini
> <francesco.dolcini@toradex.com> wrote:
>
> > Change PINCTRL_IMX8M* dependency from just ARCH_MXC to
> SOC_IMX8M,
> > likewise is done for other PINCTRL_IMX* kconfig. This avoid polluting
> > the config when SOC_IMX8M is not enabled.
> >
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > ---
> > A similar change would be needed for drivers/clk/imx/Kconfig, in
> > addition to that the other pinctrl are selected by the SOC (config
> > SOC_IMX7D -> select PINCTRL_IMX7D), while this is not true for IMX8M
> > and these options.
> >
> > Not sure what should we do exactly, therefore the RFC tag, I stumbled
> > on this while slimming down the imx_v6_v7_defconfig for my own needs,
> > and after disabling SOC_IMX8M all these options were still enabled.
>
> No comments for 20 days from the maintainers so resend it as non-RFC, if
> the maintainers have no comments I guess we apply it and see what
> happens?
Initially SOC_IMX8M* was introduced for some driver under drivers/soc/imx/
for i.MX8M. But it should be fine to let PINCTRL_IMX8M* depends on
SOC_IMX8M.
Regards,
Peng.
>
> Yours,
> Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-08-23 0:15 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-07 7:58 [RFC PATCH v1] pinctrl: imx8m: kconfig: Depends on SOC_IMX8M kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-08-07 10:22 kernel test robot
2022-08-07 5:32 kernel test robot
2022-08-07 3:19 kernel test robot
2022-08-06 15:41 kernel test robot
2022-08-06 12:36 kernel test robot
2022-08-02 11:02 Francesco Dolcini
2022-08-22 8:40 ` Linus Walleij
2022-08-23 0:13 ` Peng Fan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.