All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ondřej Jirman" <megi@xff.cz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	heiko@sntech.de, martijn@brixit.nl, ayufan@ayufan.eu,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro
Date: Mon, 8 Aug 2022 13:12:25 +0200	[thread overview]
Message-ID: <20220808111225.pslgct22eltiakiv@core> (raw)
In-Reply-To: <6461a695-171a-b160-5406-b8ac31c5ba0e@linaro.org>

Hello,

On Mon, Aug 08, 2022 at 09:35:55AM +0300, Krzysztof Kozlowski wrote:
> On 06/08/2022 01:44, Tom Fitzhenry wrote:
> 
> [...]
>
> > +
> > +	/* Power tree */
> > +	/* Root power source */
> > +	vcc_sysin: vcc-sysin {
> 
> regulator-vcc-sysin

Interestingly, most DTS files in rockchip/ use a -regulator
suffix and none use regulator- prefix. And this is inconsistent
across the larger DTS tree, because outside of rockchip/ most
DTS use a prefix.

Checked by grep -R 'regulator.*{' | grep -v state-me

regards,
	o.

> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc_sysin";
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +	};
> > +
> > +	/* Main 3.3v supply */
> > +	vcc3v3_sys: wifi_bat: vcc3v3-sys {
> 
> regulator-.....
> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc3v3_sys";
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		vin-supply = <&vcc_sysin>;
> > +	};
> > +
> > +	vcca1v8_s3: vcc1v8-s3 {
> 
> regulator-.....
> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcca1v8_s3";
> > +		regulator-min-microvolt = <1800000>;
> > +		regulator-max-microvolt = <1800000>;
> > +		vin-supply = <&vcc3v3_sys>;
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +	};
> > +};
> > +
> Best regards,
> Krzysztof

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Ondřej Jirman" <megi@xff.cz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	heiko@sntech.de, martijn@brixit.nl, ayufan@ayufan.eu,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro
Date: Mon, 8 Aug 2022 13:12:25 +0200	[thread overview]
Message-ID: <20220808111225.pslgct22eltiakiv@core> (raw)
In-Reply-To: <6461a695-171a-b160-5406-b8ac31c5ba0e@linaro.org>

Hello,

On Mon, Aug 08, 2022 at 09:35:55AM +0300, Krzysztof Kozlowski wrote:
> On 06/08/2022 01:44, Tom Fitzhenry wrote:
> 
> [...]
>
> > +
> > +	/* Power tree */
> > +	/* Root power source */
> > +	vcc_sysin: vcc-sysin {
> 
> regulator-vcc-sysin

Interestingly, most DTS files in rockchip/ use a -regulator
suffix and none use regulator- prefix. And this is inconsistent
across the larger DTS tree, because outside of rockchip/ most
DTS use a prefix.

Checked by grep -R 'regulator.*{' | grep -v state-me

regards,
	o.

> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc_sysin";
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +	};
> > +
> > +	/* Main 3.3v supply */
> > +	vcc3v3_sys: wifi_bat: vcc3v3-sys {
> 
> regulator-.....
> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc3v3_sys";
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		vin-supply = <&vcc_sysin>;
> > +	};
> > +
> > +	vcca1v8_s3: vcc1v8-s3 {
> 
> regulator-.....
> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcca1v8_s3";
> > +		regulator-min-microvolt = <1800000>;
> > +		regulator-max-microvolt = <1800000>;
> > +		vin-supply = <&vcc3v3_sys>;
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +	};
> > +};
> > +
> Best regards,
> Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Ondřej Jirman" <megi@xff.cz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	heiko@sntech.de, martijn@brixit.nl, ayufan@ayufan.eu,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro
Date: Mon, 8 Aug 2022 13:12:25 +0200	[thread overview]
Message-ID: <20220808111225.pslgct22eltiakiv@core> (raw)
In-Reply-To: <6461a695-171a-b160-5406-b8ac31c5ba0e@linaro.org>

Hello,

On Mon, Aug 08, 2022 at 09:35:55AM +0300, Krzysztof Kozlowski wrote:
> On 06/08/2022 01:44, Tom Fitzhenry wrote:
> 
> [...]
>
> > +
> > +	/* Power tree */
> > +	/* Root power source */
> > +	vcc_sysin: vcc-sysin {
> 
> regulator-vcc-sysin

Interestingly, most DTS files in rockchip/ use a -regulator
suffix and none use regulator- prefix. And this is inconsistent
across the larger DTS tree, because outside of rockchip/ most
DTS use a prefix.

Checked by grep -R 'regulator.*{' | grep -v state-me

regards,
	o.

> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc_sysin";
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +	};
> > +
> > +	/* Main 3.3v supply */
> > +	vcc3v3_sys: wifi_bat: vcc3v3-sys {
> 
> regulator-.....
> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc3v3_sys";
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		vin-supply = <&vcc_sysin>;
> > +	};
> > +
> > +	vcca1v8_s3: vcc1v8-s3 {
> 
> regulator-.....
> 
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcca1v8_s3";
> > +		regulator-min-microvolt = <1800000>;
> > +		regulator-max-microvolt = <1800000>;
> > +		vin-supply = <&vcc3v3_sys>;
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +	};
> > +};
> > +
> Best regards,
> Krzysztof

  reply	other threads:[~2022-08-08 11:13 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 23:44 [PATCH v2 0/3] Add support for the Pine64 PinePhone Pro phone Tom Fitzhenry
2022-08-05 23:44 ` Tom Fitzhenry
2022-08-05 23:44 ` Tom Fitzhenry
2022-08-05 23:44 ` [PATCH v2 1/3] arm64: dts: rockchip: Add RK3399-T opp Tom Fitzhenry
2022-08-05 23:44   ` Tom Fitzhenry
2022-08-05 23:44   ` Tom Fitzhenry
2022-08-08 14:25   ` Ondřej Jirman
2022-08-08 14:25     ` Ondřej Jirman
2022-08-08 14:25     ` Ondřej Jirman
2022-08-08 17:37     ` Samuel Dionne-Riel
2022-08-08 17:37       ` Samuel Dionne-Riel
2022-08-08 17:37       ` Samuel Dionne-Riel
2022-08-05 23:44 ` [PATCH v2 2/3] dt-bindings: arm: rockchip: Add PinePhone Pro bindings Tom Fitzhenry
2022-08-05 23:44   ` Tom Fitzhenry
2022-08-05 23:44   ` Tom Fitzhenry
2022-08-09 19:55   ` Rob Herring
2022-08-09 19:55     ` Rob Herring
2022-08-09 19:55     ` Rob Herring
2022-08-05 23:44 ` [PATCH v2 3/3] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro Tom Fitzhenry
2022-08-05 23:44   ` Tom Fitzhenry
2022-08-05 23:44   ` Tom Fitzhenry
2022-08-06  2:10   ` Caleb Connolly
2022-08-06  2:10     ` Caleb Connolly
2022-08-06  2:10     ` Caleb Connolly
2022-08-06  2:37     ` Tom Fitzhenry
2022-08-06  2:37       ` Tom Fitzhenry
2022-08-06  2:37       ` Tom Fitzhenry
2022-08-06 14:58       ` Caleb Connolly
2022-08-06 14:58         ` Caleb Connolly
2022-08-06 14:58         ` Caleb Connolly
2022-08-06 17:04         ` Ondřej Jirman
2022-08-06 17:04           ` Ondřej Jirman
2022-08-06 17:04           ` Ondřej Jirman
2022-08-08  6:38       ` Krzysztof Kozlowski
2022-08-08  6:38         ` Krzysztof Kozlowski
2022-08-08  6:38         ` Krzysztof Kozlowski
2022-08-08  7:24         ` Tom Fitzhenry
2022-08-08  7:24           ` Tom Fitzhenry
2022-08-08  7:24           ` Tom Fitzhenry
2022-08-08  6:35   ` Krzysztof Kozlowski
2022-08-08  6:35     ` Krzysztof Kozlowski
2022-08-08  6:35     ` Krzysztof Kozlowski
2022-08-08 11:12     ` Ondřej Jirman [this message]
2022-08-08 11:12       ` Ondřej Jirman
2022-08-08 11:12       ` Ondřej Jirman
2022-08-08 11:42       ` Krzysztof Kozlowski
2022-08-08 11:42         ` Krzysztof Kozlowski
2022-08-08 11:42         ` Krzysztof Kozlowski
2022-08-06  0:48 ` [PATCH v2 0/3] Add support for the Pine64 PinePhone Pro phone Caleb Connolly
2022-08-06  0:48   ` Caleb Connolly
2022-08-06  0:48   ` Caleb Connolly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808111225.pslgct22eltiakiv@core \
    --to=megi@xff.cz \
    --cc=ayufan@ayufan.eu \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=martijn@brixit.nl \
    --cc=robh+dt@kernel.org \
    --cc=tom@tom-fitzhenry.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.