From: "Pali Rohár" <pali@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards
Date: Mon, 8 Aug 2022 22:39:29 +0200 [thread overview]
Message-ID: <20220808203929.ci4eardma3jwnroc@pali> (raw)
In-Reply-To: <YvFzGhBRPTXgdCd8@lunn.ch>
On Monday 08 August 2022 22:33:30 Andrew Lunn wrote:
> On Mon, Aug 08, 2022 at 10:24:56PM +0200, Pali Rohár wrote:
> > PING?
>
> It is too late for the merge window.
>
> > > diff --git a/arch/arm64/boot/dts/marvell/armada-372x.dtsi b/arch/arm64/boot/dts/marvell/armada-372x.dtsi
> > > index 5ce55bdbb995..02ae1e153288 100644
> > > --- a/arch/arm64/boot/dts/marvell/armada-372x.dtsi
> > > +++ b/arch/arm64/boot/dts/marvell/armada-372x.dtsi
> > > @@ -13,7 +13,7 @@
> > >
> > > / {
> > > model = "Marvell Armada 3720 SoC";
> > > - compatible = "marvell,armada3720", "marvell,armada3710";
> > > + compatible = "marvell,armada3720", "marvell,armada3700";
>
> Does it make sense to have a compatible here? The board .dts should
> provide it. And if the board does not provide it, we probably want the
> board to not boot because it does not have a compatible.
>
> Andrew
Sounds like there should not be a compatible string and model string.
I can prepare a followup patch to remove those strings from SoC dtsi file.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Pali Rohár" <pali@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards
Date: Mon, 8 Aug 2022 22:39:29 +0200 [thread overview]
Message-ID: <20220808203929.ci4eardma3jwnroc@pali> (raw)
In-Reply-To: <YvFzGhBRPTXgdCd8@lunn.ch>
On Monday 08 August 2022 22:33:30 Andrew Lunn wrote:
> On Mon, Aug 08, 2022 at 10:24:56PM +0200, Pali Rohár wrote:
> > PING?
>
> It is too late for the merge window.
>
> > > diff --git a/arch/arm64/boot/dts/marvell/armada-372x.dtsi b/arch/arm64/boot/dts/marvell/armada-372x.dtsi
> > > index 5ce55bdbb995..02ae1e153288 100644
> > > --- a/arch/arm64/boot/dts/marvell/armada-372x.dtsi
> > > +++ b/arch/arm64/boot/dts/marvell/armada-372x.dtsi
> > > @@ -13,7 +13,7 @@
> > >
> > > / {
> > > model = "Marvell Armada 3720 SoC";
> > > - compatible = "marvell,armada3720", "marvell,armada3710";
> > > + compatible = "marvell,armada3720", "marvell,armada3700";
>
> Does it make sense to have a compatible here? The board .dts should
> provide it. And if the board does not provide it, we probably want the
> board to not boot because it does not have a compatible.
>
> Andrew
Sounds like there should not be a compatible string and model string.
I can prepare a followup patch to remove those strings from SoC dtsi file.
next prev parent reply other threads:[~2022-08-08 20:40 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 12:56 [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards Pali Rohár
2022-07-13 12:56 ` Pali Rohár
2022-07-13 19:42 ` Krzysztof Kozlowski
2022-07-13 19:42 ` Krzysztof Kozlowski
2022-07-13 20:03 ` Pali Rohár
2022-07-13 20:03 ` Pali Rohár
2022-07-14 6:56 ` Krzysztof Kozlowski
2022-07-14 6:56 ` Krzysztof Kozlowski
2022-07-14 9:36 ` Pali Rohár
2022-07-14 9:36 ` Pali Rohár
2022-08-08 20:24 ` Pali Rohár
2022-08-08 20:24 ` Pali Rohár
2022-08-08 20:33 ` Andrew Lunn
2022-08-08 20:33 ` Andrew Lunn
2022-08-08 20:39 ` Pali Rohár [this message]
2022-08-08 20:39 ` Pali Rohár
2022-09-02 22:31 ` Pali Rohár
2022-09-02 22:31 ` Pali Rohár
2022-09-19 23:19 ` Pali Rohár
2022-09-19 23:19 ` Pali Rohár
2022-09-30 23:38 ` Pali Rohár
2022-09-30 23:38 ` Pali Rohár
2022-10-09 12:06 ` Pali Rohár
2022-10-09 12:06 ` Pali Rohár
2022-11-01 22:44 ` Pali Rohár
2022-11-01 22:44 ` Pali Rohár
2022-11-28 18:21 ` Pali Rohár
2022-11-28 18:21 ` Pali Rohár
2022-12-16 18:21 ` Pali Rohár
2022-12-16 18:21 ` Pali Rohár
2023-01-22 11:28 ` Pali Rohár
2023-01-22 11:28 ` Pali Rohár
2023-02-01 7:46 ` Gregory CLEMENT
2023-02-01 7:46 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808203929.ci4eardma3jwnroc@pali \
--to=pali@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.