All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
Cc: virtualization@lists.linux-foundation.org, kernel@openvz.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] Create debugfs file with virtio balloon usage information
Date: Tue, 9 Aug 2022 06:35:25 -0400	[thread overview]
Message-ID: <20220809063414-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <f6b46a29-0f65-9081-5228-a1028fea2bef@virtuozzo.com>

On Tue, Jul 05, 2022 at 12:01:58PM +0300, Alexander Atanasov wrote:
> > > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h
> > > index ddaa45e723c4..f3ff7c4e5884 100644
> > > --- a/include/uapi/linux/virtio_balloon.h
> > > +++ b/include/uapi/linux/virtio_balloon.h
> > > @@ -40,6 +40,7 @@
> > >   /* Size of a PFN in the balloon interface. */
> > >   #define VIRTIO_BALLOON_PFN_SHIFT 12
> > > +#define VIRTIO_BALLOON_PAGE_SIZE (1<<VIRTIO_BALLOON_PFN_SHIFT)
> > >   #define VIRTIO_BALLOON_CMD_ID_STOP	0
> > >   #define VIRTIO_BALLOON_CMD_ID_DONE	1
> > Did you run checkpatch on this?
> 
> 
> Sure, i did:
> 
> scripts/checkpatch.pl
> ../outgoing/v4-0001-Create-debugfs-file-with-virtio-balloon-usage-inf.patch
> total: 0 errors, 0 warnings, 108 lines checked
> 
> ../outgoing/v4-0001-Create-debugfs-file-with-virtio-balloon-usage-inf.patch
> has no obvious style problems and is ready for submission.

Weird. There should be spaces around << I think.

-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Atanasov <alexander.atanasov@virtuozzo.com>
Cc: David Hildenbrand <david@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	kernel@openvz.org, virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] Create debugfs file with virtio balloon usage information
Date: Tue, 9 Aug 2022 06:35:25 -0400	[thread overview]
Message-ID: <20220809063414-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <f6b46a29-0f65-9081-5228-a1028fea2bef@virtuozzo.com>

On Tue, Jul 05, 2022 at 12:01:58PM +0300, Alexander Atanasov wrote:
> > > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/virtio_balloon.h
> > > index ddaa45e723c4..f3ff7c4e5884 100644
> > > --- a/include/uapi/linux/virtio_balloon.h
> > > +++ b/include/uapi/linux/virtio_balloon.h
> > > @@ -40,6 +40,7 @@
> > >   /* Size of a PFN in the balloon interface. */
> > >   #define VIRTIO_BALLOON_PFN_SHIFT 12
> > > +#define VIRTIO_BALLOON_PAGE_SIZE (1<<VIRTIO_BALLOON_PFN_SHIFT)
> > >   #define VIRTIO_BALLOON_CMD_ID_STOP	0
> > >   #define VIRTIO_BALLOON_CMD_ID_DONE	1
> > Did you run checkpatch on this?
> 
> 
> Sure, i did:
> 
> scripts/checkpatch.pl
> ../outgoing/v4-0001-Create-debugfs-file-with-virtio-balloon-usage-inf.patch
> total: 0 errors, 0 warnings, 108 lines checked
> 
> ../outgoing/v4-0001-Create-debugfs-file-with-virtio-balloon-usage-inf.patch
> has no obvious style problems and is ready for submission.

Weird. There should be spaces around << I think.

-- 
MST


  reply	other threads:[~2022-08-09 10:35 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05  8:36 [PATCH v4 1/1] Create debugfs file with virtio balloon usage information Alexander Atanasov
2022-07-05  8:59 ` Michael S. Tsirkin
2022-07-05  8:59   ` Michael S. Tsirkin
2022-07-05  9:01   ` Alexander Atanasov
2022-08-09 10:35     ` Michael S. Tsirkin [this message]
2022-08-09 10:35       ` Michael S. Tsirkin
2022-08-09 13:33       ` Alexander Atanasov
2022-07-13 16:25   ` Alexander Atanasov
2022-07-14 11:35 ` David Hildenbrand
2022-07-14 11:35   ` David Hildenbrand
2022-07-14 13:20   ` Alexander Atanasov
2022-07-14 13:24     ` David Hildenbrand
2022-07-14 13:24       ` David Hildenbrand
2022-07-14 13:35       ` Alexander Atanasov
2022-07-14 13:20   ` [PATCH v5 " Alexander Atanasov
2022-07-18 11:35     ` David Hildenbrand
2022-07-18 11:35       ` David Hildenbrand
2022-07-25 11:27       ` Alexander Atanasov
2022-07-25 11:36         ` David Hildenbrand
2022-07-25 11:36           ` David Hildenbrand
2022-07-26 14:08           ` [PATCH v6 1/2] " Alexander Atanasov
2022-07-26 14:10             ` [PATCH v6 2/2] Unify how inflated memory is accounted in virtio balloon driver Alexander Atanasov
2022-08-01 15:13               ` David Hildenbrand
2022-08-01 15:13                 ` David Hildenbrand
2022-08-09 10:42               ` Michael S. Tsirkin
2022-08-09 10:42                 ` Michael S. Tsirkin
2022-08-01 15:18             ` [PATCH v6 1/2] Create debugfs file with virtio balloon usage information David Hildenbrand
2022-08-01 15:18               ` David Hildenbrand
2022-08-01 16:34               ` Alexander Atanasov
2022-08-01 20:12                 ` David Hildenbrand
2022-08-01 20:12                   ` David Hildenbrand
2022-08-02  8:53                   ` [RFC] how the ballooned memory should be accounted by the drivers inside the guests? (was:[PATCH v6 1/2] Create debugfs file with virtio balloon usage information) Alexander Atanasov
2022-08-02 13:48                     ` David Hildenbrand
2022-08-02 13:48                       ` David Hildenbrand
2022-08-09  9:36                       ` Alexander Atanasov
2022-08-09  9:49                         ` [PATCH v1 1/2] Enable balloon drivers to report inflated memory Alexander Atanasov
2022-08-09  9:53                           ` [PATCH v1 2/2] Drivers: virtio: balloon: Report " Alexander Atanasov
2022-08-09 17:44                             ` Nadav Amit via Virtualization
2022-08-09 17:44                               ` Nadav Amit
2022-08-15 12:52                               ` Alexander Atanasov
2022-08-15 16:05                                 ` Nadav Amit via Virtualization
2022-08-15 16:05                                   ` Nadav Amit
2022-08-16  7:50                                   ` Alexander Atanasov
2022-08-09 10:32                           ` [PATCH v1 1/2] Enable balloon drivers to report " Michael S. Tsirkin
2022-08-10  5:54                             ` Alexander Atanasov
2022-08-10  6:05                               ` Michael S. Tsirkin
2022-08-10  7:50                                 ` Alexander Atanasov
2022-08-10  9:16                                   ` Michael S. Tsirkin
2022-08-10  3:05                           ` Muchun Song
2022-08-10  5:14                             ` Alexander Atanasov
2022-08-09 10:03                         ` [RFC] how the ballooned memory should be accounted by the drivers inside the guests? (was:[PATCH v6 1/2] Create debugfs file with virtio balloon usage information) David Hildenbrand
2022-08-09 10:03                           ` David Hildenbrand
2022-08-09 10:44             ` [PATCH v6 1/2] Create debugfs file with virtio balloon usage information Michael S. Tsirkin
2022-08-09 10:44               ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220809063414-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alexander.atanasov@virtuozzo.com \
    --cc=kernel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.