From: kernel test robot <lkp@intel.com>
To: Matt Flax <flatmax@flatmax.com>, alsa-devel@alsa-project.org
Cc: broonie@kernel.org, llvm@lists.linux.dev,
kbuild-all@lists.01.org, Matt Flax <flatmax@flatmax.com>
Subject: Re: [PATCH v2] ASoC: codecs: add uspport for the TI SRC4392 codec
Date: Tue, 9 Aug 2022 09:49:38 +0800 [thread overview]
Message-ID: <202208090909.Pg0BZGie-lkp@intel.com> (raw)
In-Reply-To: <20220808214028.2502801-1-flatmax@flatmax.com>
Hi Matt,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on tiwai-sound/for-next linus/master v5.19 next-20220808]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Matt-Flax/ASoC-codecs-add-uspport-for-the-TI-SRC4392-codec/20220809-054524
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: hexagon-randconfig-r002-20220808 (https://download.01.org/0day-ci/archive/20220809/202208090909.Pg0BZGie-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7a9219a8431d7740c0958e53078820cbfef4f3f7
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Matt-Flax/ASoC-codecs-add-uspport-for-the-TI-SRC4392-codec/20220809-054524
git checkout 7a9219a8431d7740c0958e53078820cbfef4f3f7
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash sound/soc/codecs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> sound/soc/codecs/src4xxx.c:277:3: warning: variable 'd' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
sound/soc/codecs/src4xxx.c:294:59: note: uninitialized use occurs here
ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_11, d);
^
sound/soc/codecs/src4xxx.c:221:20: note: initialize the variable 'd' to silence this warning
int val, pj, jd, d;
^
= 0
>> sound/soc/codecs/src4xxx.c:277:3: warning: variable 'jd' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
sound/soc/codecs/src4xxx.c:289:59: note: uninitialized use occurs here
ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_10, jd);
^~
sound/soc/codecs/src4xxx.c:221:17: note: initialize the variable 'jd' to silence this warning
int val, pj, jd, d;
^
= 0
>> sound/soc/codecs/src4xxx.c:277:3: warning: variable 'pj' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
sound/soc/codecs/src4xxx.c:284:59: note: uninitialized use occurs here
ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_0F, pj);
^~
sound/soc/codecs/src4xxx.c:221:13: note: initialize the variable 'pj' to silence this warning
int val, pj, jd, d;
^
= 0
3 warnings generated.
--
>> sound/soc/codecs/src4xxx-i2c.c:35:34: warning: unused variable 'src4xxx_of_match' [-Wunused-const-variable]
static const struct of_device_id src4xxx_of_match[] = {
^
1 warning generated.
vim +/d +277 sound/soc/codecs/src4xxx.c
213
214 static int src4xxx_hw_params(struct snd_pcm_substream *substream,
215 struct snd_pcm_hw_params *params,
216 struct snd_soc_dai *dai)
217 {
218 struct snd_soc_component *component = dai->component;
219 struct src4xxx *src4xxx = snd_soc_component_get_drvdata(component);
220 unsigned int mclk_div;
221 int val, pj, jd, d;
222 int reg;
223 int ret;
224
225 switch (dai->id) {
226 case SRC4XXX_PORTB:
227 reg = SRC4XXX_PORTB_CTL_06;
228 break;
229 default:
230 reg = SRC4XXX_PORTA_CTL_04;
231 }
232
233 if (src4xxx->master[dai->id]) {
234 mclk_div = src4xxx->mclk_hz/params_rate(params);
235 if (src4xxx->mclk_hz != mclk_div*params_rate(params)) {
236 dev_err(component->dev,
237 "mclk %d / rate %d has a remainder.\n",
238 src4xxx->mclk_hz, params_rate(params));
239 return -EINVAL;
240 }
241
242 val = ((int)mclk_div - 128) / 128;
243 if ((val < 0) | (val > 3)) {
244 dev_err(component->dev,
245 "div register setting %d is out of range\n",
246 val);
247 dev_err(component->dev,
248 "unsupported sample rate %d Hz for the master clock of %d Hz\n",
249 params_rate(params), src4xxx->mclk_hz);
250 return -EINVAL;
251 }
252
253 /* set the TX DIV */
254 ret = regmap_update_bits(src4xxx->regmap,
255 SRC4XXX_TX_CTL_07, SRC4XXX_TX_MCLK_DIV_MASK,
256 val<<SRC4XXX_TX_MCLK_DIV_SHIFT);
257 if (ret) {
258 dev_err(component->dev,
259 "Couldn't set the TX's div register to %d << %d = 0x%x\n",
260 val, SRC4XXX_TX_MCLK_DIV_SHIFT,
261 val<<SRC4XXX_TX_MCLK_DIV_SHIFT);
262 return ret;
263 }
264
265 /* set the PLL for the digital receiver */
266 switch (src4xxx->mclk_hz) {
267 case 24576000:
268 pj = 0x22;
269 jd = 0x00;
270 d = 0x00;
271 break;
272 case 22579200:
273 pj = 0x22;
274 jd = 0x1b;
275 d = 0xa3;
276 break;
> 277 default:
278 /* don't error out here,
279 * other parts of the chip are still functional
280 */
281 dev_info(component->dev,
282 "Couldn't set the RCV PLL as this master clock rate is unknown\n");
283 }
284 ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_0F, pj);
285 if (ret < 0)
286 dev_err(component->dev,
287 "Failed to update PLL register 0x%x\n",
288 SRC4XXX_RCV_PLL_0F);
> 289 ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_10, jd);
290 if (ret < 0)
291 dev_err(component->dev,
292 "Failed to update PLL register 0x%x\n",
293 SRC4XXX_RCV_PLL_10);
> 294 ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_11, d);
295 if (ret < 0)
296 dev_err(component->dev,
297 "Failed to update PLL register 0x%x\n",
298 SRC4XXX_RCV_PLL_11);
299
300 ret = regmap_update_bits(src4xxx->regmap,
301 SRC4XXX_TX_CTL_07, SRC4XXX_TX_MCLK_DIV_MASK,
302 val<<SRC4XXX_TX_MCLK_DIV_SHIFT);
303 if (ret < 0) {
304 dev_err(component->dev,
305 "Couldn't set the TX's div register to %d << %d = 0x%x\n",
306 val, SRC4XXX_TX_MCLK_DIV_SHIFT,
307 val<<SRC4XXX_TX_MCLK_DIV_SHIFT);
308 return ret;
309 }
310
311 return regmap_update_bits(src4xxx->regmap, reg,
312 SRC4XXX_MCLK_DIV_MASK, val);
313 } else
314 dev_info(dai->dev, "not setting up MCLK as not master\n");
315
316 return 0;
317 };
318
--
0-DAY CI Kernel Test Service
https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Matt Flax <flatmax@flatmax.com>, alsa-devel@alsa-project.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
broonie@kernel.org, Matt Flax <flatmax@flatmax.com>
Subject: Re: [PATCH v2] ASoC: codecs: add uspport for the TI SRC4392 codec
Date: Tue, 9 Aug 2022 09:49:38 +0800 [thread overview]
Message-ID: <202208090909.Pg0BZGie-lkp@intel.com> (raw)
In-Reply-To: <20220808214028.2502801-1-flatmax@flatmax.com>
Hi Matt,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on tiwai-sound/for-next linus/master v5.19 next-20220808]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Matt-Flax/ASoC-codecs-add-uspport-for-the-TI-SRC4392-codec/20220809-054524
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: hexagon-randconfig-r002-20220808 (https://download.01.org/0day-ci/archive/20220809/202208090909.Pg0BZGie-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7a9219a8431d7740c0958e53078820cbfef4f3f7
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Matt-Flax/ASoC-codecs-add-uspport-for-the-TI-SRC4392-codec/20220809-054524
git checkout 7a9219a8431d7740c0958e53078820cbfef4f3f7
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash sound/soc/codecs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> sound/soc/codecs/src4xxx.c:277:3: warning: variable 'd' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
sound/soc/codecs/src4xxx.c:294:59: note: uninitialized use occurs here
ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_11, d);
^
sound/soc/codecs/src4xxx.c:221:20: note: initialize the variable 'd' to silence this warning
int val, pj, jd, d;
^
= 0
>> sound/soc/codecs/src4xxx.c:277:3: warning: variable 'jd' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
sound/soc/codecs/src4xxx.c:289:59: note: uninitialized use occurs here
ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_10, jd);
^~
sound/soc/codecs/src4xxx.c:221:17: note: initialize the variable 'jd' to silence this warning
int val, pj, jd, d;
^
= 0
>> sound/soc/codecs/src4xxx.c:277:3: warning: variable 'pj' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
sound/soc/codecs/src4xxx.c:284:59: note: uninitialized use occurs here
ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_0F, pj);
^~
sound/soc/codecs/src4xxx.c:221:13: note: initialize the variable 'pj' to silence this warning
int val, pj, jd, d;
^
= 0
3 warnings generated.
--
>> sound/soc/codecs/src4xxx-i2c.c:35:34: warning: unused variable 'src4xxx_of_match' [-Wunused-const-variable]
static const struct of_device_id src4xxx_of_match[] = {
^
1 warning generated.
vim +/d +277 sound/soc/codecs/src4xxx.c
213
214 static int src4xxx_hw_params(struct snd_pcm_substream *substream,
215 struct snd_pcm_hw_params *params,
216 struct snd_soc_dai *dai)
217 {
218 struct snd_soc_component *component = dai->component;
219 struct src4xxx *src4xxx = snd_soc_component_get_drvdata(component);
220 unsigned int mclk_div;
221 int val, pj, jd, d;
222 int reg;
223 int ret;
224
225 switch (dai->id) {
226 case SRC4XXX_PORTB:
227 reg = SRC4XXX_PORTB_CTL_06;
228 break;
229 default:
230 reg = SRC4XXX_PORTA_CTL_04;
231 }
232
233 if (src4xxx->master[dai->id]) {
234 mclk_div = src4xxx->mclk_hz/params_rate(params);
235 if (src4xxx->mclk_hz != mclk_div*params_rate(params)) {
236 dev_err(component->dev,
237 "mclk %d / rate %d has a remainder.\n",
238 src4xxx->mclk_hz, params_rate(params));
239 return -EINVAL;
240 }
241
242 val = ((int)mclk_div - 128) / 128;
243 if ((val < 0) | (val > 3)) {
244 dev_err(component->dev,
245 "div register setting %d is out of range\n",
246 val);
247 dev_err(component->dev,
248 "unsupported sample rate %d Hz for the master clock of %d Hz\n",
249 params_rate(params), src4xxx->mclk_hz);
250 return -EINVAL;
251 }
252
253 /* set the TX DIV */
254 ret = regmap_update_bits(src4xxx->regmap,
255 SRC4XXX_TX_CTL_07, SRC4XXX_TX_MCLK_DIV_MASK,
256 val<<SRC4XXX_TX_MCLK_DIV_SHIFT);
257 if (ret) {
258 dev_err(component->dev,
259 "Couldn't set the TX's div register to %d << %d = 0x%x\n",
260 val, SRC4XXX_TX_MCLK_DIV_SHIFT,
261 val<<SRC4XXX_TX_MCLK_DIV_SHIFT);
262 return ret;
263 }
264
265 /* set the PLL for the digital receiver */
266 switch (src4xxx->mclk_hz) {
267 case 24576000:
268 pj = 0x22;
269 jd = 0x00;
270 d = 0x00;
271 break;
272 case 22579200:
273 pj = 0x22;
274 jd = 0x1b;
275 d = 0xa3;
276 break;
> 277 default:
278 /* don't error out here,
279 * other parts of the chip are still functional
280 */
281 dev_info(component->dev,
282 "Couldn't set the RCV PLL as this master clock rate is unknown\n");
283 }
284 ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_0F, pj);
285 if (ret < 0)
286 dev_err(component->dev,
287 "Failed to update PLL register 0x%x\n",
288 SRC4XXX_RCV_PLL_0F);
> 289 ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_10, jd);
290 if (ret < 0)
291 dev_err(component->dev,
292 "Failed to update PLL register 0x%x\n",
293 SRC4XXX_RCV_PLL_10);
> 294 ret = regmap_write(src4xxx->regmap, SRC4XXX_RCV_PLL_11, d);
295 if (ret < 0)
296 dev_err(component->dev,
297 "Failed to update PLL register 0x%x\n",
298 SRC4XXX_RCV_PLL_11);
299
300 ret = regmap_update_bits(src4xxx->regmap,
301 SRC4XXX_TX_CTL_07, SRC4XXX_TX_MCLK_DIV_MASK,
302 val<<SRC4XXX_TX_MCLK_DIV_SHIFT);
303 if (ret < 0) {
304 dev_err(component->dev,
305 "Couldn't set the TX's div register to %d << %d = 0x%x\n",
306 val, SRC4XXX_TX_MCLK_DIV_SHIFT,
307 val<<SRC4XXX_TX_MCLK_DIV_SHIFT);
308 return ret;
309 }
310
311 return regmap_update_bits(src4xxx->regmap, reg,
312 SRC4XXX_MCLK_DIV_MASK, val);
313 } else
314 dev_info(dai->dev, "not setting up MCLK as not master\n");
315
316 return 0;
317 };
318
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-08-09 1:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 21:40 [PATCH v2] ASoC: codecs: add uspport for the TI SRC4392 codec Matt Flax
2022-08-09 1:49 ` kernel test robot [this message]
2022-08-09 1:49 ` kernel test robot
2022-08-16 18:00 ` Nathan Chancellor
2022-08-16 18:00 ` Nathan Chancellor
2022-08-16 18:00 ` Nathan Chancellor
2022-08-17 5:44 ` Matt Flax
2022-08-17 5:44 ` Matt Flax
2022-08-17 5:44 ` Matt Flax
2022-08-17 15:45 ` Nathan Chancellor
2022-08-17 15:45 ` Nathan Chancellor
2022-08-17 15:45 ` Nathan Chancellor
2022-08-22 18:09 ` Mark Brown
2022-08-22 18:09 ` Mark Brown
2022-08-22 18:09 ` Mark Brown
2022-08-22 18:32 ` Nathan Chancellor
2022-08-22 18:32 ` Nathan Chancellor
2022-08-22 18:32 ` Nathan Chancellor
2022-08-17 16:21 ` Mark Brown
2022-08-17 16:21 ` Mark Brown
2022-08-17 16:21 ` Mark Brown
2022-08-17 17:23 ` Nathan Chancellor
2022-08-17 17:23 ` Nathan Chancellor
2022-08-17 17:23 ` Nathan Chancellor
2022-08-18 11:44 ` Mark Brown
2022-08-18 11:44 ` Mark Brown
2022-08-18 11:44 ` Mark Brown
2022-08-09 7:35 ` kernel test robot
2022-08-09 8:25 ` kernel test robot
2022-08-09 8:25 ` kernel test robot
2022-08-09 12:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208090909.Pg0BZGie-lkp@intel.com \
--to=lkp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=flatmax@flatmax.com \
--cc=kbuild-all@lists.01.org \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.