From: "hch@lst.de" <hch@lst.de>
To: "Hellstrom, Thomas" <thomas.hellstrom@intel.com>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"kernel@collabora.com" <kernel@collabora.com>,
"hch@lst.de" <hch@lst.de>,
"Auld, Matthew" <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH v5] drm/i915: stop using swiotlb
Date: Tue, 9 Aug 2022 20:51:57 +0200 [thread overview]
Message-ID: <20220809185157.GA15307@lst.de> (raw)
In-Reply-To: <1160a7c31084ab2259088e4bfe88b41ad61c2bcc.camel@intel.com>
On Mon, Aug 08, 2022 at 03:48:02PM +0000, Hellstrom, Thomas wrote:
> This whole thing looks a bit strange to me since with SWIOTLB actually
> used for i915, the driver should malfunction anyway as it doesn't do
> any dma_sync_sg_for_cpu() or dma_sync_sg_for_device(),
Yeah, I can't actually see any syncs in i915.
> and the driver
> assumes all coherent dma. Is that SWIOTLB=force kernel option still
> available?
Yes, although it is (and always has been) lower case swiotlb for the
option.
> Also, correct me if I'm wrong, but the original driver segment size
> appears to mean "the largest contiguous area that can be handled either
> by the device or the dma mapping layer" rather than the total space
> available for dma mappings? Not completely sure what
> dma_max_mapping_size() is returning, though?
dma_max_mapping_size is sort of both. It is is the largest contigous
size, but we really should not go above that to avoid starvation.
WARNING: multiple messages have this Message-ID (diff)
From: "hch@lst.de" <hch@lst.de>
To: "Hellstrom, Thomas" <thomas.hellstrom@intel.com>
Cc: "daniel@ffwll.ch" <daniel@ffwll.ch>,
"joonas.lahtinen@linux.intel.com"
<joonas.lahtinen@linux.intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"bob.beckett@collabora.com" <bob.beckett@collabora.com>,
"tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>,
"airlied@linux.ie" <airlied@linux.ie>, "hch@lst.de" <hch@lst.de>,
"Ursulin, Tvrtko" <tvrtko.ursulin@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"kernel@collabora.com" <kernel@collabora.com>,
"Auld, Matthew" <matthew.auld@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v5] drm/i915: stop using swiotlb
Date: Tue, 9 Aug 2022 20:51:57 +0200 [thread overview]
Message-ID: <20220809185157.GA15307@lst.de> (raw)
In-Reply-To: <1160a7c31084ab2259088e4bfe88b41ad61c2bcc.camel@intel.com>
On Mon, Aug 08, 2022 at 03:48:02PM +0000, Hellstrom, Thomas wrote:
> This whole thing looks a bit strange to me since with SWIOTLB actually
> used for i915, the driver should malfunction anyway as it doesn't do
> any dma_sync_sg_for_cpu() or dma_sync_sg_for_device(),
Yeah, I can't actually see any syncs in i915.
> and the driver
> assumes all coherent dma. Is that SWIOTLB=force kernel option still
> available?
Yes, although it is (and always has been) lower case swiotlb for the
option.
> Also, correct me if I'm wrong, but the original driver segment size
> appears to mean "the largest contiguous area that can be handled either
> by the device or the dma mapping layer" rather than the total space
> available for dma mappings? Not completely sure what
> dma_max_mapping_size() is returning, though?
dma_max_mapping_size is sort of both. It is is the largest contigous
size, but we really should not go above that to avoid starvation.
next prev parent reply other threads:[~2022-08-09 18:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 15:39 [Intel-gfx] [PATCH v5] drm/i915: stop using swiotlb Robert Beckett
2022-07-26 15:39 ` Robert Beckett
2022-07-26 15:39 ` Robert Beckett
2022-07-26 16:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: stop using swiotlb (rev5) Patchwork
2022-07-26 22:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-27 18:44 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: stop using swiotlb (rev6) Patchwork
2022-07-27 19:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-28 8:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-28 14:03 ` Tvrtko Ursulin
2022-07-28 15:54 ` Robert Beckett
2022-07-28 16:07 ` Tvrtko Ursulin
2022-08-08 15:48 ` [Intel-gfx] [PATCH v5] drm/i915: stop using swiotlb Hellstrom, Thomas
2022-08-08 15:48 ` Hellstrom, Thomas
2022-08-08 15:48 ` Hellstrom, Thomas
2022-08-09 11:36 ` [Intel-gfx] " Tvrtko Ursulin
2022-08-09 11:36 ` Tvrtko Ursulin
2022-08-09 11:36 ` Tvrtko Ursulin
2022-08-09 18:54 ` [Intel-gfx] " hch
2022-08-09 18:54 ` hch
2022-08-09 18:51 ` hch [this message]
2022-08-09 18:51 ` hch
2022-10-06 13:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: stop using swiotlb (rev7) Patchwork
2022-10-06 13:49 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809185157.GA15307@lst.de \
--to=hch@lst.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.