All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH vhost 0/2] virtio_net: fix for stuck when change ring size with dev down
Date: Thu, 11 Aug 2022 04:11:22 -0400	[thread overview]
Message-ID: <20220811041041-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220811080258.79398-1-xuanzhuo@linux.alibaba.com>

On Thu, Aug 11, 2022 at 04:02:56PM +0800, Xuan Zhuo wrote:
> When dev is set to DOWN state, napi has been disabled, if we modify the
> ring size at this time, we should not call napi_disable() again, which
> will cause stuck.
> 
> And all operations are under the protection of rtnl_lock, so there is no
> need to consider concurrency issues.
> 
> PS.
> Hi Michael, I don't know which way is more convenient for you, so I split the
> commit into two commits, so you can fixup to my previous commit:
> 
>     virtio_net: support tx queue resize
> 	virtio_net: support rx queue resize
> 
> Xuan Zhuo (2):
>   virtio_net: fix for stuck when change rx ring size with dev down
>   virtio_net: fix for stuck when change tx ring size with dev down
> 
>  drivers/net/virtio_net.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)


Which patches does this fix?
Maybe I should squash.

> --
> 2.31.0

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: virtualization@lists.linux-foundation.org,
	Jason Wang <jasowang@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH vhost 0/2] virtio_net: fix for stuck when change ring size with dev down
Date: Thu, 11 Aug 2022 04:11:22 -0400	[thread overview]
Message-ID: <20220811041041-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220811080258.79398-1-xuanzhuo@linux.alibaba.com>

On Thu, Aug 11, 2022 at 04:02:56PM +0800, Xuan Zhuo wrote:
> When dev is set to DOWN state, napi has been disabled, if we modify the
> ring size at this time, we should not call napi_disable() again, which
> will cause stuck.
> 
> And all operations are under the protection of rtnl_lock, so there is no
> need to consider concurrency issues.
> 
> PS.
> Hi Michael, I don't know which way is more convenient for you, so I split the
> commit into two commits, so you can fixup to my previous commit:
> 
>     virtio_net: support tx queue resize
> 	virtio_net: support rx queue resize
> 
> Xuan Zhuo (2):
>   virtio_net: fix for stuck when change rx ring size with dev down
>   virtio_net: fix for stuck when change tx ring size with dev down
> 
>  drivers/net/virtio_net.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)


Which patches does this fix?
Maybe I should squash.

> --
> 2.31.0


  parent reply	other threads:[~2022-08-11  8:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11  8:02 [PATCH vhost 0/2] virtio_net: fix for stuck when change ring size with dev down Xuan Zhuo
2022-08-11  8:02 ` Xuan Zhuo
2022-08-11  8:02 ` [PATCH 1/2] virtio_net: fix for stuck when change rx " Xuan Zhuo
2022-08-11  8:02   ` Xuan Zhuo
2022-08-11  8:02 ` [PATCH 2/2] virtio_net: fix for stuck when change tx " Xuan Zhuo
2022-08-11  8:02   ` Xuan Zhuo
2022-08-11  8:11 ` Michael S. Tsirkin [this message]
2022-08-11  8:11   ` [PATCH vhost 0/2] virtio_net: fix for stuck when change " Michael S. Tsirkin
2022-08-11  8:12   ` Xuan Zhuo
2022-08-11  8:12     ` Xuan Zhuo
2022-08-11 17:37   ` Jakub Kicinski
2022-08-12  1:30     ` Xuan Zhuo
2022-08-12  1:30       ` Xuan Zhuo
2022-08-12 19:47       ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811041041-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.