From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Christophe Branchereau <cbranchereau@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jonathan Bakker <xc-racer2@live.ca>,
linux-spi@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Brown <broonie@kernel.org>,
Paul Cercueil <paul@crapouillou.net>,
Sam Ravnborg <sam@ravnborg.org>,
devicetree@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
Pratyush Yadav <p.yadav@ti.com>
Subject: Re: [PATCH] spi/panel: dt-bindings: drop 3-wire from common properties
Date: Fri, 12 Aug 2022 11:03:43 -0600 [thread overview]
Message-ID: <20220812170343.GA327951-robh@kernel.org> (raw)
In-Reply-To: <20220810131311.428645-1-krzysztof.kozlowski@linaro.org>
On Wed, 10 Aug 2022 16:13:11 +0300, Krzysztof Kozlowski wrote:
> The spi-3wire property is device specific and should be accepted only if
> device really needs them. Drop it from common spi-peripheral-props.yaml
> schema, mention in few panel drivers which use it and include instead in
> the SPI controller bindings. The controller bindings will provide
> spi-3wire type validation and one place for description. Each device
> schema must list the property if it is applicable.
>
> The Samsung S6E63M0 panel uses also spi-cpha/cpol properties on at least
> one board (ste-ux500-samsung-janice/dts), so add also these to the
> panel's bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml | 2 ++
> .../bindings/display/panel/leadtek,ltk035c5444t.yaml | 2 ++
> .../devicetree/bindings/display/panel/samsung,s6e63m0.yaml | 4 ++++
> Documentation/devicetree/bindings/spi/spi-controller.yaml | 5 +++++
> .../devicetree/bindings/spi/spi-peripheral-props.yaml | 5 -----
> 5 files changed, 13 insertions(+), 5 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
Sam Ravnborg <sam@ravnborg.org>,
Jonathan Bakker <xc-racer2@live.ca>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-spi@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Christophe Branchereau <cbranchereau@gmail.com>,
Pratyush Yadav <p.yadav@ti.com>
Subject: Re: [PATCH] spi/panel: dt-bindings: drop 3-wire from common properties
Date: Fri, 12 Aug 2022 11:03:43 -0600 [thread overview]
Message-ID: <20220812170343.GA327951-robh@kernel.org> (raw)
In-Reply-To: <20220810131311.428645-1-krzysztof.kozlowski@linaro.org>
On Wed, 10 Aug 2022 16:13:11 +0300, Krzysztof Kozlowski wrote:
> The spi-3wire property is device specific and should be accepted only if
> device really needs them. Drop it from common spi-peripheral-props.yaml
> schema, mention in few panel drivers which use it and include instead in
> the SPI controller bindings. The controller bindings will provide
> spi-3wire type validation and one place for description. Each device
> schema must list the property if it is applicable.
>
> The Samsung S6E63M0 panel uses also spi-cpha/cpol properties on at least
> one board (ste-ux500-samsung-janice/dts), so add also these to the
> panel's bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml | 2 ++
> .../bindings/display/panel/leadtek,ltk035c5444t.yaml | 2 ++
> .../devicetree/bindings/display/panel/samsung,s6e63m0.yaml | 4 ++++
> Documentation/devicetree/bindings/spi/spi-controller.yaml | 5 +++++
> .../devicetree/bindings/spi/spi-peripheral-props.yaml | 5 -----
> 5 files changed, 13 insertions(+), 5 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-08-12 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 13:13 [PATCH] spi/panel: dt-bindings: drop 3-wire from common properties Krzysztof Kozlowski
2022-08-10 16:18 ` Mark Brown
2022-08-10 16:18 ` Mark Brown
2022-08-10 16:44 ` Krzysztof Kozlowski
2022-08-10 16:44 ` Krzysztof Kozlowski
2022-08-12 17:03 ` Rob Herring [this message]
2022-08-12 17:03 ` Rob Herring
2022-08-15 15:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812170343.GA327951-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=cbranchereau@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=p.yadav@ti.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.